New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748445 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: When the link is dropped in the NTP page, the bookmark chip doesn't disappear

Project Member Reported by divya.pa...@techmahindra.com, Jul 25 2017

Issue description

Chrome Version: 62.0.3166.0
OS: Ubuntu 14.04

What steps will reproduce the problem?

Prerequisite: Make sure material design bookmark manager is enabled 

(1)Launch chrome>> Navigate to any site (eg: www.amazon.com)>> bookmark the page
(2)Go to Bookmark manager>> Drag the bookmarked link and drop it in NTP
(3)Now go back to the bookmark manager page and observe the Mouse pointer

Expected 
When the link is dropped in the NTP page, the bookmark chip should disappear from the mouse pointer

Actual
When the link is dropped in the NTP page, the bookmark chip doesn't disappear from the mouse pointer

Note: Issue is not reproducible on Windows

This is a Regression issue broken in M-62
===============================
Manual Bisect info:

Good Build: 62.0.3165.0
Bad Build: 62.0.3166.0


 
Actual_bookmarkchip.ogv
4.1 MB View Download
Expected_bookmarkchip.ogv
3.6 MB View Download
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Ubuntu 14.04 using latest chrome version #62.0.3166.0.
Issue is not reproducible on OS-Mac.
Labels: -Needs-Bisect hasbisect-per-revision
Owner: calamity@chromium.org
Status: Assigned (was: Untriaged)
Using per revision bisect providing bisect results below

Bisect Information:
--------------------
You are probably looking for a change made after 488911 (known good), but no later than 488912 (first known bad).

Change Log URL: 
-----------------
https://chromium.googlesource.com/chromium/src/+log/e11490bf3263f3ac1fa9107107a76871dc6b83a9..b19fa87f981ce227433d03283bf8175d1c29742f

calamity@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!!
Cc: msrchandra@chromium.org calamity@chromium.org ranjitkan@chromium.org rbasuvula@chromium.org nyerramilli@chromium.org
 Issue 750596  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbff1ee589e80d2208a60b754b9dbc95066c8a6b

commit cbff1ee589e80d2208a60b754b9dbc95066c8a6b
Author: Christopher Lam <calamity@chromium.org>
Date: Wed Aug 02 00:24:38 2017

[MD Bookmarks] Clear internal drag when native drag starts.

Bug:  748445 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5d10fdd84b302a3064056f73544d8c214aace2bd
Reviewed-on: https://chromium-review.googlesource.com/584558
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491167}
[modify] https://crrev.com/cbff1ee589e80d2208a60b754b9dbc95066c8a6b/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/cbff1ee589e80d2208a60b754b9dbc95066c8a6b/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js

Status: Fixed (was: Assigned)

Sign in to add a comment