New issue
Advanced search Search tips

Issue 748428 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Bad-cast to blink::WebView from invalid vptr;test_runner::TestRunnerForSpecificView::Reset;test_runner::WebViewTestProxyBase::Reset

Project Member Reported by ClusterFuzz, Jul 25 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6739911901446144

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x07fb8a0c4600
Crash State:
  Bad-cast to blink::WebView from invalid vptr
  test_runner::TestRunnerForSpecificView::Reset
  test_runner::WebViewTestProxyBase::Reset
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=479114:479272

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6739911901446144


Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 25 2017

Labels: M-61
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 25 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 25 2017

Labels: Pri-1

Comment 4 by vakh@chromium.org, Jul 26 2017

Cc: mbarbe...@chromium.org
mbarbella -- this seems like a test issue. Could you please take a look? Thanks.
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 26 2017

Labels: -Security_Impact-Head Security_Impact-Beta

Comment 6 by vakh@chromium.org, Jul 26 2017

Components: Blink>Infra
Owner: lukasza@chromium.org
Status: Assigned (was: Untriaged)
lukasza@ -- can you please take a look? Thanks.

Comment 7 by gov...@chromium.org, Jul 26 2017

URGENT - PTAL.
Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the M61 branch #3163 ASAP to have enough baking time in Beta before Stable promotion. Thank you!

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label.

Labels: -ReleaseBlock-Stable ReleaseBlock-NA
All the frames on the callstack (above IPC code) belong to the test code (and none belong to the product code).  Therefore I think it is safe to say that this shouldn't block the release.  Hopefully the bug repros and I can take a look when I am back from the paternity leave.
Project Member

Comment 9 by ClusterFuzz, Aug 9 2017

ClusterFuzz has detected this issue as fixed in range 492686:492688.

Detailed report: https://clusterfuzz.com/testcase?key=6739911901446144

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x07fb8a0c4600
Crash State:
  Bad-cast to blink::WebView from invalid vptr
  test_runner::TestRunnerForSpecificView::Reset
  test_runner::WebViewTestProxyBase::Reset
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=479114:479272
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=492686:492688

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6739911901446144


See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Aug 9 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6739911901446144 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Aug 9 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 12 by sheriffbot@chromium.org, Aug 11 2017

Labels: Merge-Request-61
Project Member

Comment 13 by sheriffbot@chromium.org, Aug 11 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: awhalley@chromium.org
+awhalley@ for M61 merge review
Project Member

Comment 15 by ClusterFuzz, Aug 21 2017

ClusterFuzz is analyzing your testcase. Developers can follow the progress at https://clusterfuzz.com/testcase?key=6194253301809152.
This doesn't seem fixed but it should be test only, so it probably shouldn't be tracked as a security bug. I re-uploaded the test case with an ASan build to get a better idea of what's going on (seems like a use-after-free).
Labels: -Type-Bug-Security -Restrict-View-SecurityNotify -ReleaseBlock-NA -Security_Severity-High -Security_Impact-Beta Type-Bug-Regression
thanks mbarbella@ - changing bug type.
Labels: -Hotlist-Merge-Review -Merge-Review-61
Project Member

Comment 19 by ClusterFuzz, Aug 21 2017

Labels: Security_Severity-High
Detailed report: https://clusterfuzz.com/testcase?key=6194253301809152

Job Type: linux_asan_content_shell_drt
Crash Type: Heap-use-after-free READ 8
Crash Address: 0x617000046e80
Crash State:
  test_runner::TestRunnerForSpecificView::Reset
  test_runner::WebViewTestProxyBase::Reset
  test_runner::TestInterfaces::ResetAll
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=389884:390115

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6194253301809152

See https://github.com/google/clusterfuzz-tools for more information.

A recommended severity was added to this bug. Please change the severity if it is inaccurate.

Project Member

Comment 20 by ClusterFuzz, Aug 21 2017

Labels: Needs-Feedback
ClusterFuzz testcase 6194253301809152 is still reproducing on tip-of-tree build (trunk).

Please re-test your fix against this testcase and if the fix was incorrect or incomplete, please re-open the bug. Otherwise, ignore this notification and add ClusterFuzz-Wrong label.

Sign in to add a comment