New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748420 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 669910

Blocking:
issue 692940



Sign in to add a comment

Get V8 onto exparchive

Project Member Reported by machenb...@chromium.org, Jul 25 2017

Issue description

Tracker bug.
 
Components: Infra>Client>V8
There shouldn't be any actual work for this bug: I am merging the exparchive implementation into archive and batcharchive, so no change in usage is required. 
Alright, lemme know when that's done and I can see if our upload/download performance for test262 on windows improves...
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/efd9e01aa5b966208fc4fa9e00c586788f487c43

commit efd9e01aa5b966208fc4fa9e00c586788f487c43
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Mon Oct 09 02:02:58 2017

isolate: Change the "always use exparchive" experiment.

The 10% experiment will now use exparchive via the batcharchive mode
rather than running every one separately.

TBR=dpranke@chromium.org,mcgreevy@chromium.org
BUG= 524758 , 692940 , 748420 

Change-Id: Idc39056ebce617dd7a74009bcf3567321d49b74b
Reviewed-on: https://chromium-review.googlesource.com/706737
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>

[modify] https://crrev.com/efd9e01aa5b966208fc4fa9e00c586788f487c43/scripts/slave/recipe_modules/isolate/examples/full.expected/always-use-exparchive.json
[modify] https://crrev.com/efd9e01aa5b966208fc4fa9e00c586788f487c43/scripts/slave/recipe_modules/isolate/examples/full.py
[modify] https://crrev.com/efd9e01aa5b966208fc4fa9e00c586788f487c43/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.py
[modify] https://crrev.com/efd9e01aa5b966208fc4fa9e00c586788f487c43/scripts/slave/README.recipes.md
[modify] https://crrev.com/efd9e01aa5b966208fc4fa9e00c586788f487c43/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build10.json
[modify] https://crrev.com/efd9e01aa5b966208fc4fa9e00c586788f487c43/scripts/slave/recipe_modules/isolate/api.py
[modify] https://crrev.com/efd9e01aa5b966208fc4fa9e00c586788f487c43/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build5.json

Labels: Needs-Feedback
Owner: mcgreevy@chromium.org
Status: Assigned (was: Available)
The main V8 blocker has been fixed and all runtime dependency configs have been migrated to GN.

I assume here is no work to do based on comment 2. Could you please confirm this?

I already ripped out the test262 tar/untar feature on V8 side, and got no download time regression on windows. So I assume this just uses exparchive now in batcharchive.

A thing that confused me a bit was finding this special webkit_layout_tests_exparchive:
https://cs.chromium.org/chromium/src/BUILD.gn?type=cs&q=BUILD.gn+layout_tests&sq=package:chromium&l=895

Is that just some leftover from experiments?
Friendly ping... can we just close this?

The link in the comment above moved and is now https://cs.chromium.org/chromium/src/BUILD.gn?type=cs&q=BUILD.gn+layout_tests&sq=package:chromium&l=878
Yes, since you are depending on the standard chromium isolate binaries, and they only use the exparchive implemenatation now, you can close this.
(closing, since I am the owner).
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Thanks!

Sign in to add a comment