This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

+bustamante@
My recommendation is to wait until M61 since M60 is already in stable ramp-up. This merge will require a respin. Can you please confirm if this is a critical issue or can it wait until M61? The fixes don't seem too large and it appears it's well tested. 

I'd also like to wait until M61, do you have numbers of on the number users affected?  Rejecting for now, feel free to add the "Merge-Review-60" label back if you think this is critical.

Depends on how you define critical I guess, but it definitely makes for a very bad user experience. It manifests in the video feed looking something like this:

https://bugs.chromium.org/p/webrtc/issues/attachment?aid=287587&inline=1

We're estimating that something like 3% of calls are experiencing this, but it will depend a lot on how much packet loss is present (higher packets loss makes it more likely to occur). 

3% of video calls meets the bar.  Approving for merge into M60.

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/6294a7eb71c891e9ea41273a7a94113f6802d0da

commit 6294a7eb71c891e9ea41273a7a94113f6802d0da
Author: Erik Språng <sprang@webrtc.org>
Date: Tue Aug 01 09:33:37 2017

Merge WebRTC r18998 and r19018 to M60 branch

This CL is cherry pick of the following two commits:

1) RtpFrameReferenceFinder VP8 reference calculation fix.

Review-Url: https://codereview.webrtc.org/2980943003
Cr-Commit-Position: refs/heads/master@{#19018}

2) Fix potential incorrect sync flags used with screenshare TL stream.

Review-Url: https://codereview.webrtc.org/2978743002
Cr-Commit-Position: refs/heads/master@{#18999}

TEST=webrtc unit tests plus manual verification.
BUG= chromium:748417 ,  webrtc:7768 ,  webrtc:7980 
R=philipel@webrtc.org

Review-Url: https://codereview.webrtc.org/2992123002 .
Cr-Commit-Position: refs/branch-heads/60@{#11}
Cr-Branched-From: c61bf947b4ac31f3500858ffcae6fee39d799930-refs/heads/master@{#18252}

[modify] https://crrev.com/6294a7eb71c891e9ea41273a7a94113f6802d0da/webrtc/modules/video_coding/codecs/vp8/default_temporal_layers.cc
[modify] https://crrev.com/6294a7eb71c891e9ea41273a7a94113f6802d0da/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc
[modify] https://crrev.com/6294a7eb71c891e9ea41273a7a94113f6802d0da/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc
[modify] https://crrev.com/6294a7eb71c891e9ea41273a7a94113f6802d0da/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h
[modify] https://crrev.com/6294a7eb71c891e9ea41273a7a94113f6802d0da/webrtc/modules/video_coding/rtp_frame_reference_finder.cc
[modify] https://crrev.com/6294a7eb71c891e9ea41273a7a94113f6802d0da/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot