Issue metadata
Sign in to add a comment
|
Add tests for ServiceWorkerURLLoaderJob |
||||||||||||||||||||||||
Issue descriptionSee https://bugs.chromium.org/p/chromium/issues/detail?id=715640#c39 for a bit more details. This is necessary to make sure SW glue works in the expected way.
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7dc050d2529b88fa111061546118da58e105161b commit 7dc050d2529b88fa111061546118da58e105161b Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Jul 27 08:33:25 2017 service worker: Cleanup ServiceWorkerURLRequestJobTest - Don't use URLRequest::status() whose documentation says "Do not use!". This required removing some expectations and making more precise ones. - Remove "http" from MockProtocolHandler's name, which handles "https" protocol. - Add more documentation. Bug: 748416 Change-Id: I2c0e4d77714b3af343533983fdcb4b261d5a7233 Reviewed-on: https://chromium-review.googlesource.com/584694 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#489883} [modify] https://crrev.com/7dc050d2529b88fa111061546118da58e105161b/content/browser/service_worker/service_worker_url_request_job_unittest.cc
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cf09cad4121d7465d99c753bf30ccb604ae18a9 commit 9cf09cad4121d7465d99c753bf30ccb604ae18a9 Author: Matt Falkenhagen <falken@chromium.org> Date: Tue Aug 01 10:36:25 2017 service worker: Add a test for ServiceWorkerURLLoaderJob. Also teach it to handle the case where there is no response body. This test class will evolve as more cases are added. Currently it just tests the simple case where a service worker handles the request, with no response body. Bug: 748416 Change-Id: Ifda79696eff766e725e6ee28fc27ca3d9ef9cf84 Reviewed-on: https://chromium-review.googlesource.com/590836 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#490935} [modify] https://crrev.com/9cf09cad4121d7465d99c753bf30ccb604ae18a9/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/9cf09cad4121d7465d99c753bf30ccb604ae18a9/content/browser/service_worker/service_worker_storage.h [modify] https://crrev.com/9cf09cad4121d7465d99c753bf30ccb604ae18a9/content/browser/service_worker/service_worker_url_loader_job.cc [modify] https://crrev.com/9cf09cad4121d7465d99c753bf30ccb604ae18a9/content/browser/service_worker/service_worker_url_loader_job.h [add] https://crrev.com/9cf09cad4121d7465d99c753bf30ccb604ae18a9/content/browser/service_worker/service_worker_url_loader_job_unittest.cc [modify] https://crrev.com/9cf09cad4121d7465d99c753bf30ccb604ae18a9/content/browser/service_worker/service_worker_url_request_job_unittest.cc [modify] https://crrev.com/9cf09cad4121d7465d99c753bf30ccb604ae18a9/content/public/test/test_url_loader_client.h [modify] https://crrev.com/9cf09cad4121d7465d99c753bf30ccb604ae18a9/content/test/BUILD.gn
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c5b274f7418b2fe0800d52140a6e8230c4d6392 commit 5c5b274f7418b2fe0800d52140a6e8230c4d6392 Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Aug 03 05:24:35 2017 service worker: Add blob test for ServiceWorkerURLLoaderJob. Bug: 748416 Change-Id: I37d13c799e61fff05bc75675a888ce2630995aa0 Reviewed-on: https://chromium-review.googlesource.com/597576 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491651} [modify] https://crrev.com/5c5b274f7418b2fe0800d52140a6e8230c4d6392/content/browser/service_worker/service_worker_url_loader_job_unittest.cc [modify] https://crrev.com/5c5b274f7418b2fe0800d52140a6e8230c4d6392/content/browser/service_worker/service_worker_url_request_job_unittest.cc [modify] https://crrev.com/5c5b274f7418b2fe0800d52140a6e8230c4d6392/content/common/service_worker/service_worker_types.h
,
Aug 10 2017
emim: Here is a big bug for when you have time :)
,
Aug 16 2017
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86100992ebd2b9d9640190c4452d9c09193c9db6 commit 86100992ebd2b9d9640190c4452d9c09193c9db6 Author: Emi Morikawa <emim@google.com> Date: Mon Aug 21 08:47:07 2017 Add a test for stream response to ServiceWorkerURLLoaderJob Bug: 748416 Change-Id: I47fc69aabce76f2ce999b44dff99797ecec6f6ae Reviewed-on: https://chromium-review.googlesource.com/618216 Commit-Queue: Emi Morikawa <emim@google.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#495885} [modify] https://crrev.com/86100992ebd2b9d9640190c4452d9c09193c9db6/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/096b36b46bb1d5fddd1632414fd29658e60915c4 commit 096b36b46bb1d5fddd1632414fd29658e60915c4 Author: Emi Morikawa <emim@google.com> Date: Wed Aug 23 07:37:22 2017 Add more ServiceWorkerURLLoaderJob tests: fallback and fetch event dispatch failure. Bug: 748416 Change-Id: I0e8050ef5f25bd5224f555d6c4499dd5e14b2ce8 Reviewed-on: https://chromium-review.googlesource.com/623017 Commit-Queue: Emi Morikawa <emim@google.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#496616} [modify] https://crrev.com/096b36b46bb1d5fddd1632414fd29658e60915c4/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d025dad7376106819c056e565b37f49c972c171 commit 2d025dad7376106819c056e565b37f49c972c171 Author: Emi Morikawa <emim@google.com> Date: Fri Aug 25 05:08:21 2017 Add more ServiceWorkerURLLoaderJob tests: early response and fallback to network. Bug: 748416 Change-Id: I591f1bd5d7a905ab35b90059fcbe993bb2008bc9 Reviewed-on: https://chromium-review.googlesource.com/627353 Commit-Queue: Emi Morikawa <emim@google.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#497325} [modify] https://crrev.com/2d025dad7376106819c056e565b37f49c972c171/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19a781d5c693db99f8c1dcc4e4cd7c3844796e58 commit 19a781d5c693db99f8c1dcc4e4cd7c3844796e58 Author: Emi Morikawa <emim@google.com> Date: Fri Aug 25 07:53:39 2017 Add more ServiceWorkerURLLoaderJob tests: stream response abort. Bug: 748416 , 758455 Change-Id: I588f541fde654339e73c01852419992911ac6af9 Reviewed-on: https://chromium-review.googlesource.com/631080 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Emi Morikawa <emim@google.com> Cr-Commit-Position: refs/heads/master@{#497350} [modify] https://crrev.com/19a781d5c693db99f8c1dcc4e4cd7c3844796e58/content/browser/service_worker/service_worker_url_loader_job.cc [modify] https://crrev.com/19a781d5c693db99f8c1dcc4e4cd7c3844796e58/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ce3d229d5b4361e6c7d3f2f9e8aca8406620356 commit 2ce3d229d5b4361e6c7d3f2f9e8aca8406620356 Author: Emi Morikawa <emim@google.com> Date: Fri Aug 25 11:29:20 2017 Add more ServiceWorkerURLLoaderJob tests: NonExistentBlobUUIDResponse. Bug: 748416 , 732750 Change-Id: Ie14a3a3cb6f445d83ed054d80e241abfd3975b3f Reviewed-on: https://chromium-review.googlesource.com/635064 Commit-Queue: Emi Morikawa <emim@google.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#497376} [modify] https://crrev.com/2ce3d229d5b4361e6c7d3f2f9e8aca8406620356/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd0efa6a9192b26f257bb2aa3c4135dbec38ce37 commit fd0efa6a9192b26f257bb2aa3c4135dbec38ce37 Author: Emi Morikawa <emim@google.com> Date: Mon Aug 28 10:37:00 2017 Add more ServiceWorkerURLLoaderJob tests: stream response and cancel. Bug: 748416 , 758455 Change-Id: Ie6f103f9bc6de2a59192648f4b7526a5d3a13076 Reviewed-on: https://chromium-review.googlesource.com/637060 Commit-Queue: Emi Morikawa <emim@google.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#497729} [modify] https://crrev.com/fd0efa6a9192b26f257bb2aa3c4135dbec38ce37/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
,
Aug 30 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by falken@chromium.org
, Jul 26 2017Owner: falken@chromium.org
Status: Started (was: Untriaged)