Issue metadata
Sign in to add a comment
|
S13nServiceWorker: Make ServiceWorker's ScriptURLLoader write the loaded script into SW storage |
||||||||||||||||||||||||
Issue descriptionCurrently it's still a dumb proxy loader to the network service.
,
Jul 31 2017
,
Aug 17 2017
,
Aug 17 2017
,
Sep 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5e0122bdba5acf2f4dced6513ae39b1f99b3323 commit a5e0122bdba5acf2f4dced6513ae39b1f99b3323 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Mon Sep 04 07:51:39 2017 ServiceWorker: Remove unused BlobStorageContext from ServiceWorkerScriptURLLoader ServiceWorkerScriptURLLoader doesn't need BlobStorageContext. To simplify the code, this CL removes it. Bug: 748415 Change-Id: Ic173c3336b4a7ea364cc91057610b804bab46f55 Reviewed-on: https://chromium-review.googlesource.com/648535 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#499451} [modify] https://crrev.com/a5e0122bdba5acf2f4dced6513ae39b1f99b3323/content/browser/service_worker/service_worker_context_core.cc [modify] https://crrev.com/a5e0122bdba5acf2f4dced6513ae39b1f99b3323/content/browser/service_worker/service_worker_context_core.h [modify] https://crrev.com/a5e0122bdba5acf2f4dced6513ae39b1f99b3323/content/browser/service_worker/service_worker_context_wrapper.cc [modify] https://crrev.com/a5e0122bdba5acf2f4dced6513ae39b1f99b3323/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/a5e0122bdba5acf2f4dced6513ae39b1f99b3323/content/browser/service_worker/service_worker_script_url_loader.cc [modify] https://crrev.com/a5e0122bdba5acf2f4dced6513ae39b1f99b3323/content/browser/service_worker/service_worker_script_url_loader.h [modify] https://crrev.com/a5e0122bdba5acf2f4dced6513ae39b1f99b3323/content/browser/service_worker/service_worker_script_url_loader_factory.cc [modify] https://crrev.com/a5e0122bdba5acf2f4dced6513ae39b1f99b3323/content/browser/service_worker/service_worker_script_url_loader_factory.h
,
Sep 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b27fba0270d402310586cc7afc5ee0562073483 commit 8b27fba0270d402310586cc7afc5ee0562073483 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Mon Sep 04 10:53:24 2017 ServiceWorker: Remove dependency on ServiceWorkerProviderHost from ServiceWorkerScriptURLLoader Dependency on ServiceWorkerProviderHost makes it difficult to write unittests because it requires complicated setup routines. This CL removes the dependency. Bug: 748415 Change-Id: I799c2368ac6d1b830e7e6780f189580d287158ea Reviewed-on: https://chromium-review.googlesource.com/647415 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#499476} [modify] https://crrev.com/8b27fba0270d402310586cc7afc5ee0562073483/content/browser/service_worker/service_worker_script_url_loader.cc [modify] https://crrev.com/8b27fba0270d402310586cc7afc5ee0562073483/content/browser/service_worker/service_worker_script_url_loader.h [modify] https://crrev.com/8b27fba0270d402310586cc7afc5ee0562073483/content/browser/service_worker/service_worker_script_url_loader_factory.cc
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c961265c9813336941863383f7b66da5f486194 commit 9c961265c9813336941863383f7b66da5f486194 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Wed Sep 06 08:36:18 2017 ServiceWorker: Early return when a service worker is redundant on OnReceiveResponse ServiceWorkerScriptURLLoader doesn't have to proceed to read a resource when a service worker is redundant or a service worker context is already gone. This CL makes the loader return early in the case. Bug: 748415 Change-Id: I464b35edeb08237be76d69f9f4bed174eb13970e Reviewed-on: https://chromium-review.googlesource.com/648533 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#499905} [modify] https://crrev.com/9c961265c9813336941863383f7b66da5f486194/content/browser/blob_storage/blob_internals_url_loader.cc [modify] https://crrev.com/9c961265c9813336941863383f7b66da5f486194/content/browser/histogram_internals_url_loader.cc [modify] https://crrev.com/9c961265c9813336941863383f7b66da5f486194/content/browser/service_worker/service_worker_script_url_loader.cc [modify] https://crrev.com/9c961265c9813336941863383f7b66da5f486194/content/browser/webui/web_ui_url_loader_factory.cc [modify] https://crrev.com/9c961265c9813336941863383f7b66da5f486194/content/network/cache_url_loader.cc [modify] https://crrev.com/9c961265c9813336941863383f7b66da5f486194/content/public/common/resource_request_completion_status.cc [modify] https://crrev.com/9c961265c9813336941863383f7b66da5f486194/content/public/common/resource_request_completion_status.h
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b858118100be3a58e2e93590d150af9dd79aed36 commit b858118100be3a58e2e93590d150af9dd79aed36 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Fri Sep 08 09:34:38 2017 ServiceWorker: Add unittests for ServiceWorkerScriptURLLoader Bug: 748415 Change-Id: Iffe72cd50d5dbfac1c1d015abb0b5c5570106796 Reviewed-on: https://chromium-review.googlesource.com/647672 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#500546} [modify] https://crrev.com/b858118100be3a58e2e93590d150af9dd79aed36/content/browser/service_worker/service_worker_script_url_loader.cc [modify] https://crrev.com/b858118100be3a58e2e93590d150af9dd79aed36/content/browser/service_worker/service_worker_script_url_loader.h [add] https://crrev.com/b858118100be3a58e2e93590d150af9dd79aed36/content/browser/service_worker/service_worker_script_url_loader_unittest.cc [modify] https://crrev.com/b858118100be3a58e2e93590d150af9dd79aed36/content/test/BUILD.gn
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a11d82cd4ca71efcb85f9bbefe18f938412fb23a commit a11d82cd4ca71efcb85f9bbefe18f938412fb23a Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Wed Sep 13 03:11:34 2017 S13nServiceWorker: Call SetMainScriptHttpResponseInfo() only when main script load Before this CL, in ServiceWorkerScriptURLLoader, ServiceWorkerVersion::SetMainScriptHttpResponseInfo() is called regardless of a resource request type. As the function name indicates, that must be called only when the main script of the service worker is being loaded. This CL fixes it. Bug: 748415 Change-Id: Idcf2a295340eaa03bccd4f49b8759cf149665fa9 Reviewed-on: https://chromium-review.googlesource.com/662957 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#501534} [modify] https://crrev.com/a11d82cd4ca71efcb85f9bbefe18f938412fb23a/content/browser/service_worker/service_worker_script_url_loader.cc [modify] https://crrev.com/a11d82cd4ca71efcb85f9bbefe18f938412fb23a/content/browser/service_worker/service_worker_script_url_loader.h [modify] https://crrev.com/a11d82cd4ca71efcb85f9bbefe18f938412fb23a/content/browser/service_worker/service_worker_script_url_loader_unittest.cc
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91107ba29a77715ef2a3c15c79c9c261ad49cb5f commit 91107ba29a77715ef2a3c15c79c9c261ad49cb5f Author: Matt Menke <mmenke@chromium.org> Date: Wed Sep 13 16:20:05 2017 Disable a bunch of ServiceWorkerVersionBrowserTests These likely broke in https://chromium-review.googlesource.com/662957 TBR: nhiroki@chromium.org NOTRY: true Bug: 748415 Change-Id: Ied4e2131b72e8dc004a7ac695d35a86e2acf8a1b Reviewed-on: https://chromium-review.googlesource.com/664845 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#501652} [modify] https://crrev.com/91107ba29a77715ef2a3c15c79c9c261ad49cb5f/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c37741f3c09b7e8fbfd80b119165ac2ad883e0f2 commit c37741f3c09b7e8fbfd80b119165ac2ad883e0f2 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Fri Sep 15 11:53:52 2017 S13nServiceWorker: Store fetched scripts into the service worker script storage This CL implements ServiceWorkerScriptURLLoader used for loading scripts for a new (installing) service worker. It fetches the script (the main script or imported script) from network, and forwards the response to a service worker in a renderer process, while also writing the response into the service worker script storage. See the class-level comments on ServiceWorkerScriptURLLoader for more detailed sequence. Some security checks and error handling will be implemented in following CLs (e.g., MIME check). This disables ServiceWorkerVersionBrowserV8CacheTest.Restart in content_browsertests and some layout tests. Regarding the browser test, it needs to read installed scripts, but the mechanism for that hasn't been implemented yet (see https://crbug.com/756312 ). Bug: 748415 , 756312 Change-Id: I388ea13083347eb276f168a9eef4efadcb069e59 Reviewed-on: https://chromium-review.googlesource.com/618434 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#502227} [modify] https://crrev.com/c37741f3c09b7e8fbfd80b119165ac2ad883e0f2/content/browser/service_worker/service_worker_script_url_loader.cc [modify] https://crrev.com/c37741f3c09b7e8fbfd80b119165ac2ad883e0f2/content/browser/service_worker/service_worker_script_url_loader.h [modify] https://crrev.com/c37741f3c09b7e8fbfd80b119165ac2ad883e0f2/content/browser/service_worker/service_worker_script_url_loader_unittest.cc [modify] https://crrev.com/c37741f3c09b7e8fbfd80b119165ac2ad883e0f2/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter [modify] https://crrev.com/c37741f3c09b7e8fbfd80b119165ac2ad883e0f2/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Sep 19 2017
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76a3cdbbb4901d7897f4943984bfd824b3e591b3 commit 76a3cdbbb4901d7897f4943984bfd824b3e591b3 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Fri Sep 22 06:24:54 2017 S13nServiceWorker: Handle write failures because the data pipe is full in SWScriptURLLoader This CL ... - changes the flag for DataPipeProducerHandle::WriteData() from MOJO_WRITE_DATA_FLAG_ALL_OR_NONE to MOJO_WRITE_DATA_FLAG_NONE because we don't have to ensure the all-or-nothing write, - handles the case where DataPipeProducerHandle::WriteData() fails to write the given data to the mojo's producer handle because the data pipe is full (i.e., MOJO_RESULT_SHOULD_WAIT), - notifies the actual written size (|bytes_written|) to ServiceWorkerScriptURLLoader::OnWriteDataComplete() instead of available buffer size (|available_bytes|), and - simplifies arguments of ServiceWorkerScriptURLLoader::WriteData() for cleanup. This fixes crashes on http/tests/permissions/test-api-surface.html. Bug: 748415 , 766241 Change-Id: If5a95a3f18521ac96d696a6a568bc32735b09eb8 Reviewed-on: https://chromium-review.googlesource.com/672803 Reviewed-by: Kinuko Yasuda (slow) <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#503670} [modify] https://crrev.com/76a3cdbbb4901d7897f4943984bfd824b3e591b3/content/browser/service_worker/service_worker_script_url_loader.cc [modify] https://crrev.com/76a3cdbbb4901d7897f4943984bfd824b3e591b3/content/browser/service_worker/service_worker_script_url_loader.h [modify] https://crrev.com/76a3cdbbb4901d7897f4943984bfd824b3e591b3/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Sep 25 2017
,
Sep 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f9086c79731afc9671801207f124e0f61c520c7 commit 3f9086c79731afc9671801207f124e0f61c520c7 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Mon Sep 25 23:30:01 2017 S13nServiceWorker: Check the HTTP response code in ServiceWorkerScriptURLLoader ServiceWorkerScriptURLLoader should check the HTTP response code of fetched scripts and abort the subsequent sequence if it's not 2XX. This CL adds the check and a unit test. This also adds MockHTTPServer that is a handy utility to provide mocked responses for ServiceWorkerScriptURLLoader and adds a test case for an empty response body. Bug: 748415 Change-Id: I3512d20650809ffca593197c200ce8dc871d435d Reviewed-on: https://chromium-review.googlesource.com/672224 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#504211} [modify] https://crrev.com/3f9086c79731afc9671801207f124e0f61c520c7/content/browser/service_worker/service_worker_script_url_loader.cc [modify] https://crrev.com/3f9086c79731afc9671801207f124e0f61c520c7/content/browser/service_worker/service_worker_script_url_loader_unittest.cc
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a463b0b86cf41b5859d686e483ccfef325ed30d commit 5a463b0b86cf41b5859d686e483ccfef325ed30d Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Sep 26 01:42:51 2017 S13nServiceWorker: Check the MIME type in ServiceWorkerScriptURLLoader ServiceWorkerScriptURLLoader should check the MIME type of fetched scripts and abort the subsequent sequence if it's not valid. This CL adds the check and unit tests. Bug: 748415 Change-Id: I59a3013377f216f249ac0f3155fe9146b13a66e5 Reviewed-on: https://chromium-review.googlesource.com/672177 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#504254} [modify] https://crrev.com/5a463b0b86cf41b5859d686e483ccfef325ed30d/content/browser/service_worker/service_worker_script_url_loader.cc [modify] https://crrev.com/5a463b0b86cf41b5859d686e483ccfef325ed30d/content/browser/service_worker/service_worker_script_url_loader_unittest.cc
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81f3a6b9554d7f31aefb68c747a72b407a9ca922 commit 81f3a6b9554d7f31aefb68c747a72b407a9ca922 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Sep 26 03:49:20 2017 S13nServiceWorker: Re-enable ServiceWorkerVersionBrowserTests on Mojo FYI bots These tests were disabled by [1] because [2] introduced a stricter check for ServiceWorkerVersion::status_ (status_ == NEW) and failed them. We found this check is wrong because ServiceWorkerScriptURLLoader is also used for importScripts() that can be called during the Install event (status_ == INSTALLING). This CL makes ServiceWorkerScriptURLLoaderFactory determines whether to use ServiceWorkerScriptURLLoader more precisely, and changes the check in the ctor of ServiceWorkerScriptURLLoader based on that. This CL also corrects the timings to update the service worker status in the browser tests to avoid the check failure. [1] https://chromium-review.googlesource.com/c/664845/ [2] https://chromium-review.googlesource.com/c/662957/ Bug: 748415 , 765064 , 767916 Change-Id: Id7786510170129514058e6f5c5d4bd1860b4be1b Reviewed-on: https://chromium-review.googlesource.com/674143 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#504277} [modify] https://crrev.com/81f3a6b9554d7f31aefb68c747a72b407a9ca922/content/browser/service_worker/service_worker_browsertest.cc [modify] https://crrev.com/81f3a6b9554d7f31aefb68c747a72b407a9ca922/content/browser/service_worker/service_worker_script_url_loader.cc [modify] https://crrev.com/81f3a6b9554d7f31aefb68c747a72b407a9ca922/content/browser/service_worker/service_worker_script_url_loader_factory.cc [modify] https://crrev.com/81f3a6b9554d7f31aefb68c747a72b407a9ca922/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13073107d564a984c3bd4e1696cde9544eb6c6f0 commit 13073107d564a984c3bd4e1696cde9544eb6c6f0 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Sep 26 22:05:21 2017 S13nServiceWorker: Check the Service-Worker-Allowed header in ServiceWorkerScriptURLLoader This CL makes ServiceWorkerScriptURLLoader check the path restriction defined in the Service Worker spec: https://w3c.github.io/ServiceWorker/#service-worker-script-response Bug: 748415 Change-Id: I651f83050752a869d0fe9cde1e415d02da70a2c1 Reviewed-on: https://chromium-review.googlesource.com/684104 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#504495} [modify] https://crrev.com/13073107d564a984c3bd4e1696cde9544eb6c6f0/content/browser/service_worker/service_worker_script_url_loader.cc [modify] https://crrev.com/13073107d564a984c3bd4e1696cde9544eb6c6f0/content/browser/service_worker/service_worker_script_url_loader_unittest.cc
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a20756de39297b6b98ba99e2941c9108dac93395 commit a20756de39297b6b98ba99e2941c9108dac93395 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Wed Sep 27 14:21:03 2017 S13nServiceWorker: Check certificate errors in ServiceWorkerScriptURLLoader This CL makes ServiceWorkerScriptURLLoader check certificate errors. The errors should be ignored when the --ignore-certificate-errors flag etc are specified, but it's not implemented in this CL yet. Bug: 748415 Change-Id: Ie62043fd307929b978f37ecec0bb359aa2201f77 Reviewed-on: https://chromium-review.googlesource.com/686016 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#504660} [modify] https://crrev.com/a20756de39297b6b98ba99e2941c9108dac93395/content/browser/service_worker/service_worker_script_url_loader.cc [modify] https://crrev.com/a20756de39297b6b98ba99e2941c9108dac93395/content/browser/service_worker/service_worker_script_url_loader_unittest.cc
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19b224136432cd2a6aa550197ea36df9fa8b3cd7 commit 19b224136432cd2a6aa550197ea36df9fa8b3cd7 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Wed Oct 04 08:26:58 2017 S13nServiceWorker: Fail a request for service worker scripts when it's redirected Resource requests for service worker scripts should not follow redirects. This CL makes ServiceWorkerScriptURLLoader return net::ERR_UNSAFE_REDIRECT in the case and enables layout tests for that. Bug: 748415 Change-Id: Icef0d63c022204b7a67cba6fe7d596a20650c5b1 Reviewed-on: https://chromium-review.googlesource.com/699774 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#506333} [modify] https://crrev.com/19b224136432cd2a6aa550197ea36df9fa8b3cd7/content/browser/service_worker/service_worker_script_url_loader.cc [modify] https://crrev.com/19b224136432cd2a6aa550197ea36df9fa8b3cd7/content/browser/service_worker/service_worker_script_url_loader_unittest.cc [modify] https://crrev.com/19b224136432cd2a6aa550197ea36df9fa8b3cd7/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Oct 13 2017
The main part of the SWScriptURLLoader was already implemented. I'll file separate issues if needed.
,
Oct 13 2017
Oh..., I associated a following CL with a wrong issue... The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc1ab7013feffe44f48c7d770fb5b8d490f0afd9 commit cc1ab7013feffe44f48c7d770fb5b8d490f0afd9 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Oct 03 07:10:17 2017 S13nServiceWorker: Add a test for large scripts in ServiceWorkerScriptURLLoader Bug: 686016 Change-Id: Iaa3ea05e70c46568a8874b2186e6add4305fcb0a Reviewed-on: https://chromium-review.googlesource.com/689814 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505973} [modify] https://crrev.com/cc1ab7013feffe44f48c7d770fb5b8d490f0afd9/content/browser/service_worker/service_worker_script_url_loader.cc [modify] https://crrev.com/cc1ab7013feffe44f48c7d770fb5b8d490f0afd9/content/browser/service_worker/service_worker_script_url_loader.h [modify] https://crrev.com/cc1ab7013feffe44f48c7d770fb5b8d490f0afd9/content/browser/service_worker/service_worker_script_url_loader_unittest.cc
,
Nov 7 2017
Apologies, applied the wrong component in bulk. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by kinuko@chromium.org
, Jul 25 2017