ppapi_unittests failing on 2 builders Builders failed on: - Linux ChromiumOS MSan Tests: https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests - Linux MSan Tests: https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests
Looking at: https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/1943 CLs of dsinclair@ and xhwang@ seem related. Could you guys take a look?
Revert in https://chromium-review.googlesource.com/c/584613
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f50e9f3557742f92ff33521a24988578ba8fa88f commit f50e9f3557742f92ff33521a24988578ba8fa88f Author: Dan Sinclair <dsinclair@chromium.org> Date: Tue Jul 25 21:06:41 2017 Reland "Add touch selection for PDF files."" This reverts commit 0d7094b3c580b9da58028691e5936026a2b3ed91. > Add touch selection for PDF files. > > This CL plumbs through the need methods to allow touch selection with > the Copy action in PDF files. > > Bug: chromium:490184 , chromium:737585 > Change-Id: I4dab62833dac94b6c8ed59cbcc7db8e9387a7fde > Reviewed-on: https://chromium-review.googlesource.com/565899 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Raymes Khoury <raymes@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Commit-Queue: Dan Sinclair <dsinclair@chromium.org> > Cr-Commit-Position: refs/heads/master@{#489071} TBR=jam@chromium.org,tsepez@chromium.org,raymes@chromium.org Bug: chromium:490184 , chromium:737585, chromium:748390 Change-Id: Ief608baf13b1a5c04e19c9d7c2e7398e8d1c8cb5 Reviewed-on: https://chromium-review.googlesource.com/585107 Reviewed-by: Dan Sinclair <dsinclair@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Dan Sinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#489429} [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/components/pdf/browser/pdf_web_contents_helper.cc [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/components/pdf/browser/pdf_web_contents_helper.h [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/components/pdf/common/BUILD.gn [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/components/pdf/common/pdf.mojom [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/components/pdf/renderer/DEPS [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/components/pdf/renderer/pepper_pdf_host.cc [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/components/pdf/renderer/pepper_pdf_host.h [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/content/public/renderer/pepper_plugin_instance.h [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/content/renderer/pepper/fake_pepper_plugin_instance.cc [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/content/renderer/pepper/fake_pepper_plugin_instance.h [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/content/renderer/pepper/pepper_plugin_instance_impl.cc [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/content/renderer/pepper/pepper_plugin_instance_impl.h [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/pdf/out_of_process_instance.cc [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/pdf/out_of_process_instance.h [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/pdf/pdf_engine.h [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/pdf/pdfium/pdfium_engine.cc [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/pdf/pdfium/pdfium_engine.h [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/ppapi/c/private/ppb_pdf.h [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/ppapi/c/private/ppp_pdf.h [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/ppapi/cpp/private/pdf.cc [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/ppapi/cpp/private/pdf.h [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/ppapi/proxy/pdf_resource.cc [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/ppapi/proxy/pdf_resource.h [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/ppapi/proxy/pdf_resource_unittest.cc [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/ppapi/proxy/ppapi_messages.h [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/ppapi/proxy/ppp_pdf_proxy.cc [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/ppapi/proxy/ppp_pdf_proxy.h [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/ppapi/thunk/ppb_pdf_api.h [modify] https://crrev.com/f50e9f3557742f92ff33521a24988578ba8fa88f/ppapi/thunk/ppb_pdf_thunk.cc
Comment 1 by yukishiino@chromium.org
, Jul 25 2017