Issue metadata
Sign in to add a comment
|
Regression: Unable to see content(text) after expanding 'Allows users to paste into password fields' option of Audit
Reported by
sans...@etouch.net,
Jul 25 2017
|
||||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3166.0 (Official Build)dd5214f6efc02a459d85f09cb9d09383083ea27d-refs/heads/master@{#489161}-32/64 bit OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3) Steps: 1. Launch Chrome, open devtools on NTP and go to Audit section 2. Perform audit and click on '11 passed audits' under 'Best practices' 3. Now click on last option i.e 'Allows users to paste into password fields' and observe Actual: Unable to see any content(text) after expanding 'Allows users to paste into password fields' option Expected: Content(text) should be visible after expanding 'Allows users to paste into password fields' option This is regression issue broken in M-62, will soon update the bisect info. Good build: 62.0.3165.0 Bad build: 62.0.3166.0
,
Jul 25 2017
Adding Release Block-Stable for this issue.Please remove if not the case. Thank You!
,
Jul 26 2017
,
Aug 2 2017
I think root cause is different, but thank you. Fix is merged upstream in Lighthouse (https://github.com/GoogleChrome/lighthouse/pull/2737) but i'll have to roll to get the fix in devtools
,
Aug 21 2017
Your bug is tagged as Release block Stable. M62 is branching soon and We will be taking only CRITICAL merges. Please plan accordingly. sansari@ Is the bug still reproducible?
,
Aug 22 2017
With response to comment #5: Retested this issue on Windows machine using latest Canary chrome version 62.0.3193.0 (Official Build). It's still reproducible. Attaching screen-cast for the same.
,
Aug 29 2017
This is still reproducible on the latest canary(62.0.3198.0) of Windows-10. paulirish@: Can we get an update on this.
,
Sep 6 2017
Ping for an update.
,
Sep 14 2017
paulirish@ Since this issue is marked as RB-Stable, could you please let us know is there any latest update available on this issue? Thanks!
,
Sep 21 2017
This issue is still able to reproduce on chrome latest dev #63.0.3221.0 by following steps mentioned in the original comment. paulirish@ Oing! Since this issue is marked as RB-Stable, could you please let us know is there any latest update available on this issue? Thanks!
,
Sep 26 2017
paulirish@ Gentle Ping! since this issue is blocking M62 stable release, could you please let us know is there any latest update available on this issue? Thanks!
,
Sep 29 2017
Removing RBS. This isn't serious enough an issue. I will be fixing it though!
,
Sep 29 2017
Discussed further with team. Restoring RBS. CL is in flight. Will be landing soon.
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34bc4394ddaf5429b2ff88af7fd9371dc5689060 commit 34bc4394ddaf5429b2ff88af7fd9371dc5689060 Author: Paul Irish <paulirish@chromium.org> Date: Fri Sep 29 20:38:56 2017 DevTools: [Audits] Provide description for password paste audit. Bug: 748381 Change-Id: I2d14123d2627cdfc1355ef5787c650a17cb82ecb Reviewed-on: https://chromium-review.googlesource.com/692625 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Patrick Hulce <phulce@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#505453} [modify] https://crrev.com/34bc4394ddaf5429b2ff88af7fd9371dc5689060/third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css [modify] https://crrev.com/34bc4394ddaf5429b2ff88af7fd9371dc5689060/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/report-styles.css [modify] https://crrev.com/34bc4394ddaf5429b2ff88af7fd9371dc5689060/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js
,
Sep 29 2017
,
Sep 30 2017
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2 2017
Thanks paulirish@! can you please confirm if you've tested this in Canary yet? My guess is that today's Canary has the fix. Can you confirm how safe this merge is, since we're only 2 weeks away from M62 stable.
,
Oct 3 2017
Retested above issue on latest Chrome Dev #63.0.3230.0 on Windows(7,8,10),Mac(10.6) & Linux OS and issue seems to be fixed.Kindly review an attached screen cast.
,
Oct 3 2017
abdulsyed@ yes I've tested the fix on canary as well. It's good. This fix is very safe and good to merge.
,
Oct 3 2017
Thanks - approving merge to M62 (branch:3202)
,
Oct 5 2017
paulirish@, The Merge-Request for M62 has been approved. Can you please merge the above change to M62 branch? Thank you!
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36ba144cefbe8816f5e1b12ff1daeea461f5a687 commit 36ba144cefbe8816f5e1b12ff1daeea461f5a687 Author: Paul Irish <paulirish@chromium.org> Date: Fri Oct 06 00:21:54 2017 DevTools: [Audits] Provide description for password paste audit. TBR=paulirish@chromium.org (cherry picked from commit 34bc4394ddaf5429b2ff88af7fd9371dc5689060) Bug: 748381 Change-Id: I2d14123d2627cdfc1355ef5787c650a17cb82ecb Reviewed-on: https://chromium-review.googlesource.com/692625 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Patrick Hulce <phulce@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#505453} Reviewed-on: https://chromium-review.googlesource.com/703885 Reviewed-by: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#603} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/36ba144cefbe8816f5e1b12ff1daeea461f5a687/third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css [modify] https://crrev.com/36ba144cefbe8816f5e1b12ff1daeea461f5a687/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/report-styles.css [modify] https://crrev.com/36ba144cefbe8816f5e1b12ff1daeea461f5a687/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js
,
Oct 6 2017
,
Oct 11 2017
Note: Retested above issue on latest Chrome Beta #62.0.3202.52 on Windows(7,8,10),Mac(10.12.6) & Linux(14.04 LTS) OS and issue seems to be fixed.Kindly review an attached screen cast. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sans...@etouch.net
, Jul 25 2017Owner: paulir...@chromium.org
Status: Assigned (was: Unconfirmed)