New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748381 link

Starred by 3 users

Issue metadata

Status: Fixed
Merged: issue 748377
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to see content(text) after expanding 'Allows users to paste into password fields' option of Audit

Reported by sans...@etouch.net, Jul 25 2017

Issue description

Chrome Version: 62.0.3166.0 (Official Build)dd5214f6efc02a459d85f09cb9d09383083ea27d-refs/heads/master@{#489161}-32/64 bit
OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3)

Steps:
1. Launch Chrome, open devtools on NTP and go to Audit section
2. Perform audit and click on '11 passed audits' under 'Best practices'
3. Now click on last option i.e 'Allows users to paste into password fields' and observe

Actual: Unable to see any content(text) after expanding 'Allows users to paste into password fields' option

Expected: Content(text) should be visible after expanding 'Allows users to paste into password fields' option

This is regression issue broken in M-62, will soon update the bisect info.

Good build: 62.0.3165.0
Bad build: 62.0.3166.0
 
Actual_video.mp4
1.3 MB View Download
Expected_video.mp4
429 KB View Download

Comment 1 by sans...@etouch.net, Jul 25 2017

Labels: hasbisect
Owner: paulir...@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/4a7bb7aca272eecc62437c28c0921925c04af03f..5604f31a3f0ccb7feefe70eb517e70189e2ede69?pretty=fuller&n=100

Suspecting: r489099 ?

Please help to re-assign if your change is not the cause for this issue.
Labels: ReleaseBlock-Stable
Adding Release Block-Stable for this issue.Please remove if not the case.

Thank You!
Mergedinto: 748377
Status: Duplicate (was: Assigned)
Root cause is the same , duping
Status: Assigned (was: Duplicate)
I think root cause is different, but thank you.

Fix is merged upstream in Lighthouse (https://github.com/GoogleChrome/lighthouse/pull/2737) but i'll have to roll to get the fix in devtools
Your bug is tagged as Release block Stable. 

M62 is branching soon and We will be taking only CRITICAL merges. Please plan accordingly.

sansari@ Is the bug still reproducible?
With response to comment #5: Retested this issue on Windows machine using latest Canary chrome version 62.0.3193.0 (Official Build). It's still reproducible.

Attaching screen-cast for the same.
Latest_Canary_Behaviour.mp4
2.0 MB View Download

Comment 7 by ajha@chromium.org, Aug 29 2017

Cc: pfeldman@chromium.org
This is still reproducible on the latest canary(62.0.3198.0) of Windows-10.

paulirish@: Can we get an update on this.


Comment 8 by ajha@chromium.org, Sep 6 2017

Ping for an update.
paulirish@ Since this issue is marked as RB-Stable, could you please let us know is there any latest update available on this issue?

Thanks!
This issue is still able to reproduce on chrome latest dev #63.0.3221.0 by following steps mentioned in the original comment.

paulirish@ Oing! Since this issue is marked as RB-Stable, could you please let us know is there any latest update available on this issue?

Thanks!
paulirish@ Gentle Ping! since this issue is blocking M62 stable release, could you please let us know is there any latest update available on this issue?

Thanks!
Labels: -ReleaseBlock-Stable
Removing RBS. This isn't serious enough an issue.  I will be fixing it though!
Labels: ReleaseBlock-Stable
Status: Started (was: Assigned)
Discussed further with team. Restoring RBS. 

CL is in flight. Will be landing soon.
Labels: Merge-Request-62
Project Member

Comment 16 by sheriffbot@chromium.org, Sep 30 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thanks paulirish@! can you please confirm if you've tested this in Canary yet? My guess is that today's Canary has the fix. Can you confirm how safe this merge is, since we're only 2 weeks away from M62 stable.

Comment 18 by vku...@etouch.net, Oct 3 2017

Labels: TE-Verified-63.0.3230.0 TE-Verified-M63
Retested above issue on latest Chrome Dev #63.0.3230.0 on Windows(7,8,10),Mac(10.6) & Linux OS and issue seems to be fixed.Kindly review an attached screen cast. 
Actual_Audit.mp4
1.3 MB View Download
abdulsyed@ yes I've tested the fix on canary as well. It's good.

This fix is very safe and good to merge. 
Labels: -Merge-Review-62 Merge-Approved-62
Thanks - approving merge to M62 (branch:3202)
paulirish@, The Merge-Request for M62 has been approved. Can you please merge the above change to M62 branch?

Thank you!
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 6 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36ba144cefbe8816f5e1b12ff1daeea461f5a687

commit 36ba144cefbe8816f5e1b12ff1daeea461f5a687
Author: Paul Irish <paulirish@chromium.org>
Date: Fri Oct 06 00:21:54 2017

DevTools: [Audits] Provide description for password paste audit.

TBR=paulirish@chromium.org

(cherry picked from commit 34bc4394ddaf5429b2ff88af7fd9371dc5689060)

Bug:  748381 
Change-Id: I2d14123d2627cdfc1355ef5787c650a17cb82ecb
Reviewed-on: https://chromium-review.googlesource.com/692625
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Patrick Hulce <phulce@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#505453}
Reviewed-on: https://chromium-review.googlesource.com/703885
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#603}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/36ba144cefbe8816f5e1b12ff1daeea461f5a687/third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css
[modify] https://crrev.com/36ba144cefbe8816f5e1b12ff1daeea461f5a687/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/report-styles.css
[modify] https://crrev.com/36ba144cefbe8816f5e1b12ff1daeea461f5a687/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js

Status: Fixed (was: Started)
Labels: TE-Verified-M62 TE-Verified-62.0.3202.52
Note: Retested above issue on latest Chrome Beta #62.0.3202.52 on Windows(7,8,10),Mac(10.12.6) & Linux(14.04 LTS) OS and issue seems to be fixed.Kindly review an attached screen cast. 
Actual_Audit.mp4
1.2 MB View Download

Sign in to add a comment