Wrong position of app list if swiping up on shelf when shelf is auto-hidden with non-visible window |
||||||||||
Issue descriptionRepro: 1) Change to tablet mode. 2) Set shelf to auto-hide and navigate to desktop with non-visible windows. 3) Swiping up on the shelf. Should: Open the app list based on the dragging position. What it is: App list appears suddenly, and didn't update position based on the dragging position.
,
Jul 25 2017
,
Jul 25 2017
I have one question here. What it should be if swiping up on the shelf when the shelf is auto-hidden? Should it show the fullscreen app list or just keep the currently behavior of shelf?
,
Jul 25 2017
Through email thread, the behavior should be consistent whatever the mode, i.e.: If the shelf is not fully visible, the first swipe should bring up the shelf If the shelf is fully visible, regardless of mode, swiping up should open the launcher.
,
Jul 26 2017
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fe906a156c86925ced9e5d9af235f1329ce3364 commit 6fe906a156c86925ced9e5d9af235f1329ce3364 Author: MinChen <minch@chromium.org> Date: Fri Jul 28 18:05:00 2017 Open app list if swiping up on auto-hidden shelf when there is no visible window. Changes: 1) Converts the event location to screen if swiping on auto-hidden shelf with no visible window. 2) The gesture events that triggered on status area of auto-hidden shelf should open associated tray bubbles. Bug: 748379 Change-Id: I002f77b1cca0d95148e683786d7f876db2edf9e3 Reviewed-on: https://chromium-review.googlesource.com/585580 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#490460} [modify] https://crrev.com/6fe906a156c86925ced9e5d9af235f1329ce3364/ash/shelf/shelf.cc [modify] https://crrev.com/6fe906a156c86925ced9e5d9af235f1329ce3364/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/6fe906a156c86925ced9e5d9af235f1329ce3364/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/6fe906a156c86925ced9e5d9af235f1329ce3364/ash/shelf/shelf_layout_manager_unittest.cc
,
Jul 28 2017
launcher for m61.
,
Jul 29 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da8f181cda5a894fab6f5bb904136f582f42512e commit da8f181cda5a894fab6f5bb904136f582f42512e Author: Maajid <maajid@chromium.org> Date: Mon Jul 31 22:20:16 2017 Open app list if swiping up on auto-hidden shelf when there is no visible window. Changes: 1) Converts the event location to screen if swiping on auto-hidden shelf with no visible window. 2) The gesture events that triggered on status area of auto-hidden shelf should open associated tray bubbles. TBR=minch@chromium.org (cherry picked from commit 6fe906a156c86925ced9e5d9af235f1329ce3364) Bug: 748379 Change-Id: I002f77b1cca0d95148e683786d7f876db2edf9e3 Reviewed-on: https://chromium-review.googlesource.com/585580 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490460} Reviewed-on: https://chromium-review.googlesource.com/594684 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#192} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/da8f181cda5a894fab6f5bb904136f582f42512e/ash/shelf/shelf.cc [modify] https://crrev.com/da8f181cda5a894fab6f5bb904136f582f42512e/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/da8f181cda5a894fab6f5bb904136f582f42512e/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/da8f181cda5a894fab6f5bb904136f582f42512e/ash/shelf/shelf_layout_manager_unittest.cc
,
Aug 1 2017
,
Jan 22 2018
,
Sep 13
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by minch@chromium.org
, Jul 25 2017Labels: M-61