New issue
Advanced search Search tips

Issue 748372 link

Starred by 1 user
Status: WontFix
Owner:
dcheng@chromium.org
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

git cl owners fails to parse the OWNERS files

Project Member Reported by borisv@chromium.org, Jul 25 2017 
git version 2.13.0.rc1.294.g07d810a77f-goog

What steps will reproduce the problem?
(1) Enlist Chromium
(2) Sync up to any of the last 2 patches from https://chromium-review.googlesource.com/c/580543/
(3) from the src folder run: git cl owners components/nacl/loader/nacl_helper_linux.cc

What is the expected result?
To list the owners.

What happens instead?
fatal: Needed a single revision
Command "git rev-parse --verify components/nacl/loader/nacl_helper_linux.cc" failed.

Comment 1 by dcheng@chromium.org, Jul 25 2017 

Has this worked in the past? I wasn't aware that you could run git cl owners for just one file.

Comment 2 by borisv@chromium.org, Jul 25 2017 

I am not sure, but is needed. The problem is that there are special rules in the OWNERS that assign different files to different OWNERS.

Comment 3 by dcheng@chromium.org, Jul 25 2017 

git cl owners should handle per-file rules though.

Comment 4 by dcheng@chromium.org, Aug 19 2017

Status: WontFix (was: Untriaged)
borisv, feel free to reopen if this is something you'd like to see, though it's probably not high priority: AFAIK, this isn't a use case we've supported previously.
►

Sign in to add a comment