Issue metadata
Sign in to add a comment
|
Chrome Home accessibility when pull handle is showing |
||||||||||||||||||||||||
Issue descriptionIn the swipe case, we should tweak the language for accessibility strings to tell users they have to use two fingers to swipe. >> Comment from Laura: One thing I'm realizing when using talkback is that it might be helpful to slightly tweak the verbalization from "address bar, pull up to see bookmarks, downloads, and history" to "address bar, pull up with two fingers to see bookmarks, downloads, and history". You need to use 2 fingers when Talkback is on, so if someone hears the verbalization as is, it might be a bit confusing (even though they should technically know that swiping or scrolling is done with 2 fingers, not one, with Talkback on). Also, the only other usability glitch I'm reaching is that when I use touch exploration to find the bottom bar, the largest touch target is the URL itself so I press that and focus on that and hear the URL (which is fine). I have to swipe backwards twice to hear "address bar, pull up to see...". This is okay, but I'm thinking that it might be helpful to also append that spoken label "pull up with 2 fingers to see..." after the URL is read aloud, in case that becomes a heavily used pattern (users using touch exploration to focus that bar and hitting the URL, therefore not hearing the verbalization that they can pull up to see much more.
,
Aug 7 2017
,
Aug 10 2017
Adding RBS label, since we need this for M62 as per https://bugs.chromium.org/p/chromium/issues/detail?id=682518#c9. Can we get an owner?
,
Aug 10 2017
Gave it a 1.5 priority on our bug triage sheet to ensure it gets down for M62.
,
Aug 10 2017
,
Aug 14 2017
,
Aug 22 2017
,
Aug 29 2017
We have an in-flight CL to change the text to include "two fingers" that we will get in for M62. For the URL bar text, this is a bit more complicated in that we don't currently have custom code to set the URL bar's content description. Since the URL bar is an EditText view, Android reads the current text then "Edit box", e.g. "h-t-t-p-s-colon-slash-slash-w-w-w-dot-google-dot-com. Double tap to enter text." A somewhat simple approach is to set a custom content description on the UrlBar, but Android will read "h-t-t-p-s-colon-slash-slash-w-w-w-dot-google-dot-com. Pull up to see ... Edit box. Double tap to enter text." I think having "Pull up to see..." and "Double tap to enter.." separated by "Edit box" is a bit odd. We can investigate alternative approaches in M63 (our new stable launch target) but we may not gain a lot of traction. We do have a new menu header to help teach users where bookmarks, history and downloads went that will serve as a permanent item for several milestones (see screenshot). Laura, does this mitigate some of your concern about the discoverability of the user gesture to open the bottom sheet?
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51337140b5ae6cbb9619397df067aa5ca30ae289 commit 51337140b5ae6cbb9619397df067aa5ca30ae289 Author: danielpark@chromium.org <danielpark@chromium.org> Date: Wed Sep 06 00:05:54 2017 [Home] Update toolbar accessibility string > Changes from "pull up/down..." to "pull up/down with two fingers..." Bug: 748357 Change-Id: I16a5c61ae247b3c1188f1d8d05367364483b8e41 Reviewed-on: https://chromium-review.googlesource.com/641864 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#499808} [modify] https://crrev.com/51337140b5ae6cbb9619397df067aa5ca30ae289/chrome/android/java/strings/android_chrome_strings.grd
,
Sep 7 2017
+ktam@ to comment on #8 Since M63 is our new stable launch target, I don't think this needs to block the 62 release
,
Sep 11 2017
I'm good with that but I've sent Laura a separate email so she can update her thoughts.
,
Sep 11 2017
Laura adds that saying "two fingers to pull" may not be recommended by accessibility team because of different gestures. They recommended a custom actions. Also - OK for this to be launch blocking for full launch but not experiment.
,
Sep 20 2017
Taking this back while we workout an appropriate strategy with the accessibility team.
,
Sep 21 2017
Pushing accessibility + pull handle out to 64 based on our meeting today. For M63 we will show the expand button when accessibility is enabled. We will explore other options (e.g. pull handle + button) for 64.
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37f9056c80065ddc5efc6f4346deb3fd4907cb7a commit 37f9056c80065ddc5efc6f4346deb3fd4907cb7a Author: Matthew Jones <mdjones@chromium.org> Date: Wed Oct 11 23:25:28 2017 [Home] Remove expand button experiment This change removes the Chrome Home expand button experiment. The expand button will still exist, but only as an option for accessibility users. BUG= 748357 Change-Id: If4a667e4b95c33ec1443ac547666cfcc947157b4 Reviewed-on: https://chromium-review.googlesource.com/704000 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#508169} [modify] https://crrev.com/37f9056c80065ddc5efc6f4346deb3fd4907cb7a/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/37f9056c80065ddc5efc6f4346deb3fd4907cb7a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/37f9056c80065ddc5efc6f4346deb3fd4907cb7a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java [modify] https://crrev.com/37f9056c80065ddc5efc6f4346deb3fd4907cb7a/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java [modify] https://crrev.com/37f9056c80065ddc5efc6f4346deb3fd4907cb7a/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java [modify] https://crrev.com/37f9056c80065ddc5efc6f4346deb3fd4907cb7a/chrome/browser/about_flags.cc [modify] https://crrev.com/37f9056c80065ddc5efc6f4346deb3fd4907cb7a/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/37f9056c80065ddc5efc6f4346deb3fd4907cb7a/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/37f9056c80065ddc5efc6f4346deb3fd4907cb7a/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/37f9056c80065ddc5efc6f4346deb3fd4907cb7a/chrome/browser/flag_descriptions.h
,
Oct 13 2017
After the change in #16, when accessibility is enabled we show the pull handle and the expand button (thanks Matt!). I think we still need to add a content description to the toolbar, then we can close this out.
,
Dec 11 2017
This is the CL that removed the content description for reference: https://chromium.googlesource.com/chromium/src/+/62397c64aabecd07c7e161bf7be99f2f692a945c%5E%21/#F2
,
Dec 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c6b36e0fe41c0b1376d716bdc3d6120d7b37666 commit 6c6b36e0fe41c0b1376d716bdc3d6120d7b37666 Author: Theresa Wellington <twellington@google.com> Date: Tue Dec 12 21:46:16 2017 [Home] Add accessibility description to toolbar When the sheet is closed, add an accessibility description to the toolbar so that it provides useful information when focused during swipe-explore. BUG= 748357 Change-Id: Ie7fb7221b75e86fb19423455cfe8c3449201dc67 Reviewed-on: https://chromium-review.googlesource.com/820593 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#523563} [modify] https://crrev.com/6c6b36e0fe41c0b1376d716bdc3d6120d7b37666/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java [modify] https://crrev.com/6c6b36e0fe41c0b1376d716bdc3d6120d7b37666/chrome/android/java/strings/android_chrome_strings.grd
,
Dec 12 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by krav...@chromium.org
, Jul 27 2017