Update remaining LaunchProcess call-sites that use FileHandleMappingVector for Fuchsia. |
||
Issue descriptionWe still have LaunchProcess call-sites, e.g. in test process utils, which reply on the FileHandleMappingVector structure being present in the options structure - the Fuchsia implementation of LaunchProcess ignores the structure, and the tests which actually use it are filtered-out on Fuchsia. Once the call-sites are updated, we can have FileHandleMappingVector only be defined on non-Fuchsia POSIX platforms.
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50ccafde647905f95176e03d938fdbce4292d694 commit 50ccafde647905f95176e03d938fdbce4292d694 Author: Wez <wez@chromium.org> Date: Tue Jul 25 04:11:31 2017 Leave FileHandleMappingVector defined even in Fuchsia builds. Fuchsia still builds some LaunchProcess() call-sites as POSIX, meaning that they rely on the FileHandleMappingVector type. To un-break the build, define the type under all POSIX platforms, until we have all the call-sites fixed. TBR: brettw@chromium.org Bug: 748350 Change-Id: I624f2eac1381743df64d285a2629bad358468d76 Reviewed-on: https://chromium-review.googlesource.com/583957 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#489226} [modify] https://crrev.com/50ccafde647905f95176e03d938fdbce4292d694/base/process/launch.h
,
Aug 2 2017
Correction: LaunchProcess for Fuchsia does respect FileHandleMappingVector, otherwise the TestLauncher itself wouldn't work, so defining FileHandleMappingVector for all POSIX does make sense after all.
,
Aug 3 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by w...@chromium.org
, Jul 25 2017Status: Assigned (was: Untriaged)