New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 748345 link

Starred by 2 users
Status: Archived
Owner:
calamity@chromium.org
Closed: Jul 2017
Cc:
█ tsergeant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[MD Bookmarks] Drag and drop chip appears before moving mouse on linuxchromeos

Project Member Reported by tsergeant@chromium.org, Jul 25 2017 
Steps to reproduce:

1. Build linuxchromeos
2. Open MD Bookmarks
3. Mousedown and hold on a bookmark item (without moving the mouse)

Expected behavior:

Drag does not start

Actual behavior:

Drag and drop chip appears under the mouse immediately.

Not sure if this reproduces on actual CrOS yet, but I assume it will.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88c59ca126995a7683628143c7d260ba97e44e41

commit 88c59ca126995a7683628143c7d260ba97e44e41
Author: Christopher Lam <calamity@chromium.org>
Date: Fri Jul 28 03:36:47 2017

[MD Bookmarks] Add minimum drag threshold distance.

This CL makes a drag happen after 15px of x or y movement, rather than
on any mousemove after mousedown. This feels more like a native drag, and
makes accidental drag starts less likely.

Bug:  748345 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I060ed5b21ef1417ed68da6d288bb503de9b080e8
Reviewed-on: https://chromium-review.googlesource.com/584209
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490243}
[modify] https://crrev.com/88c59ca126995a7683628143c7d260ba97e44e41/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/88c59ca126995a7683628143c7d260ba97e44e41/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js

Comment 2 by calamity@chromium.org, Jul 28 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment