Issue metadata
Sign in to add a comment
|
Superfish interstitial strings should be split into Chrome/Chromium |
||||||||||||||||||||||
Issue descriptionChrome 61.0.3159.5 macOS 10.12.6 What steps will reproduce the problem? (1) Visit chrome://interstitials/superfish-ssl in a Chromium build What is the expected result? The strings say "Chromium" instead of "Chrome". What happens instead? The string say "Chrome". There are two ways to fix this: 1. Put the string into components_chromium_strings.grd and components_google_chrome_strings.grd 2. Copy what IDS_SSL_NONOVERRIDABLE_MORE does and use `<if expr="_google_chrome">` estark@, could you triage?
,
Jul 25 2017
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/083ff97bea1d32df1281bb09723a74b81817ef08 commit 083ff97bea1d32df1281bb09723a74b81817ef08 Author: Emily Stark <estark@google.com> Date: Fri Jul 28 04:34:50 2017 Fix Superfish Chrome/Chromium string This splits a string for the Superfish interstitial which mentions Chrome into Chrome/Chromium variants. Bug: 748313 Change-Id: I457d4b3ac1f42ba365ce2318912a7ea3ef031c9e Reviewed-on: https://chromium-review.googlesource.com/584825 Reviewed-by: Lucas Garron <lgarron@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#490262} [modify] https://crrev.com/083ff97bea1d32df1281bb09723a74b81817ef08/components/security_interstitials_strings.grdp
,
Jul 28 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by est...@chromium.org
, Jul 25 2017