Alex, I believe you have the best knowledge about it?

This is something we need to discuss. I'll talk to Zach.

+dskaram Looks like we'll need to communicate to 3rd party SAML providers and have them update their UI? Unless the "connecting to GSuite" UI is owned by us, in which case we should fix it.

Adding to OPs bug report, an ADFS IdP page shows this message(ie, SIGN IN) on the top of the Sign in Frame when redirected from a GLIF Sign In page.

Deleted: Screenshot 2017-07-26 at 4.23.18 PM.png 435 KB

	Screenshot 2017-07-26 at 4.23.18 PM.png 435 KB View Download

A few points to consider:

1. IdP pages start *below* the banner that says "This sign-in service is hosted....". We own that banner so any UI showing there is ours and there must be some conflation.

2. SAML flow terminates programmatically. So we should remove the Next button completely.

3. It is not possible for IdPs to change their pages. In many cases these are old servers hosted on-premise e.g. the page in the last screenshot is ADFS 2008. This UI has not been updated for 9 years :)


Please let me know if more info is needed. This seems to be a problem on our side and correctly labeled as RBS. Thanks for catching and fixing!

QQ, where we we tracking changes that need to be made for our offline auth screens? There are screens in the login flow that aren't really sourced out of GAIA but actually look like GAIA. These include auth screen for offline users who have an account on the device and Active Directory screen. As well as password confirmation screen for SAML flow.

> 2. SAML flow terminates programmatically. So we should remove the Next
> button completely.

This page is one of several pages in the flow, so it has "Next" button to match other pages. (Of course, it is always disabled.) But personally, I think it makes the whole design unified.

Offline Gaia is already converted to GLIF.

We won't have GLIF EE flow in 61, so AD enrollment and other screens are in the old design.

alemate@ can you update the banner UI and remove the next button?

Re #11:

What do you mean? The SAML page itself looks like this:
https://screenshot.googleplex.com/4oKoboisGJx.png

We are adding security-flavored message "This sign in service is hosted by <domain>".

Here is the old (pre-GLIF MM) viwe of the same page: https://screenshot.googleplex.com/z30pDd9VwEr.png

We can move the webview start 44 pixels down to match the previous "vertical" behavior. https://screenshot.googleplex.com/wJDRO7OKxm7.png

Or we can move the overlay "This sign in service is hosted by <domain>" between "<- Back" and "Next ->" buttons. (This also implies that we should not remove "next ->" button ).

And it will look like this: https://screenshot.googleplex.com/WE2toK1hFJR.png

Let's do the option in #14

The old UI looks like this: https://screenshot.googleplex.com/eKgcanOKMLa.png
I.e. total height 528px = 44px (overlay) + 484px(webview)

New UI height is 640px = 80px buttons + 560 (webview + overlay).

If overlay will use 44px, webview height is going to be 516px.
Here is the new look:
https://screenshot.googleplex.com/BpwYkPkPJqb.png

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f03defcd8b3320f32f0a639bbb21ec2b9b614b8f

commit f03defcd8b3320f32f0a639bbb21ec2b9b614b8f
Author: Alexander Alekseev <alemate@chromium.org>
Date: Tue Aug 08 06:06:43 2017

ChromeOS: Adjust Gaia webview size.

The webview doesn't scale correctly, so we need to set is height to a fixed
size.

Bug:  748312 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibf05346dfdbae070663a7f131f38bfbacce6a7ae
Reviewed-on: https://chromium-review.googlesource.com/605057
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492549}
[modify] https://crrev.com/f03defcd8b3320f32f0a639bbb21ec2b9b614b8f/chrome/browser/resources/chromeos/login/screen_gaia_signin.css
[modify] https://crrev.com/f03defcd8b3320f32f0a639bbb21ec2b9b614b8f/chrome/browser/resources/chromeos/login/screen_gaia_signin.js

This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge to M61 Chrome OS.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68182a606e4f95da907705b84a23d1e62450ff75

commit 68182a606e4f95da907705b84a23d1e62450ff75
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 09 23:12:48 2017

ChromeOS: Adjust Gaia webview size.

The webview doesn't scale correctly, so we need to set is height to a fixed
size.

TBR=alemate@chromium.org

(cherry picked from commit f03defcd8b3320f32f0a639bbb21ec2b9b614b8f)

Bug:  748312 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibf05346dfdbae070663a7f131f38bfbacce6a7ae
Reviewed-on: https://chromium-review.googlesource.com/605057
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492549}
Reviewed-on: https://chromium-review.googlesource.com/609444
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#413}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/68182a606e4f95da907705b84a23d1e62450ff75/chrome/browser/resources/chromeos/login/screen_gaia_signin.css
[modify] https://crrev.com/68182a606e4f95da907705b84a23d1e62450ff75/chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Verified the layout issue is not reproduced in M61.0.3163.41:9765.23.0 dev caroline.