New issue
Advanced search Search tips

Issue 748311 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] Add support to resize host to fit

Project Member Reported by yuweih@chromium.org, Jul 25 2017

Issue description

This can provide better experience on devices with larger screens like iPad, and get rid of the black edges caused by unmatched aspect ratio.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee9424dae7060e3980973915e49d80f7fa0c632c

commit ee9424dae7060e3980973915e49d80f7fa0c632c
Author: Yuwei Huang <yuweih@chromium.org>
Date: Tue Jul 25 21:18:47 2017

[CRD iOS] Add support to resize host to fit

This feature helps improve experience of devices with larger screen like
iPad.

This CL adds the whole pipeline for sending client resolutions and hooks
up the toggle in RemotingSettingsVC.

Bug:  748311 
Change-Id: I3b297d3575ce307475110366d28693ae1df519f4
Reviewed-on: https://chromium-review.googlesource.com/584147
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489436}
[modify] https://crrev.com/ee9424dae7060e3980973915e49d80f7fa0c632c/remoting/client/chromoting_session.cc
[modify] https://crrev.com/ee9424dae7060e3980973915e49d80f7fa0c632c/remoting/client/chromoting_session.h
[modify] https://crrev.com/ee9424dae7060e3980973915e49d80f7fa0c632c/remoting/ios/app/host_view_controller.mm
[modify] https://crrev.com/ee9424dae7060e3980973915e49d80f7fa0c632c/remoting/ios/app/settings/remoting_settings_view_controller.h
[modify] https://crrev.com/ee9424dae7060e3980973915e49d80f7fa0c632c/remoting/ios/app/settings/remoting_settings_view_controller.mm
[modify] https://crrev.com/ee9424dae7060e3980973915e49d80f7fa0c632c/remoting/ios/domain/host_settings.h
[modify] https://crrev.com/ee9424dae7060e3980973915e49d80f7fa0c632c/remoting/ios/domain/host_settings.mm
[modify] https://crrev.com/ee9424dae7060e3980973915e49d80f7fa0c632c/remoting/ios/session/remoting_client.h
[modify] https://crrev.com/ee9424dae7060e3980973915e49d80f7fa0c632c/remoting/ios/session/remoting_client.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00a2880b989c7dd6bcdaba5d34ac1ebf7975d0de

commit 00a2880b989c7dd6bcdaba5d34ac1ebf7975d0de
Author: Yuwei Huang <yuweih@chromium.org>
Date: Mon Jul 31 23:01:25 2017

[CRD iOS] Finish up resize-host-to-fit

This CL improves the resize-host-to-fit logic after getting feedback from
the team.

Changes include:
* Scaling up the client resolution with an integer multiplier if any
  dimension is smaller than 640.
* Disabling the feature if the user is using a phone in portrait mode or
  the keyboard is being shown.

Bug:  748311 
Change-Id: I4a8b4f9a343a1f9c8370b2801757aa2f5f7aec97
Reviewed-on: https://chromium-review.googlesource.com/595108
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490813}
[modify] https://crrev.com/00a2880b989c7dd6bcdaba5d34ac1ebf7975d0de/remoting/client/chromoting_session.cc
[modify] https://crrev.com/00a2880b989c7dd6bcdaba5d34ac1ebf7975d0de/remoting/ios/app/host_view_controller.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified fixed in 63.0.3220.0

Sign in to add a comment