Single shard failures w/ no test results can result in passing builds |
||
Issue descriptionAndroid tests running w/ single shards can emit JSONs containing no failures if they fail to list tests. The containing step will fail, but the recipe will not detect overall failures, and the build will succeed. e.g. https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/342809 It's not clear if this has resulted in a bad change landing yet, but it undoubtedly will.
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d74d7267de5e2fde987ab625fb0719be44baf6be commit d74d7267de5e2fde987ab625fb0719be44baf6be Author: John Budorick <jbudorick@chromium.org> Date: Tue Jul 25 14:35:38 2017 [android] Add UNRELIABLE_RESULTS tag when exiting with an exception. Bug: 748300 Change-Id: I983ce742bbc11ad410eb207636a433957d920286 Reviewed-on: https://chromium-review.googlesource.com/584020 Reviewed-by: Michael Case <mikecase@chromium.org> Reviewed-by: Yoland Yan <yolandyan@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#489289} [modify] https://crrev.com/d74d7267de5e2fde987ab625fb0719be44baf6be/build/android/pylib/results/json_results.py [modify] https://crrev.com/d74d7267de5e2fde987ab625fb0719be44baf6be/build/android/pylib/results/json_results_test.py [modify] https://crrev.com/d74d7267de5e2fde987ab625fb0719be44baf6be/build/android/test_runner.py
,
Jul 27 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by jbudorick@chromium.org
, Jul 25 2017