New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748286 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 724708



Sign in to add a comment

EasyUnlock v2: Hook up notifications to be shown on sync

Project Member Reported by tengs@chromium.org, Jul 24 2017

Issue description

The notifications were implemented in issue 726791. Now, they need to be hooked up to be shown.
 

Comment 1 by tengs@chromium.org, Jul 25 2017

Cc: sacomoto@chromium.org omrilio@chromium.org
Labels: Merge-Request-61

Comment 2 by tengs@chromium.org, Jul 25 2017

Labels: -Merge-Request-61
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e538c57db8acf0348dd08bcb4ab2bd0ffa873cb1

commit e538c57db8acf0348dd08bcb4ab2bd0ffa873cb1
Author: Tim Song <tengs@chromium.org>
Date: Tue Jul 25 05:12:45 2017

[EasyUnlock] Hook up Chromebook added and pairing changed notifications.

BUG= 748286 

Change-Id: I1a94a2a760abfd778d471561388ded211fb0bd08
Reviewed-on: https://chromium-review.googlesource.com/580525
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489237}
[modify] https://crrev.com/e538c57db8acf0348dd08bcb4ab2bd0ffa873cb1/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/e538c57db8acf0348dd08bcb4ab2bd0ffa873cb1/chrome/browser/signin/easy_unlock_service_regular.h
[modify] https://crrev.com/e538c57db8acf0348dd08bcb4ab2bd0ffa873cb1/chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc

Comment 4 by tengs@chromium.org, Jul 25 2017

Labels: Merge-Request-61
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61.
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 31 2017

Cc: keta...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 4 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 7 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa989a67c9787e5c7787308b6e041b03b0669033

commit fa989a67c9787e5c7787308b6e041b03b0669033
Author: Tim Song <tengs@chromium.org>
Date: Mon Aug 07 17:06:50 2017

[EasyUnlock] Hook up Chromebook added and pairing changed notifications.

BUG= 748286 
TBR=tengs@chromium.org

(cherry picked from commit e538c57db8acf0348dd08bcb4ab2bd0ffa873cb1)

Change-Id: I1a94a2a760abfd778d471561388ded211fb0bd08
Reviewed-on: https://chromium-review.googlesource.com/580525
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489237}
Reviewed-on: https://chromium-review.googlesource.com/604090
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#349}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/fa989a67c9787e5c7787308b6e041b03b0669033/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/fa989a67c9787e5c7787308b6e041b03b0669033/chrome/browser/signin/easy_unlock_service_regular.h
[modify] https://crrev.com/fa989a67c9787e5c7787308b6e041b03b0669033/chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc

Comment 9 by tengs@chromium.org, Aug 7 2017

Status: Fixed (was: Assigned)

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment