Chrome crashes on Back button from exiting VR prompt |
|||||
Issue descriptionChrome Version: 61.0.3163.0 OS: Android What steps will reproduce the problem? (1) Visit a page with unsupported VR features (like the "long extended subdomain" link from badssl.com) (2) Wait for the "Exiting..." prompt to disappear and for the prompt to remove the phone from the headset. (3) Click the Back arrow on that prompt. What is the expected result? No crash What happens instead? Chrome crashes. An example report is at https://crash.corp.google.com/browse?stbtiq=45513ca268000000, though it doesn't look very useful.
,
Jul 25 2017
According to ymalik, the issue is that we disable ourselves before the DOFF flow has completed. We can postpone disabling until after that flow.
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f71b90f3e2816bd84bd35bf02d918995c99ddad2 commit f71b90f3e2816bd84bd35bf02d918995c99ddad2 Author: Biao She <bshe@chromium.org> Date: Tue Jul 25 22:22:06 2017 Fix crash when back button is pressed at Doff Bug: 748272 Change-Id: I25d416132dfc9dccca2205bbe485291933eaeb2f Reviewed-on: https://chromium-review.googlesource.com/585590 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#489462} [modify] https://crrev.com/f71b90f3e2816bd84bd35bf02d918995c99ddad2/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Jul 27 2017
,
Jul 28 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9b6719d1e670e5485f0b793eafcddd660543937 commit c9b6719d1e670e5485f0b793eafcddd660543937 Author: Biao She <bshe@chromium.org> Date: Fri Jul 28 18:27:23 2017 Fix crash when back button is pressed at Doff TBR=bshe@chromium.org (cherry picked from commit f71b90f3e2816bd84bd35bf02d918995c99ddad2) Bug: 748272 Change-Id: I25d416132dfc9dccca2205bbe485291933eaeb2f Reviewed-on: https://chromium-review.googlesource.com/585590 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by: Yash Malik <ymalik@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489462} Reviewed-on: https://chromium-review.googlesource.com/591636 Reviewed-by: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#105} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/c9b6719d1e670e5485f0b793eafcddd660543937/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Jul 28 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vollick@chromium.org
, Jul 25 2017Owner: bshe@chromium.org
Status: Assigned (was: Untriaged)