New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748267 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Audio plays from onboard speakers though USB headphones selected

Project Member Reported by pgangishetty@chromium.org, Jul 24 2017

Issue description

Chrome Version: 62.0.3165.0
OS: ChromeOS 9774.0.0

What steps will reproduce the problem?
(1) Sign in to the device
(2) Play any YouTube video/audio (Audio is heard from Onboard speakers)
(3) Plug in USB headphones

What is the expected result?
Audio is heard from USB headphones

What happens instead?
Audio is heard from Onboard speakers.

Note: "Uber tray" and "cras_test_client --dump_server_info" both shows as USB is selected

Please use labels and text to provide additional information.
Logs and screenshot attached.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Owner: cychiang@chromium.org
Status: Assigned (was: Untriaged)
Summary: auron_paine: Audio plays from onboard speakers though USB headphones selected (was: Audio plays from onboard speakers though USB headphones plugged in)
Status: Started (was: Assigned)
I can reproduce this on 9774.0 image.

However, using sox or cras_test_client is fine.

When I play sox and youtube at the same time, and plug in usb headset, sox sound goes to usb headset, and youtube goes to speaker.
It looks as if Chrome is using pinned stream.
Cc: chinyue@chromium.org
Chinyue thinks it might be chrome's change related to hotwording.
We need to check the related changes in Chrome.
Owner: hychao@chromium.org
Cc: conradlo@chromium.org

Comment 9 by hychao@chromium.org, Jul 25 2017

Cc: maxmorin@chromium.org jen...@chromium.org
Recent Chrome change makes all output streams to pinned streams, that means opening a YouTube will play to the latest active device and never change according to UI selection.

This CL looks suspicious https://chromium-review.googlesource.com/c/538754


Cc: -maxmorin@chromium.org solenberg@chromium.org hychao@chromium.org
Owner: maxmorin@chromium.org
Here's the diff for when the bug happens: https://chromium.googlesource.com/chromium/src/+log/61.0.3160.0..61.0.3162.0?pretty=fuller&n=10000

I am guessing that somehow AudioManagerCras::MakeOutputStream() receives a non-empty device_id to cause stream get pinned to certain device forever.

Max: can you help take a look?

cc'ing solenberg@ since issue tracker shows maxmorin@ is OOO.

Cc: maxmorin@chromium.org warx@chromium.org
Owner: guidou@chromium.org
Routing to Guido, who's back Monday 7/31.

Q: Are all CLs for https://bugs.chromium.org/p/chromium/issues/detail?id=636300 included in the CrOS M62 build?

I don't think we can afford to wait till Monday. This affects every single device on canary and eventually dev channel.

Which version of Chrome has all the CLs from https://bugs.chromium.org/p/chromium/issues/detail?id=636300 ?
Chrome version 62.0.3164.0 has all the CLs from issue 636300, and that translates to CrOS version 9768.0.0
Original report of this issue was on a version later than that.
If it can't wait I suggest speculatively reverting https://chromium-review.googlesource.com/c/538754/ to see if that solves the problem.
Labels: -ReleaseBlock-Beta ReleaseBlock-Dev M-61
Summary: Audio plays from onboard speakers though USB headphones selected (was: auron_paine: Audio plays from onboard speakers though USB headphones selected)
Reproducible with version 9765.5.0, 61.0.3163.11
 
1. Kevin & Peppy - same issue observed 
2. Squawks - No sound from Onboard speakers OR USB when USB is selected


Comment 16 by warx@chromium.org, Jul 25 2017

If you play a local media file like a mp3 on Chrome OS, that works fine, then the issue is very likely cause by https://chromium-review.googlesource.com/c/538754/. +1 for speculatively reverting, since maxmorin is also ooo for a while.
warx@ can we get this revert in asap on 61?

Comment 18 by warx@chromium.org, Jul 25 2017

Labels: Merge-Request-61
sure, requesting revert on m61.
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61.
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 25 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2da06c9098862a1e6364fca1af22c528d96dee2

commit e2da06c9098862a1e6364fca1af22c528d96dee2
Author: Qiang Xu <warx@chromium.org>
Date: Tue Jul 25 20:15:06 2017

[revert in m61] Revert "Support GetAssociatedOutputDeviceID on CrOS."

This reverts commit c8bc83f1143c9d5424154b875cfe753759e28176.

Reason for revert: this is a speculative revert in M61 in hope of
fixing  crbug.com/748267 .

TBR: jennyz@chromium.org, tommi@chromium.org, maxmorin@chromium.org
Bug:  748267 , 636300
Change-Id: I895fcdd322ccb29ca37e1dd9d06d6d8d3fe5dc0e
Reviewed-on: https://chromium-review.googlesource.com/585596
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#33}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/e2da06c9098862a1e6364fca1af22c528d96dee2/chromeos/audio/cras_audio_handler.cc
[modify] https://crrev.com/e2da06c9098862a1e6364fca1af22c528d96dee2/chromeos/audio/cras_audio_handler.h
[modify] https://crrev.com/e2da06c9098862a1e6364fca1af22c528d96dee2/media/audio/cras/audio_manager_cras.cc
[modify] https://crrev.com/e2da06c9098862a1e6364fca1af22c528d96dee2/media/audio/cras/audio_manager_cras.h

Thanks. Verified this is fixed in:
CrOS 9765.7.0
Chrome 61.0.3163.13
Thanks. Guido, could you take a look if it is possible to land+merge and amended CL for M61? 
Not able to reproduce on 9765.7.0, 61.0.3163.13
Google Chrome : 62.0.3166.0 (Official Build) dev (32-bit)
Platform: 9781.0.0 (Official Build) dev-channel bob

The issue is still reproducible.

Comment 25 by warx@chromium.org, Jul 26 2017

this is expected because the culprit cl is not reverted on tot/m62, we can probably wait the cl owner to fix it?
Yes, we do need this feature. Ideally we'd get an amended CL landed for M61 as well.
> this is expected because the culprit cl is not reverted on tot/m62, we can probably wait the cl owner to fix it?

Considering a super simple revert worked on the 61 branch, how does not reverting the same on the ToT help anyone or anything?

(surprised the revert happened on the branch first)

> I don't think we can afford to wait till Monday. This affects every single device on canary and eventually dev channel.

Agreed, please get audio back to a working state to unblock all other audio development and validation activities, thanks!

Comment 28 by warx@chromium.org, Jul 27 2017

ok, let me also revert it on tot.
Project Member

Comment 29 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82918d4ddeaf2995e1e4c8f1ce8501f326cb98de

commit 82918d4ddeaf2995e1e4c8f1ce8501f326cb98de
Author: Qiang(Joe) Xu <warx@chromium.org>
Date: Thu Jul 27 22:46:09 2017

Revert "Support GetAssociatedOutputDeviceID on CrOS."

This reverts commit c8bc83f1143c9d5424154b875cfe753759e28176.

Reason for revert:  crbug.com/748267 

Original change's description:
> Support GetAssociatedOutputDeviceID on CrOS.
> 
> With this CL, AudioManagerCras associates devices with each other
> based on their chromeos::AudioDevice::device_name, which represents
> the physical hardware of a device. This will also allow Chrome to
> compute group ids for audio devices.
> 
> Also fix lint errors.
> 
> BUG=636300
> 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Idbbb4b3ad833564f603e317093108eadfbbdddf8
> Reviewed-on: https://chromium-review.googlesource.com/538754
> Reviewed-by: Jenny Zhang <jennyz@chromium.org>
> Reviewed-by: Tommi <tommi@chromium.org>
> Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
> Commit-Queue: Max Morin <maxmorin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487814}

TBR=jennyz@chromium.org,tommi@chromium.org,warx@chromium.org,maxmorin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

TBR: jennyz@chromium.org, tommi@chromium.org, maxmorin@chromium.org
Bug: 636300, 748267 
Change-Id: I916e1075026f419beed8948312435c9d23d226cc
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/585402
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490031}
[modify] https://crrev.com/82918d4ddeaf2995e1e4c8f1ce8501f326cb98de/chromeos/audio/cras_audio_handler.cc
[modify] https://crrev.com/82918d4ddeaf2995e1e4c8f1ce8501f326cb98de/chromeos/audio/cras_audio_handler.h
[modify] https://crrev.com/82918d4ddeaf2995e1e4c8f1ce8501f326cb98de/media/audio/cras/audio_manager_cras.cc
[modify] https://crrev.com/82918d4ddeaf2995e1e4c8f1ce8501f326cb98de/media/audio/cras/audio_manager_cras.h

Comment 30 by warx@chromium.org, Jul 27 2017

bug should be fixed on tot now
Project Member

Comment 31 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64abc8e04cf992bb93d014efcb43828dcab11298

commit 64abc8e04cf992bb93d014efcb43828dcab11298
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue Aug 01 07:42:14 2017

Reland "Support GetAssociatedOutputDeviceID on CrOS.""

This reverts commit 82918d4ddeaf2995e1e4c8f1ce8501f326cb98de.

Reason for revert: Will reland a patched version of this CL.

Original change's description:
> Revert "Support GetAssociatedOutputDeviceID on CrOS."
> 
> This reverts commit c8bc83f1143c9d5424154b875cfe753759e28176.
> 
> Reason for revert:  crbug.com/748267 
> 
> Original change's description:
> > Support GetAssociatedOutputDeviceID on CrOS.
> > 
> > With this CL, AudioManagerCras associates devices with each other
> > based on their chromeos::AudioDevice::device_name, which represents
> > the physical hardware of a device. This will also allow Chrome to
> > compute group ids for audio devices.
> > 
> > Also fix lint errors.
> > 
> > BUG=636300
> > 
> > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> > Change-Id: Idbbb4b3ad833564f603e317093108eadfbbdddf8
> > Reviewed-on: https://chromium-review.googlesource.com/538754
> > Reviewed-by: Jenny Zhang <jennyz@chromium.org>
> > Reviewed-by: Tommi <tommi@chromium.org>
> > Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
> > Commit-Queue: Max Morin <maxmorin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#487814}
> 
> TBR=jennyz@chromium.org,tommi@chromium.org,warx@chromium.org,maxmorin@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> TBR: jennyz@chromium.org, tommi@chromium.org, maxmorin@chromium.org
> Bug: 636300, 748267 
> Change-Id: I916e1075026f419beed8948312435c9d23d226cc
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/585402
> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
> Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490031}

TBR=jennyz@chromium.org,tommi@chromium.org,warx@chromium.org,maxmorin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 636300,  748267 
Change-Id: I5d8c518c5c840ea77f3f712d0b5e54e2d5aa8a75
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/593687
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490905}
[modify] https://crrev.com/64abc8e04cf992bb93d014efcb43828dcab11298/chromeos/audio/cras_audio_handler.cc
[modify] https://crrev.com/64abc8e04cf992bb93d014efcb43828dcab11298/chromeos/audio/cras_audio_handler.h
[modify] https://crrev.com/64abc8e04cf992bb93d014efcb43828dcab11298/media/audio/audio_manager_base.cc
[modify] https://crrev.com/64abc8e04cf992bb93d014efcb43828dcab11298/media/audio/cras/audio_manager_cras.cc
[modify] https://crrev.com/64abc8e04cf992bb93d014efcb43828dcab11298/media/audio/cras/audio_manager_cras.h

Labels: -ReleaseBlock-Dev

Comment 33 Deleted

I relanded a fixed patch that should not break existing audio behavior.
conradlo@: can somone on your team check ToT to see if it's working correctly on various devices?
Prasanthi - can we verify this fix once it lands in Chrome and after Chrome OS uprevs ?
Not able to repro with today's M62 ToT version 9801.0.0/62.0.3174.0 on Peppy, Kevin & Squawks
Guido, can you confirm whether 62.0.3174.0 has your fix?
I confirm that 62.0.3174.0 has the fix.
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on Peppy, Kevin and squawks with version:
M61 - 9765.16.0, 61.0.3163.30
M62 - 9801.0.0, 62.0.3174.0
Project Member

Comment 41 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73cf47c1e558ccd7e73dcf0ea2322830ed3dbb09

commit 73cf47c1e558ccd7e73dcf0ea2322830ed3dbb09
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue Aug 08 15:15:29 2017

Reland "Support GetAssociatedOutputDeviceID on CrOS.""

This reverts commit 82918d4ddeaf2995e1e4c8f1ce8501f326cb98de.

Reason for revert: Will reland a patched version of this CL.

Original change's description:
> Revert "Support GetAssociatedOutputDeviceID on CrOS."
>
> This reverts commit c8bc83f1143c9d5424154b875cfe753759e28176.
>
> Reason for revert:  crbug.com/748267 
>
> Original change's description:
> > Support GetAssociatedOutputDeviceID on CrOS.
> >
> > With this CL, AudioManagerCras associates devices with each other
> > based on their chromeos::AudioDevice::device_name, which represents
> > the physical hardware of a device. This will also allow Chrome to
> > compute group ids for audio devices.
> >
> > Also fix lint errors.
> >
> > BUG=636300
> >
> > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> > Change-Id: Idbbb4b3ad833564f603e317093108eadfbbdddf8
> > Reviewed-on: https://chromium-review.googlesource.com/538754
> > Reviewed-by: Jenny Zhang <jennyz@chromium.org>
> > Reviewed-by: Tommi <tommi@chromium.org>
> > Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
> > Commit-Queue: Max Morin <maxmorin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#487814}
>
> TBR=jennyz@chromium.org,tommi@chromium.org,warx@chromium.org,maxmorin@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> TBR: jennyz@chromium.org, tommi@chromium.org, maxmorin@chromium.org
> Bug: 636300, 748267 
> Change-Id: I916e1075026f419beed8948312435c9d23d226cc
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/585402
> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
> Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490031}

TBR=guidou@chromium.org, jennyz@chromium.org, maxmorin@chromium.org, tommi@chromium.org, warx@chromium.org


(cherry picked from commit 64abc8e04cf992bb93d014efcb43828dcab11298)

Bug: 636300,  748267 
Change-Id: I5d8c518c5c840ea77f3f712d0b5e54e2d5aa8a75
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/593687
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490905}
Reviewed-on: https://chromium-review.googlesource.com/605950
Cr-Commit-Position: refs/branch-heads/3163@{#379}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/73cf47c1e558ccd7e73dcf0ea2322830ed3dbb09/chromeos/audio/cras_audio_handler.cc
[modify] https://crrev.com/73cf47c1e558ccd7e73dcf0ea2322830ed3dbb09/chromeos/audio/cras_audio_handler.h
[modify] https://crrev.com/73cf47c1e558ccd7e73dcf0ea2322830ed3dbb09/media/audio/audio_manager_base.cc
[modify] https://crrev.com/73cf47c1e558ccd7e73dcf0ea2322830ed3dbb09/media/audio/cras/audio_manager_cras.cc
[modify] https://crrev.com/73cf47c1e558ccd7e73dcf0ea2322830ed3dbb09/media/audio/cras/audio_manager_cras.h

Sign in to add a comment