New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748255 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: 5
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

cras should allow for more nuanced filename derivation

Project Member Reported by jclinton@chromium.org, Jul 24 2017

Issue description

cras--the Chrome Audio System/Server--uses its 4th parameter to configure the derivation of the config files that it picks up during start. In:
# cat /usr/share/cros/init/cras.sh
...
# For boards that need a different device config, check which config
# directory to use. Use that directory for both volume curves
# and DSP config.
if [ -f /etc/cras/get_device_config_dir ]; then
  device_config_dir="$(sh /etc/cras/get_device_config_dir)"
  DEVICE_CONFIG_DIR="--device_config_dir=${device_config_dir}"
  DSP_CONFIG="--dsp_config=${device_config_dir}/dsp.ini"
fi
if [ -f /etc/cras/get_internal_ucm_suffix ]; then
  internal_ucm_suffix="$(sh /etc/cras/get_internal_ucm_suffix)"
  INTERNAL_UCM_SUFFIX="--internal_ucm_suffix=${internal_ucm_suffix}"
fi
exec minijail0 -u cras -g cras -G -n -- /usr/bin/cras \
    ${DSP_CONFIG} ${DEVICE_CONFIG_DIR} ${DISABLE_PROFILE} \
    ${INTERNAL_UCM_SUFFIX}

This results in a sub-optimal amount of duplication of configuration and model name proliferation in the Unified Build directory structure. E.g. https://chrome-internal-review.googlesource.com/c/416772/ .

This bug will track changing cras itself to do something smarter, cleaner, better.
 
Cc: chinyue@chromium.org hychao@chromium.org cychiang@chromium.org
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 25

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment