QuicHttpStream returns QUIC_PROTOCOL_ERROR when reading a solo fin |
|||||
Issue descriptionIf QuicHttpStream::ReadResponseBody is called when there is a solo fin to be read, it will return ERR_QUIC_PROTOCOL_ERROR instead of OK. This is likely the cause of: https://bugs.chromium.org/p/gerrit/issues/detail?id=6729
,
Jul 26 2017
,
Jul 27 2017
As per govind@'s request for more information: * This has been on Canary for a couple days now and does not appear to cause any new problems. * Other than the new regression test, the change is only a single line and as such is expected to be quite safe. * It would be good to merge this because this bug is making it hard for chrome developers to use PolyGerrit (and quite possibly other users of other Google services though we don't yet have bug reports)
,
Jul 27 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca72ca802b99d0ac05bc85b5429c842d83aa7580 commit ca72ca802b99d0ac05bc85b5429c842d83aa7580 Author: Ryan Hamilton <rch@chromium.org> Date: Thu Jul 27 21:44:32 2017 [m61 merge] QuicHttpStream::ReadResponseBody() should return OK if a solo fin is read, not ERR_QUIC_PROTOCOL_ERROR. BUG= 748249 TBR=rch@chromium.org (cherry picked from commit 2ef0a9c3ed9aa629c0bb7428d4dfed904bfbb2cb) Change-Id: I08e68b5ddf366f0632c49a3ec993ce62e9c8b891 Reviewed-on: https://chromium-review.googlesource.com/583906 Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489209} Reviewed-on: https://chromium-review.googlesource.com/590753 Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#96} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/ca72ca802b99d0ac05bc85b5429c842d83aa7580/net/quic/chromium/quic_http_stream.cc [modify] https://crrev.com/ca72ca802b99d0ac05bc85b5429c842d83aa7580/net/quic/chromium/quic_http_stream_test.cc
,
Jul 29 2017
,
Jul 29 2017
Thank your for fixing this! Much appreciated! Cheers!
,
Jul 29 2017
you* :)
,
Aug 1 2017
Issue 751053 has been merged into this issue.
,
Nov 10 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jul 25 2017