New issue
Advanced search Search tips

Issue 748245 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 748242



Sign in to add a comment

Telemetry needs to be updated for macOS 10.13 High Sierra

Project Member Reported by rsesek@chromium.org, Jul 24 2017

Issue description

Chrome Version: 35503439a8693b3e945122f8f383e188638f13f0
OS: macOS 10.13

What steps will reproduce the problem?
(1) Run telemetry_gpu_unittests, telemetry_perf_unittests, or telemetry_unittests
(2) Get this exception:

INFO:root:Try printing formatted exception: <type 'exceptions.NotImplementedError'> Unknown mac version 17.0.0. <traceback object at 0x1024a30e0>
Traceback (most recent call last):
  <module> at /b/c/builder/Chromium_Mac_10_13/ir/third_party/catapult/telemetry/telemetry/testing/run_tests.py:302
    ret_code = RunTestsCommand.main()
  main at /b/c/builder/Chromium_Mac_10_13/ir/third_party/catapult/telemetry/telemetry/testing/run_tests.py:123
    return obj.Run(options)
  Run at /b/c/builder/Chromium_Mac_10_13/ir/third_party/catapult/telemetry/telemetry/testing/run_tests.py:162
    elif platform.GetOSVersionName() == 'xp':
  GetOSVersionName at /b/c/builder/Chromium_Mac_10_13/ir/third_party/catapult/telemetry/telemetry/core/platform.py:151
    return self._platform_backend.GetOSVersionName()
  Cacher at /b/c/builder/Chromium_Mac_10_13/ir/third_party/catapult/telemetry/telemetry/decorators.py:35
    cacher.__cache[key] = obj(*args, **kwargs)
  GetOSVersionName at /b/c/builder/Chromium_Mac_10_13/ir/third_party/catapult/telemetry/telemetry/internal/platform/mac_platform_backend.py:164
    raise NotImplementedError('Unknown mac version %s.' % os_version)
NotImplementedError: Unknown mac version 17.0.0.
Locals:
  os_version : '17.0.0'

Job run: https://luci-milo.appspot.com/buildbot/chromium.fyi/Chromium%20Mac%2010.13/1
Logs: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FChromium_Mac_10.13%2F1%2F%2B%2Frecipes%2Fsteps%2Ftelemetry_unittests%2F0%2Fstdout

What is the expected result?
Test runs.

What happens instead?
Test errors out.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 by rsesek@chromium.org, Jul 25 2017

Owner: rsesek@chromium.org
Status: Started (was: Untriaged)
https://codereview.chromium.org/2990673002/
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea4f361218da75d4ccd3b76e50f0066b9d09e8b4

commit ea4f361218da75d4ccd3b76e50f0066b9d09e8b4
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed Jul 26 23:34:09 2017

Roll src/third_party/catapult/ 98b619ed4..0f1f20d43 (2 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/98b619ed40a9..0f1f20d4390e

$ git log 98b619ed4..0f1f20d43 --date=short --no-merges --format='%ad %ae %s'
2017-07-26 rsesek [Telemetry] Add support for macOS 10.13 High Sierra.
2017-07-26 loloangela Fixed errors related to bad-continuation pt.28

Created with:
  roll-dep src/third_party/catapult
BUG= 748245 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia70e2aa59cd00d921b2a9ccbb7f06c82d235cf07
Reviewed-on: https://chromium-review.googlesource.com/587374
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489798}
[modify] https://crrev.com/ea4f361218da75d4ccd3b76e50f0066b9d09e8b4/DEPS

Sign in to add a comment