need data pipe to return an error status code when completes |
|||
Issue descriptionCurrently data pipe doesn't support aborting with an error status. We need this feature to avoid extra data copy in DownloadRequestCore. Currently DownloadRequestCore uses a ByteStream reader/writer pair to make an extra copy the data from http response. In order to get rid of that copy when data pipe is used, we want to something similar to ByteStreamWrite::Close(status) so that the consumer side can know the error. I think this feature is also requested by others here: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/HPOwhIVrAqc
,
Jul 24 2017
We're unlikely to provide this ability any time soon. It would require changing Mojo's internal IPC protocol in a way that would break binary backwards-compatibility. Is the need really strong enough to justify such an effort? Realistically, any unnecessary reading is bounded by the capacity of the data pipe. How big of a pipe are we talking about?
,
Jul 24 2017
Unnecessary reading is not a big issue here. The problem is passing a status code to the consumer.
,
Jul 24 2017
You should just use a message pipe for that.
,
Oct 17
,
Dec 18
No longer relevant. |
|||
►
Sign in to add a comment |
|||
Comment 1 by jam@chromium.org
, Jul 24 2017Components: Internals>Mojo
Owner: ----