New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748220 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

findit doesn't have an easy file a bug link like other infra tools

Project Member Reported by ojan@chromium.org, Jul 24 2017

Issue description

Monorail and sheriff-o-matic have a file a bug link in the bottom right corner.
 

Comment 1 by chanli@chromium.org, Jul 24 2017

Status: Available (was: Untriaged)
Hi Ojan, thank you for filing the bug. I think you're talking about Flake Analyzer (Findit for flaky tests), right?

Jeff - Could you take this?
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3e7c7695dee6b4f3ab69e0640a46a4890796492c

commit 3e7c7695dee6b4f3ab69e0640a46a4890796492c
Author: Shuotao Gao <stgao@chromium.org>
Date: Fri Nov 10 23:14:09 2017

[Findit] Add the Universal Feedback Button to each user-facing pages.

This follows https://chromium.googlesource.com/infra/infra/+/master/crdx/feedback/README.md
Add to the <findit-app> template so that each user-facing page will have it automatically.
With some more clean-up of the "function(i,s,o,g,r,a,m)" and moving the added function to "created" like in <app-messages>, it is possible to pass labels/components/etc from individual pages.

Bug:  748220 
Change-Id: I1f77dc9fa5aad7cbc3386cfe581ae6d4bd56d4b9
Reviewed-on: https://chromium-review.googlesource.com/764509
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>

[modify] https://crrev.com/3e7c7695dee6b4f3ab69e0640a46a4890796492c/appengine/findit/templates/flake/flake-culprit.html
[modify] https://crrev.com/3e7c7695dee6b4f3ab69e0640a46a4890796492c/appengine/findit/templates/waterfall/culprit.html
[modify] https://crrev.com/3e7c7695dee6b4f3ab69e0640a46a4890796492c/appengine/findit/templates/build_failure.html
[modify] https://crrev.com/3e7c7695dee6b4f3ab69e0640a46a4890796492c/appengine/findit/ui/elements/findit-app.html

Comment 3 by st...@chromium.org, Nov 10 2017

Owner: st...@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment