New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748218 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 747031



Sign in to add a comment

CompositorImpl::SetVisible is not called when screen turns off

Project Member Reported by ssid@chromium.org, Jul 24 2017

Issue description

When Chrome goes to background, the CompositoImpl should be notified SetVisible(false) to clear the LayerTreeFrameSink and the Display that it is holding.
HandlePendingLayerTreeFrameSinkRequest() calls can create gl contexts when chrome is in background even if the surface is not visible.
 

Comment 1 by aelias@chromium.org, Jul 24 2017

When I looked into this on Jun 1 for https://codereview.chromium.org/2918023002/ I observed CompositorImpl::SetVisible was being called, did you observe differently?  Might be a recent regression if so?

Comment 2 by ssid@chromium.org, Jul 24 2017

Actually you are right, it gets called when I test manually. Somehow it is not set in the benchmark causing  issue 747031 . I will get more info on this soon.

Comment 3 by ssid@chromium.org, Jul 25 2017

So, the issue is the CompositorImpl::SetVisible should be called by android window callback dispatching at android.view.SurfaceView.updateWindow.
But Android system only destroys the surface if the app goes to background and not if the power button is pressed when app is in foreground.
But, application's activities are destroyed on both cases when the application becomes invisible.

This causes the CompositorImpl to not know that the app is invisible but, the activities destroyed notification tries to clear the gl memory and recreates because the surface is not destroyed.

Comment 4 by ssid@chromium.org, Jul 25 2017

Summary: CompositorImpl::SetVisible is not called when screen turns off (was: CompositorImpl::SetVisible is not called when Chrome goes to background)
Status: Available (was: Untriaged)

Comment 6 by ssid@chromium.org, Jul 26 2017

Cc: klo...@chromium.org boliu@chromium.org

Comment 7 Deleted

Project Member

Comment 8 by sheriffbot@chromium.org, Aug 10

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: cblume@chromium.org khushals...@chromium.org
Owner: ericrk@chromium.org
Status: Assigned (was: Untriaged)
Assigning to ericrk for Android/compositor triage.

Sign in to add a comment