his uses stale options UI. It should be replaced with Settings UI.
ProxySettingsUI uses stale options UI. It should be replaced with Settings UI.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e7e0b2039cc212c7111c264d6822b24f24b2eef commit 5e7e0b2039cc212c7111c264d6822b24f24b2eef Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Aug 03 16:58:33 2017 WebUI: Move network elements to ui/webui/resources/chromeos This moves the network_property_list element and network elements that depend on it (apnlist, ip_config, nameservers) to a shared location so that they can be used by Web UI dialogs. Bug: 748204 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9d4b57167c31a8ed1811aa680838e3ba38105df2 Reviewed-on: https://chromium-review.googlesource.com/596410 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491768} [modify] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/chrome/app/settings_strings.grdp [modify] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/chrome/browser/resources/settings/internet_page/compiled_resources2.gyp [modify] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/chrome/browser/resources/settings/internet_page/internet_detail_page.html [modify] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/chrome/browser/resources/settings/internet_page/internet_shared_css.html [modify] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/ui/webui/resources/chromeos/compiled_resources2.gyp [add] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/ui/webui/resources/chromeos/network/compiled_resources2.gyp [rename] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/ui/webui/resources/chromeos/network/network_apnlist.html [rename] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/ui/webui/resources/chromeos/network/network_apnlist.js [rename] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/ui/webui/resources/chromeos/network/network_ip_config.html [rename] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/ui/webui/resources/chromeos/network/network_ip_config.js [rename] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/ui/webui/resources/chromeos/network/network_nameservers.html [rename] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/ui/webui/resources/chromeos/network/network_nameservers.js [rename] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/ui/webui/resources/chromeos/network/network_property_list.html [rename] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/ui/webui/resources/chromeos/network/network_property_list.js [add] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/ui/webui/resources/chromeos/network/network_shared_css.html [modify] https://crrev.com/5e7e0b2039cc212c7111c264d6822b24f24b2eef/ui/webui/resources/chromeos_elements_resources.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec62d8a012faab37e4c1c40000f3485cb9295708 commit ec62d8a012faab37e4c1c40000f3485cb9295708 Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Aug 03 21:22:52 2017 WebUI: Move the network_proxy element to ui/webui/resources/chromeos This moves the network_proxy element to a shared location so that it can be used by Web UI dialogs. It also adds a network_proxy_section element to handle proxy related prefs that are specific to Settings. Bug: 748204 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6e0380bddf5448546c2328a3c577a6226b639e7f Reviewed-on: https://chromium-review.googlesource.com/596543 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491849} [modify] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/chrome/app/settings_strings.grdp [modify] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/chrome/browser/resources/settings/internet_page/compiled_resources2.gyp [modify] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/chrome/browser/resources/settings/internet_page/internet_detail_page.html [delete] https://crrev.com/69722f400b9def82e76a88597a425a951104cf01/chrome/browser/resources/settings/internet_page/network_proxy.html [add] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/chrome/browser/resources/settings/internet_page/network_proxy_section.html [add] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/chrome/browser/resources/settings/internet_page/network_proxy_section.js [modify] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/ui/webui/resources/chromeos/network/compiled_resources2.gyp [add] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/ui/webui/resources/chromeos/network/network_proxy.html [rename] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/ui/webui/resources/chromeos/network/network_proxy.js [rename] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/ui/webui/resources/chromeos/network/network_proxy_exclusions.html [rename] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/ui/webui/resources/chromeos/network/network_proxy_exclusions.js [rename] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/ui/webui/resources/chromeos/network/network_proxy_input.html [rename] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/ui/webui/resources/chromeos/network/network_proxy_input.js [modify] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/ui/webui/resources/chromeos/network/network_shared_css.html [modify] https://crrev.com/ec62d8a012faab37e4c1c40000f3485cb9295708/ui/webui/resources/chromeos_elements_resources.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39b2f1ad599a1998475def9a839ce517db2008a3 commit 39b2f1ad599a1998475def9a839ce517db2008a3 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Aug 15 23:02:58 2017 WebUI: Use Settings UI for proxy dialog ProxySettingsDialog/ProxySettingsUI currently use deprecated options UI to allow proxy configuration in the login screen. This CL replaces that with a much simpler but more functional internet-detail-dialog element which embeds shared network elements from the Settings UI. This allows configuration of Proxy, IP Config, Nameservers, and APN in the login screen (and removes the dependency on the deprecated options UI). Bug: 748204 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If8ac662fd069245069df28c93c502b6262a027b6 Reviewed-on: https://chromium-review.googlesource.com/599234 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#494592} [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/app/settings_strings.grdp [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/browser/browser_resources.grd [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/browser/chromeos/login/ui/proxy_settings_dialog.h [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/browser/resources/chromeos/compiled_resources2.gyp [add] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/browser/resources/chromeos/internet_detail_dialog.html [add] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/browser/resources/chromeos/internet_detail_dialog.js [delete] https://crrev.com/ea54eae46e2c914ff3d3c9e9a337c0b89e4e4043/chrome/browser/resources/chromeos/proxy_settings.css [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/browser/resources/chromeos/proxy_settings.html [delete] https://crrev.com/ea54eae46e2c914ff3d3c9e9a337c0b89e4e4043/chrome/browser/resources/chromeos/proxy_settings.js [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/browser/resources/settings/internet_page/internet_detail_page.html [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/browser/resources/settings/internet_page/internet_detail_page.js [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.h [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/browser/ui/webui/chromeos/proxy_settings_ui.h [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/extensions/common/api/_api_features.json [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/ui/webui/resources/cr_components/chromeos/network/network_property_list.html [modify] https://crrev.com/39b2f1ad599a1998475def9a839ce517db2008a3/ui/webui/resources/cr_components/chromeos/network/network_proxy.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5839b44293dd74cdacc82464d886fc6d9d77fc4d commit 5839b44293dd74cdacc82464d886fc6d9d77fc4d Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Aug 16 19:21:26 2017 Login: Open internet details dialog for connected networks in login Now that we have a nicer UI for network configuration in the login screen, we should open it when a connected network is selected from the login screen just like we do when logged in. Bug: 748204 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I18e7972a58c8c2062e4c2496007e0dceee5275ca Reviewed-on: https://chromium-review.googlesource.com/602447 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#494895} [modify] https://crrev.com/5839b44293dd74cdacc82464d886fc6d9d77fc4d/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc [modify] https://crrev.com/5839b44293dd74cdacc82464d886fc6d9d77fc4d/chrome/browser/chromeos/login/ui/login_display_host.h [modify] https://crrev.com/5839b44293dd74cdacc82464d886fc6d9d77fc4d/chrome/browser/chromeos/login/ui/login_display_host_impl.cc [modify] https://crrev.com/5839b44293dd74cdacc82464d886fc6d9d77fc4d/chrome/browser/chromeos/login/ui/login_display_host_impl.h [modify] https://crrev.com/5839b44293dd74cdacc82464d886fc6d9d77fc4d/chrome/browser/chromeos/login/ui/mock_login_display_host.h [modify] https://crrev.com/5839b44293dd74cdacc82464d886fc6d9d77fc4d/chrome/browser/chromeos/login/ui/webui_login_view.cc [modify] https://crrev.com/5839b44293dd74cdacc82464d886fc6d9d77fc4d/chrome/browser/chromeos/login/ui/webui_login_view.h [modify] https://crrev.com/5839b44293dd74cdacc82464d886fc6d9d77fc4d/chrome/browser/ui/ash/system_tray_client.cc [modify] https://crrev.com/5839b44293dd74cdacc82464d886fc6d9d77fc4d/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc [modify] https://crrev.com/5839b44293dd74cdacc82464d886fc6d9d77fc4d/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/327ba81c41600063fed0b9e1642416db1aa4ac27 commit 327ba81c41600063fed0b9e1642416db1aa4ac27 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Aug 16 20:38:15 2017 WebUI: Elim extraneous </script> tags Converting <script> -> <link> left some extraneous </script> tags. This CL removes them. Bug: 748193 , 748204 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I573a29c62ecf237aaa10d08a8cbd2ffcb426d9d1 Trivial fix for recent change: TBR=michaelpg@chromium.org Change-Id: I573a29c62ecf237aaa10d08a8cbd2ffcb426d9d1 Reviewed-on: https://chromium-review.googlesource.com/617442 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#494930} [modify] https://crrev.com/327ba81c41600063fed0b9e1642416db1aa4ac27/chrome/browser/resources/chromeos/bluetooth_pair_device.html [modify] https://crrev.com/327ba81c41600063fed0b9e1642416db1aa4ac27/chrome/browser/resources/chromeos/proxy_settings.html
Issue 665751 has been merged into this issue.
Comment 1 by steve...@chromium.org
, Jul 31 2017