New issue
Advanced search Search tips

Issue 7482 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Some layout-tests could pass if we could differentiate our test_shell from the user-agent

Reported by jcampan@chromium.org, Feb 7 2009

Issue description

The following layout-test fails because of a platform difference:
LayoutTests/http/tests/misc/timer-vs-loading.html

This test redirects to a hanging page implemented with a php script.
Because of some network stack related issue (see https://bugs.webkit.org/show_bug.cgi?
id=9001#c9), the script sends few chars causing the test to fail for us.

If the test_shell had its own user-agent, we could modify the php script not to send these 
char in our case and the test would pass (and we could upstream it).
For now the test has been marked as SKIP.

If more tests like this one come up, it might be worth doing this.



 

Comment 1 by jon@chromium.org, Mar 18 2009

Status: Assigned

Comment 2 by pam@chromium.org, Apr 7 2009

Labels: LayoutTests
Labels: -Area-Misc Area-WebKit LTTF WebKit-LayoutTests Mstone-X
Status: Untriaged

Comment 5 by kerz@chromium.org, Jul 8 2010

Status: Available
Moving all bugs marked as untriaged and mstone X to be available rather than untriaged.  If you think this is in error, please feel free to set back to untriaged.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-WebKit -WebKit-LayoutTests Cr-Content Cr-Content-LayoutTests
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content Cr-Blink
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content-LayoutTests Cr-Blink-LayoutTests
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 24 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=160483

------------------------------------------------------------------------
r160483 | ojan@chromium.org | 2013-10-24T19:26:58.100918Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=160483&r2=160482&pathrev=160483
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/StaleTestExpectations?r1=160483&r2=160482&pathrev=160483

Move stale TestExpectations lines to StaleTestExpectations.

This moves all the platform-specific and/or virtual stale lines.

BUG= 308779 ,  247466 ,  239465 ,  31488 ,  30536 ,  108833 ,  14009 ,  250935 ,  23476 , 7482,  27569 ,  51571 ,  58257 ,  58735 ,  66087 ,  83290 ,  237003 ,  227473 ,  232061 ,  234758 ,  251129 ,  143475 ,  241576 ,  260660 ,  178745 ,  243248 ,  243649 ,  243732 ,  243738 ,  243894 ,  244123 ,  247889 ,  247979 ,  248065 ,  248067 ,  257325 ,  246077 ,  259547 ,  240374 
TBR=adamk@chromium.org

Review URL: https://codereview.chromium.org/38333003
------------------------------------------------------------------------
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 24 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=178796

------------------------------------------------------------------
r178796 | pkasting@chromium.org | 2014-07-24T00:57:47.148623Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/StaleTestExpectations?r1=178796&r2=178795&pathrev=178796
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/canvas/philip/tests/2d.imageData.object.ctor.html?r1=178796&r2=178795&pathrev=178796
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/ietestcenter/css3/multicolumn/column-filling-001-expected.htm?r1=178796&r2=178795&pathrev=178796
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/ietestcenter/css3/multicolumn/column-filling-001.htm?r1=178796&r2=178795&pathrev=178796
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=178796&r2=178795&pathrev=178796
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-layout-002-expected.htm?r1=178796&r2=178795&pathrev=178796
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-layout-002.htm?r1=178796&r2=178795&pathrev=178796
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/canvas/philip/tests/2d.imageData.object.ctor-expected.txt?r1=178796&r2=178795&pathrev=178796
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.html?r1=178796&r2=178795&pathrev=178796
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/sub-pixel/file-upload-control-at-fractional-offset.html?r1=178796&r2=178795&pathrev=178796
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-align-stretch-001-expected.htm?r1=178796&r2=178795&pathrev=178796
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm?r1=178796&r2=178795&pathrev=178796

First round of updates in response to commenting out stale expectations.

This deletes a few tests which sound like they're wrong/buggy, and requests
rebaselines for a variety of others (or marks them expected-to-fail for
reftests).  It also restores the stale expectations for a few tests where that's
the most appropriate action.

BUG=7482, 23476 , 243248 , 243732 , 338804 , 378610 , 396936 , 396940 , 396941 , 396945 
TEST=none
TBR=haraken

Review URL: https://codereview.chromium.org/417873003
-----------------------------------------------------------------

Comment 11 by ojan@chromium.org, Jul 23 2015

Labels: -LTTF
Labels: -Cr-Blink
Labels: Test-Layout
Components: -Blink>LayoutTests Blink
Deprecating component:Blink>LayoutTests, to use label Test=Layout instead. Merging these to component:Blink for the Blink rotation to pick up and re-triage as appropriate. 
Components: -Blink Blink>Loader
Status: Untriaged (was: Available)
The test is marked wontfix, pointing to this bug...
Labels: -Pri-2 Pri-3
Status: Available (was: Untriaged)
Either we should fix this or consider dropping/changing the test (only one imapacted?).
Project Member

Comment 17 by sheriffbot@chromium.org, May 14

Labels: Hotlist-Recharge-Cold

Sign in to add a comment