webkit tests split on two different test types in flakiness dashboard |
||||
Issue descriptionIt was (kind of) fine for a few days to have this split, but it's been weeks now. I was about to mark a test as no longer flaky because I didn't see the windows bots on the swarming list not realizing it only showed the swarming bots. If I wasn't closely familiar with the state of these bots and how the flakiness dashboard works, there's no way I would have figured out what was going on. I gave this feedback when we turned on linux swarming, so marking as high priority so it gets attention, but also because this really should be fixed ASAP, i.e. sooner than waiting for everything to be on swarming. Feel free to reprioritize appropriately. Even if it's just a short-term hack to the flakiness dashboard to have one test type pretend to be the other or something like that, that'd be fine IMO. Swarming: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fhtml%2Fsyntax%2Fparsing%2Fhtml5lib_tests16.html Non-swarming: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=external%2Fwpt%2Fhtml%2Fsyntax%2Fparsing%2Fhtml5lib_tests16.html
,
Jul 25 2017
Sorry, just saw this now - was in LuciCon throughout the day. I will try to implement a quick hack in test-results server tomorrow (should take me a few hours since I am not familiar with most of the code), but IMHO we should instead finish the migration.
,
Jul 25 2017
Thanks Sergiy. Yes, the plan is still to finish the migration, but the engineer working on it is OOO at the moment with an injury, so we don't have solid ETA on completion.
,
Jul 26 2017
CL: https://chromium-review.googlesource.com/c/586720/ Demo: https://3826e1fa3-tainted-dot-test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fhtml%2Fsyntax%2Fparsing%2Fhtml5lib_tests16.html.
,
Jul 26 2017
Thanks for fixing this quickly. It looks like you only fixed it in one direction. Could you show webkit_layout_tests bots for webkit_tests as well? Since people get to this dashboard from other locations (e.g. sheriff-o-matic), they could end up on either test suite name depending on which bot is failing.
,
Jul 26 2017
Updated CL and redeployed tainted version.
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/16a53001d6e8c8dd3f0d465e6e9cbdb59baf4f9a commit 16a53001d6e8c8dd3f0d465e6e9cbdb59baf4f9a Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Wed Jul 26 17:25:46 2017 Load both webkit_tests and webkit_layout_tests builders when either is selected R=estaab@chromium.org Bug: 748195 Change-Id: Iac1fdc46476d679ea3c4c27fe0b820a4846f92e2 Reviewed-on: https://chromium-review.googlesource.com/586720 Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> [modify] https://crrev.com/16a53001d6e8c8dd3f0d465e6e9cbdb59baf4f9a/go/src/infra/appengine/test-results/frontend/static/dashboards/js/loader.js [modify] https://crrev.com/16a53001d6e8c8dd3f0d465e6e9cbdb59baf4f9a/go/src/infra/appengine/test-results/frontend/static/dashboards/js/ui.js [modify] https://crrev.com/16a53001d6e8c8dd3f0d465e6e9cbdb59baf4f9a/go/src/infra/appengine/test-results/frontend/static/dashboards/js/flakiness_dashboard.js
,
Jul 26 2017
Deployed to production. |
||||
►
Sign in to add a comment |
||||
Comment 1 by jparent@chromium.org
, Jul 24 2017