BluetoothPairingUI depends on deprecated options UI. It should be replaced with a dedicated Settings window.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43 commit 9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Aug 02 19:10:57 2017 Settings: Move bluetooth dialog to a shared location This CL is in preparation for converting the bluetooth pairing dialog (BluetoothPairingUI) to use the MD Settings UI. This CL: * Eliminate Settings dependencies from the bluetooth dialog element and moves some dialog related error parsing into the dialog element. * Moves some 'options' strings to settings_strings.grd in anticipation of removal of all options strings. * Adds a new shared location for higher level shared chromeos elements: ui/webui/resources/chromeos. These elements are allowed to use I18nBehavior to simplify localization. * Moves the bluetooth dialog element to the new shared location. Bug: 748193 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I861730aa9cbbe5cb37a8df3d26f62d9f20429672 Reviewed-on: https://chromium-review.googlesource.com/592461 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491459} [modify] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/PRESUBMIT.py [modify] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/chrome/app/settings_strings.grdp [modify] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html [modify] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js [modify] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/chrome/browser/resources/settings/bluetooth_page/compiled_resources2.gyp [modify] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/chrome/browser/resources/vulcanize_gn.py [modify] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/content/browser/webui/shared_resources_data_source.cc [modify] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/third_party/closure_compiler/compiled_resources2.gyp [modify] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/ui/webui/resources/PRESUBMIT.py [add] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/ui/webui/resources/chromeos/OWNERS [add] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/ui/webui/resources/chromeos/README.md [rename] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/ui/webui/resources/chromeos/bluetooth_dialog.html [rename] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/ui/webui/resources/chromeos/bluetooth_dialog.js [add] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/ui/webui/resources/chromeos/compiled_resources2.gyp [add] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/ui/webui/resources/chromeos_elements_resources.grdp [modify] https://crrev.com/9c7e3c2d0eae8da0179f44e4fcc708ac3948bc43/ui/webui/resources/webui_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4308d4c6bda951470577cffc1012f9f53a24aaae commit 4308d4c6bda951470577cffc1012f9f53a24aaae Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Aug 03 01:57:26 2017 Use bluetooth-dialog for BluetoothPairingUI This changes BluetoothPairingUI to use the shared bluetooth-dialog component instead of the (soon to be removed) options UI. Bug: 748193 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4061d81ce1fca9672236b45b50e3c3e8b4ee764c Reviewed-on: https://chromium-review.googlesource.com/595137 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491607} [modify] https://crrev.com/4308d4c6bda951470577cffc1012f9f53a24aaae/chrome/browser/browser_resources.grd [modify] https://crrev.com/4308d4c6bda951470577cffc1012f9f53a24aaae/chrome/browser/chromeos/bluetooth/bluetooth_pairing_dialog.cc [add] https://crrev.com/4308d4c6bda951470577cffc1012f9f53a24aaae/chrome/browser/resources/chromeos/bluetooth_dialog_host.html [add] https://crrev.com/4308d4c6bda951470577cffc1012f9f53a24aaae/chrome/browser/resources/chromeos/bluetooth_dialog_host.js [delete] https://crrev.com/c7a7d38c399caec33863c6d7bd314345c7bc2ad7/chrome/browser/resources/chromeos/bluetooth_options.js [delete] https://crrev.com/c7a7d38c399caec33863c6d7bd314345c7bc2ad7/chrome/browser/resources/chromeos/bluetooth_pair_device.css [modify] https://crrev.com/4308d4c6bda951470577cffc1012f9f53a24aaae/chrome/browser/resources/chromeos/bluetooth_pair_device.html [delete] https://crrev.com/c7a7d38c399caec33863c6d7bd314345c7bc2ad7/chrome/browser/resources/chromeos/bluetooth_pair_device.js [modify] https://crrev.com/4308d4c6bda951470577cffc1012f9f53a24aaae/chrome/browser/resources/chromeos/compiled_resources2.gyp [modify] https://crrev.com/4308d4c6bda951470577cffc1012f9f53a24aaae/chrome/browser/ui/BUILD.gn [add] https://crrev.com/4308d4c6bda951470577cffc1012f9f53a24aaae/chrome/browser/ui/webui/chromeos/bluetooth_dialog_localized_strings_provider.cc [add] https://crrev.com/4308d4c6bda951470577cffc1012f9f53a24aaae/chrome/browser/ui/webui/chromeos/bluetooth_dialog_localized_strings_provider.h [modify] https://crrev.com/4308d4c6bda951470577cffc1012f9f53a24aaae/chrome/browser/ui/webui/chromeos/bluetooth_pairing_ui.cc [modify] https://crrev.com/4308d4c6bda951470577cffc1012f9f53a24aaae/chrome/browser/ui/webui/chromeos/bluetooth_pairing_ui.h [modify] https://crrev.com/4308d4c6bda951470577cffc1012f9f53a24aaae/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
One down!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/075523bb31f053e1f95252df7379df786c97dea4 commit 075523bb31f053e1f95252df7379df786c97dea4 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Aug 16 02:44:06 2017 Bluetooth dialog: Fix fonts and script imports Bug: 748193 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8d540ee1cc0a68fa4a2741b16d97a66575a57f23 Reviewed-on: https://chromium-review.googlesource.com/615668 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#494676} [modify] https://crrev.com/075523bb31f053e1f95252df7379df786c97dea4/chrome/browser/resources/chromeos/bluetooth_pair_device.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/327ba81c41600063fed0b9e1642416db1aa4ac27 commit 327ba81c41600063fed0b9e1642416db1aa4ac27 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Aug 16 20:38:15 2017 WebUI: Elim extraneous </script> tags Converting <script> -> <link> left some extraneous </script> tags. This CL removes them. Bug: 748193 , 748204 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I573a29c62ecf237aaa10d08a8cbd2ffcb426d9d1 Trivial fix for recent change: TBR=michaelpg@chromium.org Change-Id: I573a29c62ecf237aaa10d08a8cbd2ffcb426d9d1 Reviewed-on: https://chromium-review.googlesource.com/617442 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#494930} [modify] https://crrev.com/327ba81c41600063fed0b9e1642416db1aa4ac27/chrome/browser/resources/chromeos/bluetooth_pair_device.html [modify] https://crrev.com/327ba81c41600063fed0b9e1642416db1aa4ac27/chrome/browser/resources/chromeos/proxy_settings.html
Comment 1 by bugdroid1@chromium.org
, Aug 2 2017