New issue
Advanced search Search tips

Issue 748191 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 758648



Sign in to add a comment

power: power_Resume: extend test to incorporate more realistic user

Project Member Reported by tbroch@chromium.org, Jul 24 2017

Issue description

Based on comments from b/37343747,

power_Resume would more accurately model real users if,

1. suspend -> resume occurred after a login
2. incorporated arc++ container enablement if its available on platforms

In addition it would be useful to track some resume times into user space to see if there's variability or regression with respect to key user space processes being unfrozen.



 

Comment 1 by tbroch@chromium.org, Jul 28 2017

Cc: tbroch@chromium.org
Labels: -Pri-3 M-62 Pri-2
Owner: mqg@chromium.org
Status: Assigned (was: Untriaged)
Added the login piece here:

https://chromium-review.googlesource.com/c/585368/

and tested just to make sure it had minimal/no impact on any platforms.  I'll push once I figure out why ebuild for autotest-power-tests is failing.

Mengqi was going to have a look at the container piece both in the sense of enabling in autotest as well as coming up w/ a metric for when test can deem its available to user after resume.


Comment 2 by mqg@chromium.org, Aug 14 2017

From android logcat we can trace when arc++ suspend and resume. Is that what we are looking for? 

Comment 3 by mqg@chromium.org, Aug 16 2017

@tbroch

logcat doesn't come with the year, which is going to make the edge case (turn of the year) very tricky. 

Comment 4 by mqg@chromium.org, Aug 16 2017

Edge cases include turn of the year and leap year

Comment 6 by tbroch@chromium.org, Aug 23 2017

Whichever is later in the call stack / logtime is the one I'd pick.  I'd suspect its #360

Comment 7 by mqg@chromium.org, Aug 24 2017

Using #278, the later one in log time.

Comment 8 by mqg@chromium.org, Aug 24 2017

Blockedon: 758648
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bfe724449bd2bb0e76b8667bd1c2f121b6af1c5f

commit bfe724449bd2bb0e76b8667bd1c2f121b6af1c5f
Author: Mengqi Guo <mqg@chromium.org>
Date: Tue Oct 31 06:21:31 2017

power_UiResume: Measure ARC suspend to resume time

Our goal is to better simulate user environment for power_Resume
by logging into Chrome and open ARC (where available). However,
to make sure that we cover all 3 types of devices: with ARC, with
Chrome but not ARC, without Chrome, we split our work into 2 parts.
In power_Resume, we measure power numbers. This will run on all
devices. In power_UiResume, we log into Chrome and open ARC where
available, and then call power_Resume to measure power numbers.
This part will only run on devices with Chrome/ARC. In both cases,
power_Resume calls power_suspend.py, which has the option to
measure ARC suspend to resume time.

We realize that on devices with Chrome/ARC, power_Resume will
basically run twice. However, with the limitations of ebuild, this
is our optimal solution right now.

We are recycling power_UiResume because it hasn't run for a long
time in the lab and its old content was basically duplicating
power_Resume.

BUG= chromium:748191 
TEST=test_that power_Resume on minnie and link
test_that power_UiResume on minnie and link
cros_workon_make autotest-chrome on minnie and link
cros_workon_make autotest-chrome on veyron_rialto fail as expected
cros_workon_make autotest-tests-power on minnie, link and
    veyron_rialto

Change-Id: I1cb8ff23f9f26a15c1f90c0f40d98a9438fe45d0
Reviewed-on: https://chromium-review.googlesource.com/726743
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[add] https://crrev.com/bfe724449bd2bb0e76b8667bd1c2f121b6af1c5f/client/site_tests/power_UiResume/control.resume_constraint
[modify] https://crrev.com/bfe724449bd2bb0e76b8667bd1c2f121b6af1c5f/tko/perf_upload/perf_dashboard_config.json
[modify] https://crrev.com/bfe724449bd2bb0e76b8667bd1c2f121b6af1c5f/client/cros/power_suspend.py
[modify] https://crrev.com/bfe724449bd2bb0e76b8667bd1c2f121b6af1c5f/client/site_tests/power_UiResume/power_UiResume.py
[add] https://crrev.com/bfe724449bd2bb0e76b8667bd1c2f121b6af1c5f/client/site_tests/power_UiResume/control.SuspendToRam
[add] https://crrev.com/bfe724449bd2bb0e76b8667bd1c2f121b6af1c5f/client/site_tests/power_UiResume/control.SuspendToIdle
[modify] https://crrev.com/bfe724449bd2bb0e76b8667bd1c2f121b6af1c5f/server/site_tests/sequences/control.power_build
[modify] https://crrev.com/bfe724449bd2bb0e76b8667bd1c2f121b6af1c5f/server/site_tests/sequences/control.power
[modify] https://crrev.com/bfe724449bd2bb0e76b8667bd1c2f121b6af1c5f/client/site_tests/power_Resume/power_Resume.py
[modify] https://crrev.com/bfe724449bd2bb0e76b8667bd1c2f121b6af1c5f/client/site_tests/power_UiResume/control

Comment 10 by mqg@chromium.org, Oct 31 2017

Status: Fixed (was: Assigned)

Sign in to add a comment