New issue
Advanced search Search tips

Issue 748186 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 811679
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Files app: Images->Download folder, Share menu is not shown

Project Member Reported by mkarkada@chromium.org, Jul 24 2017

Issue description

Chrome version: 62.0.3165.0 (dev)
platform: 9774.0.0 (dev)
caroline device

1. Open Files app
2. Navigate to Images->Download folder,
select an image, Share menu is not shown where as the Open option is visible. Please refer the attachment.
 
Screenshot 2017-07-24 at 1.49.47 PM.png
352 KB View Download
Owner: fukino@chromium.org
Status: Assigned (was: Untriaged)
I think this is actually consistent with existing behavior - The Media View folders only enable the Open intents in the dropdown and none of the Share intents.

fukino@ - Is this a technical limitation (with the read-only view) or is this something we can add?

Comment 2 by fukino@chromium.org, Jul 26 2017

Cc: hashimoto@chromium.org nya@chromium.org
Yes I suppose it is a technical limitation due to  issue 740063 .

Files in media view are exposed as virtual files with externalfile: URLs.
nya@: Correct me if I'm wrong.
hashimoto@, nya@: Will  issue 740063  make files in media view accessible from ARC container?
Labels: -M-62 M-64
fukino@ - Are we able to add the share intent in Media Views now that 740063 is fixed?

Comment 4 by fukino@chromium.org, Jan 24 2018

Status: Fixed (was: Assigned)
I'm sorry for a late response.
Yes, this issue should have been fixed on M64.
mkarkada@, could you verify it on M64 or later? Thanks!
Status: Assigned (was: Fixed)
I'm still not seeing Share menu options for Images folder. Checked on M64 beta (10176.54.0, 64.0.3282.101) and M65 dev (10323.2.0, 65.0.3325.11).
To add a point to my comment in #5, Open menu options with android apps are not available for files in Images folder.
Screenshot 2018-01-24 at 11.10.05 AM.png
225 KB View Download
Labels: -Pri-2 -M-64 M-65 Pri-1

Comment 8 by fukino@chromium.org, Jan 30 2018

Labels: -M-65 M-66
I'm sorry I misunderstood the issue.
For now we don't support opening files in media view by Android apps.
To support it, we need to handle media view files to expose ARC url.
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/file_manager/path_util.cc?type=cs&q=ConvertPathToArcUrl&sq=package:chromium&l=90

weifang@, can we punt this feature to M66?
This seems to be a good starter bug involving filesystem integration.

Comment 9 by fukino@chromium.org, Jan 30 2018

Labels: Hotlist-GoodFirstBug
Owner: noel@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/667150e532b9abe93dbe8b1941e59039b962bef2

commit 667150e532b9abe93dbe8b1941e59039b962bef2
Author: Satoshi Niwa <niwa@google.com>
Date: Tue Feb 13 10:13:55 2018

Create an async version of ConvertPathToArcUrl.

Unlike ConvertPathToArcUrl, the new version can convert file paths under ARC media directories as well.

Bug: chromium:767982
Bug:  chromium:748186 
Test: unit_tests
Change-Id: I3356b12884766c0314d5faafdff5cc8beb21fb9b
Reviewed-on: https://chromium-review.googlesource.com/906222
Commit-Queue: Satoshi Niwa <niwa@chromium.org>
Reviewed-by: Daichi Hirono <hirono@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536320}
[modify] https://crrev.com/667150e532b9abe93dbe8b1941e59039b962bef2/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/667150e532b9abe93dbe8b1941e59039b962bef2/chrome/browser/chromeos/file_manager/path_util.h
[modify] https://crrev.com/667150e532b9abe93dbe8b1941e59039b962bef2/chrome/browser/chromeos/file_manager/path_util_unittest.cc

Labels: CrOS-FilesApp-FileIntents
<files-triage>
Owner: joelhockey@chromium.org
<files-triage> Re-assigning to Joel while Noel is on vacation.
Labels: -CrOS-FilesApp-FileIntents CrOSFilesFeature-FileIntents
Labels: -M-66 M-67
Mergedinto: 811679
Status: Duplicate (was: Assigned)

Sign in to add a comment