New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748171 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

alert on broken (with no test changes) pre-cq-configs

Project Member Reported by akes...@chromium.org, Jul 24 2017

Issue description

Implementation idea:
 - after N failures of a given config, launch a null job with that config [throttle the rate at which we launch these jobs]
 - if it fails, increment a counter
 - alert on counter>=1 

 

Comment 1 by nxia@chromium.org, Jul 26 2017

wrote up a small design doc: go/sanity-check-pre-cq
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/992ec7839f22e8fdbea46473f5957ca15b9e1079

commit 992ec7839f22e8fdbea46473f5957ca15b9e1079
Author: Ningning Xia <nxia@chromium.org>
Date: Thu Jul 27 21:41:13 2017

Create buildRequestTable in CIDB.

Build a buildRequestTable to record the information of the build
which sends a request and the build which is requested.

BUG= chromium:748171 
TEST=lib/cidb_integration_test

Change-Id: If8ce53b8eac3efd9ccc3126e36f33039362e8cbf
Reviewed-on: https://chromium-review.googlesource.com/588310
Reviewed-by: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/992ec7839f22e8fdbea46473f5957ca15b9e1079/cidb/schema.dump
[add] https://crrev.com/992ec7839f22e8fdbea46473f5957ca15b9e1079/cidb/migrations/00059_create_buildRequest_table.sql

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/3efdd0a35de9526d3fe5ad2efe3aed4c40f91fe1

commit 3efdd0a35de9526d3fe5ad2efe3aed4c40f91fe1
Author: Ningning Xia <nxia@chromium.org>
Date: Fri Jul 28 02:56:26 2017

Change the build_type of Pre-CQs to 'pre_cq'.

Previously Pre-CQ configs shared incremental build_type 'binary'
with other builds like incremental builds, telementry builds, etc.
Create a 'pre_cq' type for Pre-CQ configs.

BUG= chromium:748171 
TEST=run_tests

Change-Id: Idab014b1c03a0caf5d1e98b444c418ec93bfed22
Reviewed-on: https://chromium-review.googlesource.com/588167
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/3efdd0a35de9526d3fe5ad2efe3aed4c40f91fe1/cbuildbot/config_dump.json
[modify] https://crrev.com/3efdd0a35de9526d3fe5ad2efe3aed4c40f91fe1/lib/constants.py
[modify] https://crrev.com/3efdd0a35de9526d3fe5ad2efe3aed4c40f91fe1/cbuildbot/chromeos_config.py

ddoc sent, CLs pending, eta wednesday for the metric
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/460cd8a23466d156db0633bdbbcc5acaa825dc91

commit 460cd8a23466d156db0633bdbbcc5acaa825dc91
Author: Ningning Xia <nxia@chromium.org>
Date: Tue Aug 01 00:08:28 2017

Add Insert and Get operations for buildRequestTable.

BUG= chromium:748171 
TEST=cidb_integration_test

Change-Id: If08175441f55d053fb27c91d18c232604fc3fe06
Reviewed-on: https://chromium-review.googlesource.com/590855
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[add] https://crrev.com/460cd8a23466d156db0633bdbbcc5acaa825dc91/lib/build_requests.py
[modify] https://crrev.com/460cd8a23466d156db0633bdbbcc5acaa825dc91/lib/cidb.py
[modify] https://crrev.com/460cd8a23466d156db0633bdbbcc5acaa825dc91/lib/cidb_integration_test.py

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9ab36025c4cb3abda8292c433407b6c2e84b8a27

commit 9ab36025c4cb3abda8292c433407b6c2e84b8a27
Author: Ningning Xia <nxia@chromium.org>
Date: Tue Aug 01 00:08:28 2017

Add option --sanity-check-build to Cbuildbot

A cbuildbot run with the option run as a sanity build.

BUG= chromium:748171 
TEST=None

Change-Id: Icaa4f4272465a7df0165643ffa32c0d0c6d7deff
Reviewed-on: https://chromium-review.googlesource.com/592627
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/9ab36025c4cb3abda8292c433407b6c2e84b8a27/scripts/cbuildbot.py
[modify] https://crrev.com/9ab36025c4cb3abda8292c433407b6c2e84b8a27/lib/constants.py

review for the last CL in progress
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/48c66fa35d2a4d62784d911474dc0edd5b8aca62

commit 48c66fa35d2a4d62784d911474dc0edd5b8aca62
Author: Ningning Xia <nxia@chromium.org>
Date: Tue Aug 08 17:09:09 2017

Detect failed Pre-CQs and launch Sanity-Pre-CQs if needed.

In Pre-CQ-Launcher, before launching Pre-CQ tryjobs, check the statuses
of the previously completed Pre-CQs, launch Sanity-Pre-CQs if needed.

BUG= chromium:748171 
TEST=unit_tests

Change-Id: Ic49e9b916ed760ba2aeb3cf1d75a9a90a61b077b
Reviewed-on: https://chromium-review.googlesource.com/594939
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/48c66fa35d2a4d62784d911474dc0edd5b8aca62/lib/cidb.py
[modify] https://crrev.com/48c66fa35d2a4d62784d911474dc0edd5b8aca62/lib/fake_cidb.py
[modify] https://crrev.com/48c66fa35d2a4d62784d911474dc0edd5b8aca62/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/48c66fa35d2a4d62784d911474dc0edd5b8aca62/cbuildbot/stages/sync_stages.py
[modify] https://crrev.com/48c66fa35d2a4d62784d911474dc0edd5b8aca62/lib/cidb_integration_test.py

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/dbaa67add4e1e8fc0fb256fbe2ba4e1e0de4c411

commit dbaa67add4e1e8fc0fb256fbe2ba4e1e0de4c411
Author: Ningning Xia <nxia@chromium.org>
Date: Thu Aug 10 02:33:47 2017

Detect failed Pre-CQs and launch Sanity-Pre-CQs if needed.

In Pre-CQ-Launcher, before launching Pre-CQ tryjobs, check the statuses
of the previously completed Pre-CQs, launch Sanity-Pre-CQs if needed.

BUG= chromium:748171 
TEST=unit_tests;cidb_integration_test

Change-Id: Ia7357277e20328a556e3bf17fa5de1e7d2dd31a0
Reviewed-on: https://chromium-review.googlesource.com/607168
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/dbaa67add4e1e8fc0fb256fbe2ba4e1e0de4c411/lib/cidb.py
[modify] https://crrev.com/dbaa67add4e1e8fc0fb256fbe2ba4e1e0de4c411/lib/fake_cidb.py
[modify] https://crrev.com/dbaa67add4e1e8fc0fb256fbe2ba4e1e0de4c411/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/dbaa67add4e1e8fc0fb256fbe2ba4e1e0de4c411/cbuildbot/stages/sync_stages.py
[modify] https://crrev.com/dbaa67add4e1e8fc0fb256fbe2ba4e1e0de4c411/lib/cidb_integration_test.py

Status: Fixed (was: Assigned)
Alert enabled, no outages yet.
sanity builds counted at http://shortn/_2RjIES1q3a

none of them have failed yet...

Sign in to add a comment