Swarming CIPD pins display incorrectly on task page |
|||||
Issue descriptionExample https://chromium-swarm.appspot.com/task?id=378e714356da8a10&refresh=10&request_detail=true Renders as: cipd_bin_packages/ Requested: infra/git/${platform}:version:2.13.0.chromium9 Actual: infra/tools/luci/vpython/linux-amd64:03c7481b5cf7186db395e8f8ff8c3903ad1c86c1 cipd_bin_packages/ Requested: infra/tools/git/${platform}:git_revision:5cf65fdf804a9b3f3023f79d5b3cab2a88ccd09e Actual: infra/tools/luci/vpython/linux-amd64:03c7481b5cf7186db395e8f8ff8c3903ad1c86c1 ./ Requested: infra/tools/luci/kitchen/${platform}:git_revision:5cf65fdf804a9b3f3023f79d5b3cab2a88ccd09e Actual: infra/tools/luci/kitchen/linux-amd64:20f6f15c18a062ba668a02e6a70e33f73bf96bd8 cipd_bin_packages/ Requested: infra/tools/luci/vpython/${platform}:git_revision:5cf65fdf804a9b3f3023f79d5b3cab2a88ccd09e Actual: infra/tools/luci/vpython/linux-amd64:03c7481b5cf7186db395e8f8ff8c3903ad1c86c1 But it should render as: cipd_bin_packages/ Requested: infra/git/${platform}:version:2.13.0.chromium9 Actual: infra/git/linux-amd64:15010e417f11d99a8c495200ced14948bc78c7fd cipd_bin_packages/ Requested: infra/tools/git/${platform}:git_revision:5cf65fdf804a9b3f3023f79d5b3cab2a88ccd09e Actual: infra/tools/git/linux-amd64:47f86f2c8d4c31a4ee3b5fb57a80107a86fe0423 ./ Requested: infra/tools/luci/kitchen/${platform}:git_revision:5cf65fdf804a9b3f3023f79d5b3cab2a88ccd09e Actual: infra/tools/luci/kitchen/linux-amd64:20f6f15c18a062ba668a02e6a70e33f73bf96bd8 cipd_bin_packages/ Requested: infra/tools/luci/vpython/${platform}:git_revision:5cf65fdf804a9b3f3023f79d5b3cab2a88ccd09e Actual: infra/tools/luci/vpython/linux-amd64:03c7481b5cf7186db395e8f8ff8c3903ad1c86c1 Note that the API returns the correct data: https://apis-explorer.appspot.com/apis-explorer/?base=https://chromium-swarm.appspot.com/_ah/api#p/swarming/v1/swarming.task.result?task_id=378e714356da8a10&_h=2&, which means that run_isolated is correctly reporting this to the swarming service. This is fairly important to fix as it affects the debuggability of all swarming builds*. *that use cipd packages :)
,
Jul 25 2017
,
Jul 25 2017
,
Jul 25 2017
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/96051a6f3c07ec928b3a6bb292f27219dedac0bf commit 96051a6f3c07ec928b3a6bb292f27219dedac0bf Author: kjlubick <kjlubick@google.com> Date: Tue Jul 25 13:20:22 2017 Fix Actual CIPD versions Prior, this code was confusing "path" with "package_name" - the latter is unique, the former is not. BUG= 748167 Review-Url: https://codereview.chromium.org/2991653002 [modify] https://crrev.com/96051a6f3c07ec928b3a6bb292f27219dedac0bf/appengine/swarming/ui/build/elements.html [modify] https://crrev.com/96051a6f3c07ec928b3a6bb292f27219dedac0bf/appengine/swarming/ui/res/imp/taskpage/task-page.html
,
Jul 27 2017
This is live on chromium-swarm and chrome-swarming
,
Aug 4 2017
Issue 725251 has been merged into this issue.
,
Aug 4 2017
Awesome! Thanks :) |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by iannucci@chromium.org
, Jul 25 2017