New issue
Advanced search Search tips

Issue 748166 link

Starred by 2 users
Status: Fixed
Owner:
sebmarchand@chromium.org
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

dbgcore.dll should be made optional or the error message should be updated

Project Member Reported by brucedaw...@chromium.org, Jul 24 2017 
crrev.com/2964523003 added a dependency on dbgcore.dll but apparently this does not ship with the Anniversary Update SDK. If this file does not exist (but the other required DLLs do exist) then it is presumably not needed and can safely be omitted, so making it optional is one possible fix.

Another fix would be to change the error message to specify that the Creators Update SDK needs to be installed. That would imply making that SDK required which is not a terrible idea, and will have to happen eventually, but is a bit more disruptive.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71914fe37299192c5863d9503241e3e26cbef358

commit 71914fe37299192c5863d9503241e3e26cbef358
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri Aug 11 16:40:45 2017

Makes the copy of dbgcore.dll optional.

This DLL doesn't exist in the Anniversary Update SDK, so it's probably
fine to assume that it's not required by dbghelp.dll.

Bug:  748166 
Change-Id: Ic611fcde7114da4457f28fd735bf74ab9b9be6a6
Reviewed-on: https://chromium-review.googlesource.com/610307
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493773}
[modify] https://crrev.com/71914fe37299192c5863d9503241e3e26cbef358/build/vs_toolchain.py

Comment 2 by sebmarchand@chromium.org, Aug 11 2017

Status: Fixed (was: Assigned)

Comment 3 by marshall@chromium.org, Aug 11 2017 

Thanks for the fix! :)
►

Sign in to add a comment