New issue
Advanced search Search tips

Issue 748165 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Infer whether the PR was shown based on the events.

Project Member Reported by se...@chromium.org, Jul 24 2017

Issue description

currently, it is set only by calling SetShowCalled. Instead, it could be inferred in SetEventOccured when the event is either EVENT_SHOWN or EVENT_SKIPPED_SHOW.

It would have the side benefit of making the users record the events.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/677bd3e5a3f2d39a0acaca9cf9513f68a9b4d6b9

commit 677bd3e5a3f2d39a0acaca9cf9513f68a9b4d6b9
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Wed Jul 26 01:03:25 2017

[Payments] Infer if the PR was shown based on the events.

Previously, the way to set it was to call SetShowCalled directly.

Now, this value is inferred in SetEventOccured when the event is either
EVENT_SHOWN or EVENT_SKIPPED_SHOW.

It has the side benefit of forcing the users of JourneyLogger to set
the events.

Bug:  748165 
Change-Id: Id41d13bd72ce0bac4a37041846393d1ed602c166
Reviewed-on: https://chromium-review.googlesource.com/583847
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: mahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489504}
[modify] https://crrev.com/677bd3e5a3f2d39a0acaca9cf9513f68a9b4d6b9/chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java
[modify] https://crrev.com/677bd3e5a3f2d39a0acaca9cf9513f68a9b4d6b9/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/677bd3e5a3f2d39a0acaca9cf9513f68a9b4d6b9/chrome/browser/payments/android/journey_logger_android.cc
[modify] https://crrev.com/677bd3e5a3f2d39a0acaca9cf9513f68a9b4d6b9/chrome/browser/payments/android/journey_logger_android.h
[modify] https://crrev.com/677bd3e5a3f2d39a0acaca9cf9513f68a9b4d6b9/components/payments/content/payment_request.cc
[modify] https://crrev.com/677bd3e5a3f2d39a0acaca9cf9513f68a9b4d6b9/components/payments/core/journey_logger.cc
[modify] https://crrev.com/677bd3e5a3f2d39a0acaca9cf9513f68a9b4d6b9/components/payments/core/journey_logger.h
[modify] https://crrev.com/677bd3e5a3f2d39a0acaca9cf9513f68a9b4d6b9/components/payments/core/journey_logger_unittest.cc
[modify] https://crrev.com/677bd3e5a3f2d39a0acaca9cf9513f68a9b4d6b9/ios/chrome/browser/ui/payments/payment_request_manager.mm

Comment 2 by se...@chromium.org, Jul 26 2017

Status: Fixed (was: Started)

Sign in to add a comment