New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748160 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Clicking an active apps icon from the shelf with launcher active

Project Member Reported by newcomer@chromium.org, Jul 24 2017

Issue description

What steps will reproduce the problem?
(1) Open an app
(2) Open the launcher
(3) Click the active apps icon

What is the expected result?
The launcher should close and the app should be focused

What happens instead?
The launcher hides and the app hides.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e62a5c1da215f15c6a30612e44cce75fb977f26

commit 6e62a5c1da215f15c6a30612e44cce75fb977f26
Author: Alex Newcomer <newcomer@chromium.org>
Date: Tue Jul 25 23:08:55 2017

Clicking an active apps icon from the shelf

Click an active app's icon while the launcher is active should close the
launcher.

Fixes the behavior where a shown app is closed if the app icon is
selected while the launcher is being shown.

Bug:  748160 
Change-Id: I926d57bc9d040b412a07c761abaa927aab4b516d
Reviewed-on: https://chromium-review.googlesource.com/583641
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489475}
[modify] https://crrev.com/6e62a5c1da215f15c6a30612e44cce75fb977f26/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

Status: Fixed (was: Started)
Labels: Merge-Request-61
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 28 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 29 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8baffd3adf88d6c75c9f3250ed97017e0d7db0c3

commit 8baffd3adf88d6c75c9f3250ed97017e0d7db0c3
Author: Maajid <maajid@chromium.org>
Date: Sat Jul 29 01:20:21 2017

Clicking an active apps icon from the shelf

Click an active app's icon while the launcher is active should close the
launcher.

Fixes the behavior where a shown app is closed if the app icon is
selected while the launcher is being shown.

TBR=newcomer@chromium.org

(cherry picked from commit 6e62a5c1da215f15c6a30612e44cce75fb977f26)

Bug:  748160 
Change-Id: I926d57bc9d040b412a07c761abaa927aab4b516d
Reviewed-on: https://chromium-review.googlesource.com/583641
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489475}
Reviewed-on: https://chromium-review.googlesource.com/592712
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#132}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/8baffd3adf88d6c75c9f3250ed97017e0d7db0c3/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

Cc: mkarkada@chromium.org dhadd...@chromium.org
Status: Verified (was: Fixed)
Verified on Chrome OS 9765.13.0, 61.0.3163.20 (dev build).

Sign in to add a comment