Issue 748156 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ imch...@chromium.org Last visit > 30 days ago
Closed:	Aug 2017
Cc:	mfo...@chromium.org btolsch@chromium.org powerb@chromium.org
Components:	Blink>PresentationAPI
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug
Hotlist-Fixit-PE2017

[PresentationAPI] presentation_id should be required in ReconnectPresentation

Project Member Reported by imch...@chromium.org, Jul 24 2017

Issue description

Current API in presentation.mojom:

  ReconnectPresentation(array<url.mojom.Url> presentation_urls, string? presentation_id)
      => (PresentationInfo? presentation_info, PresentationError? error);

The presentation_id parameter should be "string" instead of "string?".

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71ede794f5fd117055ec1b9cf3865b6c19b9b0f5

commit 71ede794f5fd117055ec1b9cf3865b6c19b9b0f5
Author: Derek Cheng <imcheng@chromium.org>
Date: Thu Jul 27 07:58:16 2017

[Presentation API] Make presentation_id required in ReconectPresentation

Bug:  748156 
Change-Id: I0b033f01a3802f7a4e76a8d95e3449ec22106ed5
Reviewed-on: https://chromium-review.googlesource.com/583827
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489878}
[modify] https://crrev.com/71ede794f5fd117055ec1b9cf3865b6c19b9b0f5/content/browser/presentation/presentation_service_impl.cc
[modify] https://crrev.com/71ede794f5fd117055ec1b9cf3865b6c19b9b0f5/content/browser/presentation/presentation_service_impl.h
[modify] https://crrev.com/71ede794f5fd117055ec1b9cf3865b6c19b9b0f5/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/71ede794f5fd117055ec1b9cf3865b6c19b9b0f5/content/renderer/presentation/presentation_dispatcher_unittest.cc
[modify] https://crrev.com/71ede794f5fd117055ec1b9cf3865b6c19b9b0f5/third_party/WebKit/public/platform/modules/presentation/presentation.mojom

Comment 2 by imch...@chromium.org, Aug 21 2017

Status: Fixed (was: Started)

►

Issue 748156 link

Issue metadata

[PresentationAPI] presentation_id should be required in ReconnectPresentation

Issue description

Comment 1 by bugdroid1@chromium.org, Jul 27 2017

Comment 1 Deleted

Comment 2 by imch...@chromium.org, Aug 21 2017

Comment 2 Deleted

Sign in to add a comment