When Settings in a window was implemented there was discussion about implementing the feature in Desktop OSs as well. That never happened. We should remove the flags and make settings-in-a-window CrOS only.
Issue 734991 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c406dd217b51120318a17d05a64322a5875685d3 commit c406dd217b51120318a17d05a64322a5875685d3 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Jul 28 00:32:36 2017 Deprecate enable-settings-window and disable-settings-window flags Bug= 748152 Change-Id: I9b7f5b4fa4c4eb24a518049a492093be8e637c9d Reviewed-on: https://chromium-review.googlesource.com/583771 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#490161} [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/about_flags.cc [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/custom_home_pages_table_model.cc [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/notifications/notification_common.cc [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/ash/launcher/settings_window_observer.cc [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/ash/launcher/settings_window_observer.h [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/browser.cc [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/browser_navigator_browsertest.cc [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/browser_navigator_browsertest.h [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/browser_navigator_browsertest_chromeos.cc [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/chrome_pages.cc [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/chrome_pages.h [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc [rename] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/settings_window_manager_browsertest_chromeos.cc [rename] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/settings_window_manager_chromeos.cc [rename] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/settings_window_manager_chromeos.h [rename] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/settings_window_manager_observer_chromeos.h [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/browser/ui/webui/options/help_overlay_handler.cc [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/common/chrome_switches.cc [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/common/chrome_switches.h [modify] https://crrev.com/c406dd217b51120318a17d05a64322a5875685d3/chrome/test/BUILD.gn
9807.0.0, 62.0.3176.0
Comment 1 by steve...@chromium.org
, Jul 24 2017