New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748150 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Set discrete layout for all formats if > 8 channel

Project Member Reported by flim@chromium.org, Jul 24 2017

Issue description

If an input file is >8 channels, set it to discrete layout such that if WebAudio is attached, it is able to access all individual channels. If WebAudio is not attached, then rendering should fail.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c388c2369390f7524f080f727fa0b518a421e816

commit c388c2369390f7524f080f727fa0b518a421e816
Author: flim <flim@chromium.org>
Date: Thu Aug 10 05:36:42 2017

Set discrete layout for all formats if > 8 channel

If an input file is >8 channels, set it to discrete layout such that if a Web Audio renderer is attached, it is able to access all individual channels. If a Web Audio renderer is not attached, then rendering should fail.

Bug:  748150 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic37c6abd8a45be4b4949ad2c7e71cf0cfa3c63b6
Reviewed-on: https://chromium-review.googlesource.com/606678
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Felicia Lim <flim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493285}
[modify] https://crrev.com/c388c2369390f7524f080f727fa0b518a421e816/media/audio/clockless_audio_sink.cc
[modify] https://crrev.com/c388c2369390f7524f080f727fa0b518a421e816/media/audio/clockless_audio_sink.h
[modify] https://crrev.com/c388c2369390f7524f080f727fa0b518a421e816/media/ffmpeg/ffmpeg_common.cc
[modify] https://crrev.com/c388c2369390f7524f080f727fa0b518a421e816/media/ffmpeg/ffmpeg_common_unittest.cc
[modify] https://crrev.com/c388c2369390f7524f080f727fa0b518a421e816/media/formats/webm/webm_audio_client.cc
[modify] https://crrev.com/c388c2369390f7524f080f727fa0b518a421e816/media/renderers/audio_renderer_impl.cc
[add] https://crrev.com/c388c2369390f7524f080f727fa0b518a421e816/media/test/data/9ch.wav
[modify] https://crrev.com/c388c2369390f7524f080f727fa0b518a421e816/media/test/pipeline_integration_test.cc
[modify] https://crrev.com/c388c2369390f7524f080f727fa0b518a421e816/media/test/pipeline_integration_test_base.cc
[modify] https://crrev.com/c388c2369390f7524f080f727fa0b518a421e816/media/test/pipeline_integration_test_base.h

Comment 2 by flim@chromium.org, Aug 10 2017

Labels: M-62
Status: Fixed (was: Assigned)

Sign in to add a comment