New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 748144 link

Starred by 1 user
Status: Fixed
Owner:
█ ranj@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
pkotw...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Make shell_apk_version.gni presubmit non mandatory

Project Member Reported by pkotw...@chromium.org, Jul 24 2017 
In https://chromium-review.googlesource.com/c/575328/ Dominick pointed out that it is bad practice to land CLs with NO_PRESUBMIT=true. We should make the shell_apk_verison.gni presubmit optional

Comment 1 by hanxi@chromium.org, Jul 25 2017

Owner: ranj@chromium.org

Comment 2 by yfried...@chromium.org, Jul 25 2017 

I think we can add some scanning for text in the cl description like:
OVERRIDE_SHELL_APK_VERSION_CHECK=1
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34160a8c4e46429a8c9bb05db808b0f248e7a68d

commit 34160a8c4e46429a8c9bb05db808b0f248e7a68d
Author: Ran Ji <ranj@chromium.org>
Date: Fri Jul 28 15:13:01 2017

Change error to a warning when modify shell apk files without updating
shell_apk_version. A warning will not prevent submitting the code.

Bug:  748144 
Change-Id: I4f9be694b49c34272fcfc586db97da324adba47c
Reviewed-on: https://chromium-review.googlesource.com/585606
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Ran Ji <ranj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490392}
[modify] https://crrev.com/34160a8c4e46429a8c9bb05db808b0f248e7a68d/chrome/android/webapk/shell_apk/PRESUBMIT.py

Comment 4 by ranj@chromium.org, Jul 28 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment