V8 correctness failure in configs: x64,ignition:ia32,ignition |
||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=6495526450364416 Fuzzer: foozzie_js_mutation Job Type: v8_foozzie Platform Id: linux Crash Type: V8 correctness failure Crash Address: Crash State: configs: x64,ignition:ia32,ignition sources: ed5 Sanitizer: address (ASAN) Regressed: V8: 46837:46838 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6495526450364416 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Jul 25 2017
Issue 748302 has been merged into this issue.
,
Jul 25 2017
Issue 748365 has been merged into this issue.
,
Jul 25 2017
Issue 748422 has been merged into this issue.
,
Jul 25 2017
Issue 748423 has been merged into this issue.
,
Jul 25 2017
Issue 748468 has been merged into this issue.
,
Jul 25 2017
Yes it is intentional that they are different, and in the future we might increase the 64 bit limit even more so it would be good to be able to handle different max string lengths with the fuzzer. I suspect this issue will come up in a few different codepaths which deal with strings.
,
Jul 25 2017
Could we possibly just pass in the max string length as a flag to d8, in order to just limit it again for the fuzzer and make sure they are equal?
,
Jul 25 2017
Issue 748498 has been merged into this issue.
,
Jul 27 2017
Issue 748892 has been merged into this issue.
,
Jul 27 2017
Issue 748659 has been merged into this issue.
,
Jul 27 2017
Any update here how we can get rid of the noise? If we make intentional differences between ia32 and x64, then we can't compare for observable equality, unless we have a suppression mechanism. The noise this produces makes the system useless.
,
Jul 27 2017
,
Jul 27 2017
I'll work on crashing behind the --abort_on_stack_overflow flag in these cases, it seems to be the most reasonable thing. We could configure the length with a flag as suggested but I think this will be easier overall.
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/1a087f027f93862288cf75d35ab8755ea47c172f commit 1a087f027f93862288cf75d35ab8755ea47c172f Author: Peter Marshall <petermarshall@chromium.org> Date: Mon Jul 31 12:59:50 2017 [test] Crash on InvalidStringLength for correctness fuzzer. Now that the maximum string length varies between platforms, the correctness fuzzer is unhappy. It will ignore crashes, so when we know we have reached platform-dependant behavior just crash if --abort_on_stack_overflow is enabled. Also rename abort_on_stack_overflow to abort_on_stack_or_string_length_overflow. Bug: chromium:748137 Change-Id: Ie4e96709b90029b5ce3c8408064d928f841b3b9f Reviewed-on: https://chromium-review.googlesource.com/589269 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#47007} [modify] https://crrev.com/1a087f027f93862288cf75d35ab8755ea47c172f/src/compiler/js-intrinsic-lowering.cc [modify] https://crrev.com/1a087f027f93862288cf75d35ab8755ea47c172f/src/compiler/js-intrinsic-lowering.h [modify] https://crrev.com/1a087f027f93862288cf75d35ab8755ea47c172f/src/debug/debug-evaluate.cc [modify] https://crrev.com/1a087f027f93862288cf75d35ab8755ea47c172f/src/factory.cc [modify] https://crrev.com/1a087f027f93862288cf75d35ab8755ea47c172f/src/flag-definitions.h [modify] https://crrev.com/1a087f027f93862288cf75d35ab8755ea47c172f/src/isolate.cc [modify] https://crrev.com/1a087f027f93862288cf75d35ab8755ea47c172f/src/js/string.js [modify] https://crrev.com/1a087f027f93862288cf75d35ab8755ea47c172f/src/regexp/regexp-parser.cc [modify] https://crrev.com/1a087f027f93862288cf75d35ab8755ea47c172f/tools/foozzie/testdata/failure_output.txt [modify] https://crrev.com/1a087f027f93862288cf75d35ab8755ea47c172f/tools/foozzie/v8_foozzie.py
,
Jul 31 2017
Issue 750437 has been merged into this issue.
,
Aug 1 2017
machenbach@ this should be fixed now with the CL above, is there any way to check? Or just wait a few days and see if any more issues come up?
,
Aug 1 2017
ClusterFuzz has detected this issue as fixed in range 47006:47007. Detailed report: https://clusterfuzz.com/testcase?key=6495526450364416 Fuzzer: foozzie_js_mutation Job Type: v8_foozzie Platform Id: linux Crash Type: V8 correctness failure Crash Address: Crash State: configs: x64,ignition:ia32,ignition sources: ed5 Sanitizer: address (ASAN) Regressed: V8: 46837:46838 Fixed: V8: 47006:47007 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6495526450364416 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Aug 1 2017
Clustefuzz verifications mean it's now fixed
,
Aug 1 2017
Yes, thanks for fixing. CF also closed all the duplicates... |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by machenb...@chromium.org
, Jul 25 2017Labels: -Pri-1 Pri-2
Owner: petermarshall@chromium.org
Status: Assigned (was: Untriaged)