New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 748135 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Jul 2017
Cc:
justincohen@chromium.org
█ jif@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Pull to action no longer appears on NTP

Project Member Reported by pinkerton@chromium.org, Jul 24 2017 
M62.0.3165.0 canary, iPhone7, iOS10.3.x

- open a NTP
- pull down to reveal pull-to-action choices

expected:

- choices appear at top of screen (new tab, reload, close)

actual:

- no pull to action choices. 

This works in M61.0.3160.0 dev. If you explicitly disable the content suggestions, this works.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f253d737b7d9e9638471b94a1f8cc2048eed96e

commit 8f253d737b7d9e9638471b94a1f8cc2048eed96e
Author: gambard <gambard@chromium.org>
Date: Tue Jul 25 12:34:15 2017

Move prefetching control to viewDidLoad

Setting prefetchingEnabled in the init loads the view, as the property
is set on the view. If the view is loaded during the init, the
overscrollDelegate is not set yet, and the overscroll actions are not
triggered.
Moving it to viewDidLoad prevents loading the view before everything
is set.

Bug:  748135 
Change-Id: Ia19555d7d8d0c8d0c2890ca69e7e03854ac4504b
Reviewed-on: https://chromium-review.googlesource.com/584289
Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489279}
[modify] https://crrev.com/8f253d737b7d9e9638471b94a1f8cc2048eed96e/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Comment 2 by gambard@chromium.org, Jul 25 2017

Status: Fixed (was: Assigned)

Comment 3 by shbarezer@chromium.org, Aug 1 2017

Status: Verified (was: Fixed)
Verified in 62.0.3173.0 canary, iPhone 6 plus iOS 10.3.3
Pull to action is shown in NTP.

Looks good.
►

Sign in to add a comment