New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 748109 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 882382



Sign in to add a comment

JavaScript "ADD SITE EXCEPTION" only present when JavaScript is blocked by default

Project Member Reported by dobrota@google.com, Jul 24 2017

Issue description

Steps to reproduce the problem:
1. Navigate to Settings -> Site Settings -> JavaScript

What is the expected behavior?
See the "ADD SITE EXCEPTION" button and click on it to add a site in the "Block" state, while keeping the default as "Allow".

What went wrong?
The "ADD SITE EXCEPTION" button is not visible and a hacky workaround needs to be employed to have "Allow" as default with some exceptions in "Block".

Did this work before? N/A 

Chrome version: 59.0.3071.125  Channel: stable
OS Version: 7.1.2
Flash Version: 

The workaround is:
1) Switch the default to "Block"
2) Add an exception. It's automatically added as "Allow".
3) Switch the exception to "Block".
4) Switch the default back to "Allow".
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 25 2017

Labels: Hotlist-Google

Comment 2 by battre@chromium.org, Jul 26 2017

Components: Privacy
Cc: dullweber@chromium.org raymes@chromium.org
Components: UI>Browser>SiteSettings
Labels: Team-Security-UX
Status: Available (was: Unconfirmed)
This is related to issue 468586 and issue 729539 - broken site settings UI on Android, just another content setting type in this case.

Comment 4 by raymes@chromium.org, Jul 26 2017

I actually think it was originally designed like this intentionally, though I agree with the bug and I don't think it should be limited in this way.

Comment 5 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 6 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt
Blocking: 882382
Owner: hkamila@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2727fe47bd8a939f4de2bf0c5478fc7aaf65ba4b

commit 2727fe47bd8a939f4de2bf0c5478fc7aaf65ba4b
Author: Kamila <hkamila@google.com>
Date: Mon Oct 15 09:28:06 2018

Allow adding JS exceptions when JS is allowed by default (behind flag)

Allow adding exceptions of blocked sites, with ADD SITE EXCEPTIONS button, when
JS is allowed by default.

Currently, adding exceptions is only possible when JS is blocked by default.

Bug:  748109 
Change-Id: I215366ce1596f00bba46b6a5896afcf1d2b902ba
Reviewed-on: https://chromium-review.googlesource.com/c/1261518
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Cr-Commit-Position: refs/heads/master@{#599597}
[modify] https://crrev.com/2727fe47bd8a939f4de2bf0c5478fc7aaf65ba4b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
[modify] https://crrev.com/2727fe47bd8a939f4de2bf0c5478fc7aaf65ba4b/chrome/android/java/strings/android_chrome_strings.grd

Status: Fixed (was: Available)

Sign in to add a comment