Issue metadata
Sign in to add a comment
|
Gamma shift occurs when GPU acceleration is enabled
Reported by
sethgol...@gmail.com,
Jul 24 2017
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36 Example URL: https://youtu.be/K5WQzgRYnZ0 Steps to reproduce the problem: 1. Have GPU acceleration enabled 2. View an HTML5 video What is the expected behavior? Gamma should display correctly. What went wrong? Gamma is shifted so that the levels are improperly lifted up. The black levels are too high. Did this work before? N/A Is it a problem with Flash or HTML5? HTML5 Does this work in other browsers? Yes Chrome version: 59.0.3071.115 Channel: stable OS Version: OS X 10.12.5 Flash Version: Contents of chrome://gpu: Graphics Feature Status Canvas: Software only, hardware acceleration unavailable Flash: Software only, hardware acceleration unavailable Flash Stage3D: Software only, hardware acceleration unavailable Flash Stage3D Baseline profile: Software only, hardware acceleration unavailable Compositing: Software only, hardware acceleration unavailable Multiple Raster Threads: Unavailable Native GpuMemoryBuffers: Software only, hardware acceleration unavailable Rasterization: Software only. Hardware acceleration disabled Video Decode: Software only, hardware acceleration unavailable Video Encode: Software only, hardware acceleration unavailable WebGL: Unavailable WebGL2: Unavailable Driver Bug Workarounds adjust_src_dst_region_for_blitframebuffer decode_encode_srgb_for_generatemipmap disable_framebuffer_cmaa disable_multimonitor_multisampling get_frag_data_info_bug pack_parameters_workaround_with_pack_buffer regenerate_struct_names remove_invariant_and_centroid_for_essl3 scalarize_vec_and_mat_constructor_args set_zero_level_before_generating_mipmap unfold_short_circuit_as_ternary_operation unpack_alignment_workaround_with_unpack_buffer use_intermediary_for_copy_texture_image use_unused_standard_shared_blocks Problems Detected GPU process was unable to boot: GPU access is disabled in chrome://settings. Disabled Features: all Multisampling is buggy on OSX when multiple monitors are connected: 237931 Applied Workarounds: disable_multimonitor_multisampling Unfold short circuit on Mac OS X: 307751 Applied Workarounds: unfold_short_circuit_as_ternary_operation Always rewrite vec/mat constructors to be consistent: 398694 Applied Workarounds: scalarize_vec_and_mat_constructor_args Mac drivers handle struct scopes incorrectly: 403957 Applied Workarounds: regenerate_struct_names glGenerateMipmap fails if the zero texture level is not set on some Mac drivers: 560499 Applied Workarounds: set_zero_level_before_generating_mipmap Pack parameters work incorrectly with pack buffer bound: 563714 Applied Workarounds: pack_parameters_workaround_with_pack_buffer Alignment works incorrectly with unpack buffer bound: 563714 Applied Workarounds: unpack_alignment_workaround_with_unpack_buffer copyTexImage2D fails when reading from IOSurface on multiple GPU types.: 581777 Applied Workarounds: use_intermediary_for_copy_texture_image Limited enabling of Chromium GL_INTEL_framebuffer_CMAA: 535198 Applied Workarounds: disable_framebuffer_cmaa glGetFragData{Location|Index} works incorrectly on Max: 638340 Applied Workarounds: get_frag_data_info_bug Decode and encode before generateMipmap for srgb format textures on macosx: 634519 Applied Workarounds: decode_encode_srgb_for_generatemipmap Insert statements to reference all members in unused std140/shared blocks on Mac: 618464 Applied Workarounds: use_unused_standard_shared_blocks adjust src/dst region if blitting pixels outside read framebuffer on Mac: 644740 Applied Workarounds: adjust_src_dst_region_for_blitframebuffer Mac driver GL 4.1 requires invariant and centroid to match between shaders: 639760, 641129 Applied Workarounds: remove_invariant_and_centroid_for_essl3 Disable KHR_blend_equation_advanced until cc shaders are updated: 661715 Accelerated rasterization has been disabled, either via blacklist, about:flags or the command line. Disabled Features: rasterization Version Information Data exported 7/24/2017, 12:44:02 PM Chrome version Chrome/59.0.3071.115 Operating system Mac OS X 10.12.5 Software rendering list version 13.8 Driver bug list version 10.102 ANGLE commit id a9042d3c1952 2D graphics backend Skia/59 ef6f9c65527412ec4057ea0551f2e051beb94d32 Command Line Args Chrome.app/Contents/MacOS/Google Chrome -psn_0_741557 --restore-last-session --flag-switches-begin --flag-switches-end Driver Information Initialization time 0 In-process GPU true Passthrough Command Decoder false Supports overlays false Sandboxed false GPU0 VENDOR = 0x1002, DEVICE= 0x6821 *ACTIVE* GPU1 VENDOR = 0x8086, DEVICE= 0x0d26 Optimus false Optimus false AMD switchable true Driver vendor Driver version Driver date Pixel shader version Vertex shader version Max. MSAA samples Machine model name MacBookPro Machine model version 11.5 GL_VENDOR GL_RENDERER GL_VERSION GL_EXTENSIONS Disabled Extensions GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent Window system binding vendor Window system binding version Window system binding extensions Direct rendering Yes Reset notification strategy 0x0000 GPU process crash count 0 Compositor Information Tile Update Mode Zero-copy Partial Raster Enabled GpuMemoryBuffers Status ATC Software only ATCIA Software only DXT1 Software only DXT5 Software only ETC1 Software only R_8 GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT RG_88 Software only BGR_565 Software only RGBA_4444 Software only RGBX_8888 Software only RGBA_8888 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE BGRX_8888 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE BGRA_8888 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT RGBA_F16 GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT YVU_420 Software only YUV_420_BIPLANAR GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT UYVY_422 GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT As per Rochelle's recommendation in the Google Chrome Help Forum, I'm starting a public bug. https://productforums.google.com/d/msg/chrome/-FxOCYv_RfU/L_kjKjo9AgAJ N.B. I had hardware acceleration disabled when I pasted in the chrome://gpu information, but I can enable it and send the information if it's helpful.
,
Jul 24 2017
,
Jul 24 2017
,
Jul 24 2017
Can you re-try this on Chrome Canary? I suspect that the issue is that out VP9 decoder historically did not specify a color profile for its IOSurfaces. We specify a space now in M61.
,
Jul 25 2017
I will try in Canary--meanwhile, in the stable release of 59.0.3071.115 (Official Build) (64-bit), here's my `chrome://gpu` information.
Graphics Feature Status
Canvas: Hardware accelerated
Flash: Hardware accelerated
Flash Stage3D: Hardware accelerated
Flash Stage3D Baseline profile: Hardware accelerated
Compositing: Hardware accelerated
Multiple Raster Threads: Enabled
Native GpuMemoryBuffers: Hardware accelerated
Rasterization: Hardware accelerated
Video Decode: Hardware accelerated
Video Encode: Hardware accelerated
WebGL: Hardware accelerated
WebGL2: Hardware accelerated
Driver Bug Workarounds
adjust_src_dst_region_for_blitframebuffer
decode_encode_srgb_for_generatemipmap
disable_framebuffer_cmaa
disable_multimonitor_multisampling
get_frag_data_info_bug
pack_parameters_workaround_with_pack_buffer
regenerate_struct_names
remove_invariant_and_centroid_for_essl3
scalarize_vec_and_mat_constructor_args
set_zero_level_before_generating_mipmap
unfold_short_circuit_as_ternary_operation
unpack_alignment_workaround_with_unpack_buffer
use_intermediary_for_copy_texture_image
use_unused_standard_shared_blocks
Problems Detected
Multisampling is buggy on OSX when multiple monitors are connected: 237931
Applied Workarounds: disable_multimonitor_multisampling
Unfold short circuit on Mac OS X: 307751
Applied Workarounds: unfold_short_circuit_as_ternary_operation
Always rewrite vec/mat constructors to be consistent: 398694
Applied Workarounds: scalarize_vec_and_mat_constructor_args
Mac drivers handle struct scopes incorrectly: 403957
Applied Workarounds: regenerate_struct_names
glGenerateMipmap fails if the zero texture level is not set on some Mac drivers: 560499
Applied Workarounds: set_zero_level_before_generating_mipmap
Pack parameters work incorrectly with pack buffer bound: 563714
Applied Workarounds: pack_parameters_workaround_with_pack_buffer
Alignment works incorrectly with unpack buffer bound: 563714
Applied Workarounds: unpack_alignment_workaround_with_unpack_buffer
copyTexImage2D fails when reading from IOSurface on multiple GPU types.: 581777
Applied Workarounds: use_intermediary_for_copy_texture_image
Limited enabling of Chromium GL_INTEL_framebuffer_CMAA: 535198
Applied Workarounds: disable_framebuffer_cmaa
glGetFragData{Location|Index} works incorrectly on Max: 638340
Applied Workarounds: get_frag_data_info_bug
Decode and encode before generateMipmap for srgb format textures on macosx: 634519
Applied Workarounds: decode_encode_srgb_for_generatemipmap
Insert statements to reference all members in unused std140/shared blocks on Mac: 618464
Applied Workarounds: use_unused_standard_shared_blocks
adjust src/dst region if blitting pixels outside read framebuffer on Mac: 644740
Applied Workarounds: adjust_src_dst_region_for_blitframebuffer
Mac driver GL 4.1 requires invariant and centroid to match between shaders: 639760, 641129
Applied Workarounds: remove_invariant_and_centroid_for_essl3
Disable KHR_blend_equation_advanced until cc shaders are updated: 661715
Version Information
Data exported 7/25/2017, 10:06:57 AM
Chrome version Chrome/59.0.3071.115
Operating system Mac OS X 10.12.5
Software rendering list version 13.8
Driver bug list version 10.102
ANGLE commit id a9042d3c1952
2D graphics backend Skia/59 ef6f9c65527412ec4057ea0551f2e051beb94d32
Command Line Args Chrome.app/Contents/MacOS/Google Chrome --flag-switches-begin --flag-switches-end
Driver Information
Initialization time 70
In-process GPU false
Passthrough Command Decoder false
Supports overlays false
Sandboxed true
GPU0 VENDOR = 0x1002, DEVICE= 0x6821 *ACTIVE*
GPU1 VENDOR = 0x8086, DEVICE= 0x0d26
Optimus false
Optimus false
AMD switchable true
Driver vendor
Driver version 1.51.8
Driver date
Pixel shader version 4.10
Vertex shader version 4.10
Max. MSAA samples 8
Machine model name MacBookPro
Machine model version 11.5
GL_VENDOR ATI Technologies Inc.
GL_RENDERER AMD Radeon R9 M370X OpenGL Engine
GL_VERSION 4.1 ATI-1.51.8
GL_EXTENSIONS GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_depth_bounds_test GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_mirror_clamp GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier
Disabled Extensions GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent
Window system binding vendor
Window system binding version
Window system binding extensions
Direct rendering Yes
Reset notification strategy 0x0000
GPU process crash count 0
Compositor Information
Tile Update Mode Zero-copy
Partial Raster Enabled
GpuMemoryBuffers Status
ATC Software only
ATCIA Software only
DXT1 Software only
DXT5 Software only
ETC1 Software only
R_8 GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
RG_88 Software only
BGR_565 Software only
RGBA_4444 Software only
RGBX_8888 Software only
RGBA_8888 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE
BGRX_8888 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE
BGRA_8888 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
RGBA_F16 GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
YVU_420 Software only
YUV_420_BIPLANAR GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
UYVY_422 GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
,
Jul 25 2017
Thank you for providing more feedback. Adding requester "pbommana@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 25 2017
Good news, the problem appears to be resolved in Version 62.0.3166.0 (Official Build) canary (64-bit). Thanks!
,
Jul 25 2017
,
Jul 26 2017
No such luck for me. In fact now the video thumbnails on Vimeo and YouTube also have raised gamma and look as wrong as the video. There's a sort of flickering overlay that shows up thumbnails, similar to an issue that was resolved a long time ago.
Here's my GPU info from Canary: You can see there are some errors logged at the bottom.
Graphics Feature Status
Canvas: Hardware accelerated
Flash: Hardware accelerated
Flash Stage3D: Hardware accelerated
Flash Stage3D Baseline profile: Hardware accelerated
Compositing: Hardware accelerated
Multiple Raster Threads: Enabled
Native GpuMemoryBuffers: Hardware accelerated
Rasterization: Hardware accelerated
Video Decode: Hardware accelerated
Video Encode: Hardware accelerated
WebGL: Hardware accelerated
WebGL2: Hardware accelerated
Driver Bug Workarounds
adjust_src_dst_region_for_blitframebuffer
decode_encode_srgb_for_generatemipmap
disable_framebuffer_cmaa
disable_multimonitor_multisampling
get_frag_data_info_bug
pack_parameters_workaround_with_pack_buffer
regenerate_struct_names
remove_invariant_and_centroid_for_essl3
scalarize_vec_and_mat_constructor_args
set_zero_level_before_generating_mipmap
unfold_short_circuit_as_ternary_operation
unpack_alignment_workaround_with_unpack_buffer
use_intermediary_for_copy_texture_image
use_unused_standard_shared_blocks
Problems Detected
Multisampling is buggy on OSX when multiple monitors are connected: 237931
Applied Workarounds: disable_multimonitor_multisampling
Unfold short circuit on Mac OS X: 307751
Applied Workarounds: unfold_short_circuit_as_ternary_operation
Always rewrite vec/mat constructors to be consistent: 398694
Applied Workarounds: scalarize_vec_and_mat_constructor_args
Mac drivers handle struct scopes incorrectly: 403957
Applied Workarounds: regenerate_struct_names
glGenerateMipmap fails if the zero texture level is not set on some Mac drivers: 560499
Applied Workarounds: set_zero_level_before_generating_mipmap
Pack parameters work incorrectly with pack buffer bound: 563714
Applied Workarounds: pack_parameters_workaround_with_pack_buffer
Alignment works incorrectly with unpack buffer bound: 563714
Applied Workarounds: unpack_alignment_workaround_with_unpack_buffer
copyTexImage2D fails when reading from IOSurface on multiple GPU types.: 581777
Applied Workarounds: use_intermediary_for_copy_texture_image
Limited enabling of Chromium GL_INTEL_framebuffer_CMAA: 535198
Applied Workarounds: disable_framebuffer_cmaa
glGetFragData{Location|Index} works incorrectly on Max: 638340
Applied Workarounds: get_frag_data_info_bug
Decode and encode before generateMipmap for srgb format textures on macosx: 634519
Applied Workarounds: decode_encode_srgb_for_generatemipmap
Insert statements to reference all members in unused std140/shared blocks on Mac: 618464
Applied Workarounds: use_unused_standard_shared_blocks
adjust src/dst region if blitting pixels outside read framebuffer on Mac: 644740
Applied Workarounds: adjust_src_dst_region_for_blitframebuffer
Mac driver GL 4.1 requires invariant and centroid to match between shaders: 639760, 641129
Applied Workarounds: remove_invariant_and_centroid_for_essl3
Disable KHR_blend_equation_advanced until cc shaders are updated: 661715
Version Information
Data exported 26/07/2017, 15:24:54
Chrome version Chrome/59.0.3071.115
Operating system Mac OS X 10.12.5
Software rendering list version 13.8
Driver bug list version 10.102
ANGLE commit id a9042d3c1952
2D graphics backend Skia/59 ef6f9c65527412ec4057ea0551f2e051beb94d32
Command Line Args Chrome.app/Contents/MacOS/Google Chrome --flag-switches-begin --flag-switches-end
Driver Information
Initialization time 85
In-process GPU false
Passthrough Command Decoder false
Supports overlays false
Sandboxed true
GPU0 VENDOR = 0x1002, DEVICE= 0x6810 *ACTIVE*
GPU1 VENDOR = 0x1002, DEVICE= 0x6810
Optimus false
Optimus false
AMD switchable false
Driver vendor
Driver version 1.51.8
Driver date
Pixel shader version 4.10
Vertex shader version 4.10
Max. MSAA samples 8
Machine model name MacPro
Machine model version 6.1
GL_VENDOR ATI Technologies Inc.
GL_RENDERER AMD Radeon HD - FirePro D300 OpenGL Engine
GL_VERSION 4.1 ATI-1.51.8
GL_EXTENSIONS GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_depth_bounds_test GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_mirror_clamp GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier
Disabled Extensions GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent
Window system binding vendor
Window system binding version
Window system binding extensions
Direct rendering Yes
Reset notification strategy 0x0000
GPU process crash count 0
Compositor Information
Tile Update Mode Zero-copy
Partial Raster Enabled
GpuMemoryBuffers Status
ATC Software only
ATCIA Software only
DXT1 Software only
DXT5 Software only
ETC1 Software only
R_8 GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
RG_88 Software only
BGR_565 Software only
RGBA_4444 Software only
RGBX_8888 Software only
RGBA_8888 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE
BGRX_8888 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE
BGRA_8888 GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
RGBA_F16 GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
YVU_420 Software only
YUV_420_BIPLANAR GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
UYVY_422 GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
Log Messages
[760:775:0726/152453.567166:ERROR:gpu_video_decode_accelerator.cc(376)] : HW video decode not available for profile h264 main
,
Aug 16 2017
I tried opening the link suggested at https://bugs.chromium.org/p/chromium/issues/detail?id=713889#c30, https://youtu.be/K5WQzgRYnZ0 The colors of the video are the same in Chrome and Safari (see attached picture). This is using my local system profile. Are you expecting the colors to match those of an sRGB monitor? If so, you will need to set your monitor to have an sRGB color profile in system settings.
,
Aug 16 2017
I think this bug might be specific to this particular GPU on macOS, and perhaps all NVIDIA GPUs on macOS. System specs which are producing the bug: Chrome 60.0.3112.90 (Official Build) (64-bit) macOS Sierra 10.12.6 (16G29) NVIDIA GeForce GTX TITAN X 12288 MB NVIDIA Web Driver 378.05.05.25f01 CUDA Driver Version: 8.0.90 The color profile is set to HD 709-A, which has a gamma of 2.4. sRGB has a native gamma of 2.2. See the attached screenshots. In both screenshots, Safari's on the right and Chrome's on the left. Here's an explanation of the PLUGE: https://www.videouniversity.com/articles/color-bars-and-how-to-use-em/ As you can see from my screenshots, when Chrome's hardware acceleration is enabled, the 11.5 and 3.5 bars are milky and lifted, but when when Chrome's hardware acceleration is disabled, they're properly dark, the same as Safari. For what it's worth, I tested Chrome with hardware acceleration enabled on a totally different system with a different GPU, and it was rendering levels properly: macOS Sierra 10.12.6 (16G29) Chrome 60.0.3112.101 (Official Build) (64-bit) AMD Radeon R9 M370X 2048 MB Intel Iris Pro 1536 MB HD 709-A Can you test on a system with the NVIDIA GPU and drivers?
,
Aug 16 2017
Thanks -- figured this out. Couple of issues: - This wasn't reproducing for me because this layer was being promoted to an overlay (for low power). Not sure why you weren't in overlay mode -- you always want to be in that mode. But ... non-overlay mode needs to work too! - This resource is not being tagged with a color space! It's hitting the place where hubbe@ keeps telling me to put a DCHECK in ColorTransformInternal::ColorTransformInternal (I put a TODO -- it's almost as good as a DCHECK, right?). This quad is being generated in VideoLayerImpl::AppendQuads through the VideoFrameExternalResources::RGBA_RESOURCE case. Now I need to hunt down where that texture resource is being created.
,
Aug 16 2017
Great thanks! Glad to see it's on its way to getting resolved.
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf7445cbca7f05ad78e941c2f8e04ea9175f97fa commit bf7445cbca7f05ad78e941c2f8e04ea9175f97fa Author: Christopher Cameron <ccameron@chromium.org> Date: Fri Aug 25 20:11:42 2017 Specify color space to YUVToRGBConverter The YUVToRGBConverter is responsible for converting YUV 420 biplanar IOSurfaces into something that GL can texture out of. This needs to be aware of which color space's YUV to RGB conversion is to be done. The values for Rec. 601 were hard-coded into the shader. Use the color transform shader generation code to do this. Hook up the VTVideoDecodeAcceleratorMac to specify the decoded color space. Set the default value for color space in GLImageIOSurface to be Rec. 601, so that, in the case that no color space is specified, the behavior will remain unchanged. When examining the generated shader source, it was noted that the YUV to RGB conversion had unexpected to-linear-then-from-linear steps. This was because our optimizations for eliding some transfer function pairs was working against us. Make this optimization more precise (only replace the src transfer function when it will match the dst transfer function), and add a unit test for this. R=hubbe TBR=zmo (for gpu/) Bug: 748076 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I120440fe2e78d44fb1561028e0f9282b2ccaf6c1 Reviewed-on: https://chromium-review.googlesource.com/634162 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#497513} [modify] https://crrev.com/bf7445cbca7f05ad78e941c2f8e04ea9175f97fa/gpu/command_buffer/service/gl_context_virtual.cc [modify] https://crrev.com/bf7445cbca7f05ad78e941c2f8e04ea9175f97fa/gpu/command_buffer/service/gl_context_virtual.h [modify] https://crrev.com/bf7445cbca7f05ad78e941c2f8e04ea9175f97fa/media/gpu/vt_video_decode_accelerator_mac.cc [modify] https://crrev.com/bf7445cbca7f05ad78e941c2f8e04ea9175f97fa/ui/gfx/color_transform.cc [modify] https://crrev.com/bf7445cbca7f05ad78e941c2f8e04ea9175f97fa/ui/gfx/color_transform_unittest.cc [modify] https://crrev.com/bf7445cbca7f05ad78e941c2f8e04ea9175f97fa/ui/gl/gl_context.cc [modify] https://crrev.com/bf7445cbca7f05ad78e941c2f8e04ea9175f97fa/ui/gl/gl_context.h [modify] https://crrev.com/bf7445cbca7f05ad78e941c2f8e04ea9175f97fa/ui/gl/gl_context_cgl.cc [modify] https://crrev.com/bf7445cbca7f05ad78e941c2f8e04ea9175f97fa/ui/gl/gl_context_cgl.h [modify] https://crrev.com/bf7445cbca7f05ad78e941c2f8e04ea9175f97fa/ui/gl/gl_image_io_surface.h [modify] https://crrev.com/bf7445cbca7f05ad78e941c2f8e04ea9175f97fa/ui/gl/gl_image_io_surface.mm [modify] https://crrev.com/bf7445cbca7f05ad78e941c2f8e04ea9175f97fa/ui/gl/gl_image_io_surface_unittest.cc [modify] https://crrev.com/bf7445cbca7f05ad78e941c2f8e04ea9175f97fa/ui/gl/yuv_to_rgb_converter.cc [modify] https://crrev.com/bf7445cbca7f05ad78e941c2f8e04ea9175f97fa/ui/gl/yuv_to_rgb_converter.h
,
Oct 10 2017
Just checking back in on this and I'm finding video is looking perfect on the latest Canary Version 63.0.3236.0. It's still wrong on Chrome Version 61.0.3163.100. Looks like it's being solved and this is great news. Hope to see it rolled out in Chrome soon. Thanks everyone!
,
Oct 23 2017
Hi guys, just wanted to add that I also still have this issue in Chrome 61.0.3163.100. I don't have the problem in Chrome Camary Version 64.0.3247.0 (Official Build) canary (64-bit) - I'm on a MacPro, High Sierra 10.13 with D700 cards. Thanks!
,
Oct 23 2017
Re #16, please file a new bug, I suspect your issue is different than this one.
,
Oct 30 2017
It seems that this bug is not limited to just video but also includes certain types of image files. I'm on 62.0.3202.75 (Windows 10) and this bug wasn't present some days ago. You can visit http://www.lagom.nl/lcd-test/black.php and http://www.lagom.nl/lcd-test/gradient.php (with and without hardware acceleration enabled) to reproduce the issue. I did some screenshots, too: The first two have hw acc enabled, the last two hw acc disabled (with correct black levels).
,
Oct 30 2017
And here's my output of chrome://gpu: Graphics Feature Status Canvas: Hardware accelerated CheckerImaging: Disabled Flash: Hardware accelerated Flash Stage3D: Hardware accelerated Flash Stage3D Baseline profile: Hardware accelerated Compositing: Hardware accelerated Multiple Raster Threads: Enabled Native GpuMemoryBuffers: Software only. Hardware acceleration disabled Rasterization: Hardware accelerated Video Decode: Hardware accelerated Video Encode: Hardware accelerated WebGL: Hardware accelerated WebGL2: Hardware accelerated Driver Bug Workarounds clear_uniforms_before_first_program_use decode_encode_srgb_for_generatemipmap disable_delayed_copy_nv12 disable_discard_framebuffer disable_dxgi_zero_copy_video disable_framebuffer_cmaa exit_on_context_lost force_cube_complete scalarize_vec_and_mat_constructor_args texsubimage_faster_than_teximage Problems Detected Some drivers are unable to reset the D3D device in the GPU process sandbox Applied Workarounds: exit_on_context_lost TexSubImage is faster for full uploads on ANGLE Applied Workarounds: texsubimage_faster_than_teximage Clear uniforms before first program use on all platforms: 124764, 349137 Applied Workarounds: clear_uniforms_before_first_program_use Always rewrite vec/mat constructors to be consistent: 398694 Applied Workarounds: scalarize_vec_and_mat_constructor_args ANGLE crash on glReadPixels from incomplete cube map texture: 518889 Applied Workarounds: force_cube_complete Framebuffer discarding can hurt performance on non-tilers: 570897 Applied Workarounds: disable_discard_framebuffer Limited enabling of Chromium GL_INTEL_framebuffer_CMAA: 535198 Applied Workarounds: disable_framebuffer_cmaa Zero-copy NV12 video displays incorrect colors on NVIDIA drivers.: 635319 Applied Workarounds: disable_dxgi_zero_copy_video Disable KHR_blend_equation_advanced until cc shaders are updated: 661715 Applied Workarounds: disable(GL_KHR_blend_equation_advanced), disable(GL_KHR_blend_equation_advanced_coherent) Decode and Encode before generateMipmap for srgb format textures on Windows: 634519 Applied Workarounds: decode_encode_srgb_for_generatemipmap Delayed copy NV12 displays incorrect colors on NVIDIA drivers.: 728670 Applied Workarounds: disable_delayed_copy_nv12 Native GpuMemoryBuffers have been disabled, either via about:flags or command line. Disabled Features: native_gpu_memory_buffers Checker-imaging has been disabled via finch trial or the command line. Disabled Features: checker_imaging Version Information Data exported 30.10.2017, 10:36:03 Chrome version Chrome/62.0.3202.75 Operating system Windows NT 10.0.16299 Software rendering list version 13.13 Driver bug list version 10.30 ANGLE commit id e8ef2bc4bd01 2D graphics backend Skia/62 e74b41c6c84638d5a9ee6d254a715bcd9e17c603- Command Line "C:\Program Files (x86)\Google\Chrome\Application\chrome.exe" --enable-monitor-profile --flag-switches-begin --flag-switches-end Driver Information Initialization time 150 In-process GPU false Passthrough Command Decoder false Supports overlays false Sandboxed false GPU0 VENDOR = 0x10de, DEVICE= 0x1b80 Optimus false Optimus false AMD switchable false Desktop compositing Aero Glass Diagonal Monitor Size of \\.\DISPLAY1 27.0" Driver vendor NVIDIA Driver version 23.21.13.8800 Driver date 10-12-2017 Pixel shader version 5.0 Vertex shader version 5.0 Max. MSAA samples 8 Machine model name Machine model version GL_VENDOR Google Inc. GL_RENDERER ANGLE (NVIDIA GeForce GTX 1080 Direct3D11 vs_5_0 ps_5_0) GL_VERSION OpenGL ES 3.0 (ANGLE 2.1.0.e8ef2bc4bd01) GL_EXTENSIONS GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_multiview GL_ANGLE_pack_reverse_row_order GL_ANGLE_program_cache_control GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_robust_resource_initialization GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_float GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_norm16 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_surfaceless_context GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object Disabled Extensions GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent Window system binding vendor Google Inc. (adapter LUID: 0000000000005daa) Window system binding version 1.4 (ANGLE 2.1.0.e8ef2bc4bd01) Window system binding extensions EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture_nv12 EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_CHROMIUM_sync_control EGL_EXT_pixel_format_float EGL_KHR_surfaceless_context EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_program_cache_control Direct rendering Yes Reset notification strategy 0x8252 GPU process crash count 0 Compositor Information Tile Update Mode One-copy Partial Raster Enabled GpuMemoryBuffers Status ATC Software only ATCIA Software only DXT1 Software only DXT5 Software only ETC1 Software only R_8 Software only R_16 Software only RG_88 Software only BGR_565 Software only RGBA_4444 Software only RGBX_8888 Software only RGBA_8888 Software only BGRX_8888 Software only BGRA_8888 Software only RGBA_F16 Software only YVU_420 Software only YUV_420_BIPLANAR Software only UYVY_422 Software only Diagnostics 0 b3DAccelerationEnabled true b3DAccelerationExists true bAGPEnabled true bAGPExistenceValid true bAGPExists true bCanRenderWindow true bDDAccelerationEnabled true bDriverBeta false bDriverDebug false bDriverSigned false bDriverSignedValid false bNoHardware false dwBpp 32 dwDDIVersion 12 dwHeight 1440 dwRefreshRate 120 dwWHQLLevel 0 dwWidth 2560 iAdapter 0 lDriverSize 927976 lMiniVddSize 0 szAGPStatusEnglish Enabled szAGPStatusLocalized Aktiviert szChipType GeForce GTX 1080 szD3DStatusEnglish Enabled szD3DStatusLocalized Aktiviert szDACType Integrated RAMDAC szDDIVersionEnglish 12 szDDIVersionLocalized 12 szDDStatusEnglish Enabled szDDStatusLocalized Aktiviert szDXVAHDEnglish Supported szDXVAModes szDescription NVIDIA GeForce GTX 1080 szDeviceId 0x1B80 szDeviceIdentifier {D7B71E3E-58C0-11CF-B255-6B131BC2DA35} szDeviceName \\.\DISPLAY1 szDisplayMemoryEnglish 16248 MB szDisplayMemoryLocalized 16248 MB szDisplayModeEnglish 2560 x 1440 (32 bit) (120Hz) szDisplayModeLocalized 2560 x 1440 (32 bit) (120Hz) szDriverAssemblyVersion 23.21.13.8800 szDriverAttributes Final Retail szDriverDateEnglish 12.10.2017 01:00:00 szDriverDateLocalized 10/12/2017 01:00:00 szDriverLanguageEnglish English szDriverLanguageLocalized Englisch szDriverModelEnglish WDDM 2.3 szDriverModelLocalized WDDM 2.3 szDriverName C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_2e44aad2706ac9ff\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_2e44aad2706ac9ff\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_2e44aad2706ac9ff\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_2e44aad2706ac9ff\nvldumdx.dll szDriverNodeStrongName oem18.inf:0f066de361856a84:Section136:23.21.13.8800:pci\ven_10de&dev_1b80 szDriverSignDate Unknown szDriverVersion 23.21.0013.8800 szKeyDeviceID Enum\PCI\VEN_10DE&DEV_1B80&SUBSYS_33661462&REV_A1 szKeyDeviceKey \Registry\Machine\System\CurrentControlSet\Control\Video\{3E4D818B-B42A-11E7-9DD3-F4A388F1CB8E}\0000 szManufacturer NVIDIA szMiniVdd Unbekannt szMiniVddDateEnglish Unknown szMiniVddDateLocalized Unbekannt szMonitorMaxRes Unknown szMonitorName Generic PnP Monitor szNotesEnglish No problems found. szNotesLocalized Es wurden keine Probleme gefunden. szOverlayEnglish Supported szRankOfInstalledDriver 00D12001 szRegHelpText Unknown szRevision Unknown szRevisionId 0x00A1 szSubSysId 0x33661462 szTestResultD3D7English Not run szTestResultD3D7Localized Nicht ausgeführt szTestResultD3D8English Not run szTestResultD3D8Localized Nicht ausgeführt szTestResultD3D9English Not run szTestResultD3D9Localized Nicht ausgeführt szTestResultDDEnglish Not run szTestResultDDLocalized Nicht ausgeführt szVdd Unbekannt szVendorId 0x10DE
,
Nov 1 2017
Re #18 and #19, please file a separate bug on your issue. Before you do that, please check the instructions at the following link (your report is consistent with users who have installed color profiles but don't want them to be respected): https://docs.google.com/document/d/1jMokB_OBkZVELu22li8vnHxAUoL1eGnLedP-1Gttv40/edit?usp=sharing
,
Dec 26 2017
More information if needed, as this issue is happening to me as well. I have an AMD 7970 GPU Windows 8.1 64 bit Chrome 63.0.3239.108 (64-bit) Any other program displays all videos fine. When HW Acceleration is enabled in Chrome all videos including local mp4 files from the computer Chrome is running on all have washed out colours and light blacks (gamma shift). All screenshots taken are from the same black frame in various videos, Firefox always on the right, Chrome always on the left. Files are labelled with HWacc enabled or disabled. I do not have any colour profiles enabled other than default sRGB for Windows. Just in case I tried the #force-color-profile flag to sRGB with no change. Screenshots and about://gpu output below. txt output for both HWacc enabled and disabled are both attached.
,
Jan 9 2018
Re #21, please try to reproduce the issue using Chrome Canary. If the issue persists, please file a new bug. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by pbomm...@chromium.org
, Jul 24 2017Components: Internals>GPU