The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac104bcd441991eea20e686ee5e5672cc82cb55a

commit ac104bcd441991eea20e686ee5e5672cc82cb55a
Author: Justin Donnelly <jdonnelly@chromium.org>
Date: Mon Jul 24 17:36:44 2017

Don't send the service worker startup hint in incognito mode.

Bug:  748068 
Change-Id: If9ead9fc7330d0dc53e144d6f0d37fb47d9b8644
Reviewed-on: https://chromium-review.googlesource.com/583293
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489017}
[modify] https://crrev.com/ac104bcd441991eea20e686ee5e5672cc82cb55a/components/omnibox/browser/autocomplete_controller.cc

For the record, privacy review asked for a test of this functionality.  Obviously, the test doesn't have to be merged, but probably this bug should stay open until one is added.

Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

mpearson: Good point, thanks for catching this. Test code available for review at http://crrev.com/c/585295.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf4a687015262c06c4a4811aba9c06c6e8564087

commit bf4a687015262c06c4a4811aba9c06c6e8564087
Author: Justin Donnelly <jdonnelly@chromium.org>
Date: Tue Jul 25 18:34:10 2017

Don't send the service worker startup hint in incognito mode.

TBR=jdonnelly@chromium.org

(cherry picked from commit ac104bcd441991eea20e686ee5e5672cc82cb55a)

Bug:  748068 
Change-Id: If9ead9fc7330d0dc53e144d6f0d37fb47d9b8644
Reviewed-on: https://chromium-review.googlesource.com/583293
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489017}
Reviewed-on: https://chromium-review.googlesource.com/585360
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#31}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/bf4a687015262c06c4a4811aba9c06c6e8564087/components/omnibox/browser/autocomplete_controller.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7a6fec858c2eb69f235dcf104307bde907c9817

commit a7a6fec858c2eb69f235dcf104307bde907c9817
Author: Justin Donnelly <jdonnelly@chromium.org>
Date: Tue Aug 01 14:59:22 2017

Test ChromeAutocompleteProviderClient::StartServiceWorker.

Introduces two new test classes in content/public/test. Also, moves the
incognito check from the call site to the method itself,for both
testability and safety.

Bug:  748068 
Change-Id: I3b9b883a47e35ee229f811bb524b3f1a4621b22d
Reviewed-on: https://chromium-review.googlesource.com/585295
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490994}
[modify] https://crrev.com/a7a6fec858c2eb69f235dcf104307bde907c9817/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/a7a6fec858c2eb69f235dcf104307bde907c9817/chrome/browser/autocomplete/chrome_autocomplete_provider_client.h
[add] https://crrev.com/a7a6fec858c2eb69f235dcf104307bde907c9817/chrome/browser/autocomplete/chrome_autocomplete_provider_client_unittest.cc
[modify] https://crrev.com/a7a6fec858c2eb69f235dcf104307bde907c9817/chrome/test/BUILD.gn
[modify] https://crrev.com/a7a6fec858c2eb69f235dcf104307bde907c9817/components/omnibox/browser/autocomplete_controller.cc
[modify] https://crrev.com/a7a6fec858c2eb69f235dcf104307bde907c9817/components/omnibox/browser/autocomplete_provider_client.h
[modify] https://crrev.com/a7a6fec858c2eb69f235dcf104307bde907c9817/content/browser/browsing_data/browsing_data_remover_impl_unittest.cc
[add] https://crrev.com/a7a6fec858c2eb69f235dcf104307bde907c9817/content/public/test/mock_service_worker_context.cc
[add] https://crrev.com/a7a6fec858c2eb69f235dcf104307bde907c9817/content/public/test/mock_service_worker_context.h
[add] https://crrev.com/a7a6fec858c2eb69f235dcf104307bde907c9817/content/public/test/test_storage_partition.cc
[add] https://crrev.com/a7a6fec858c2eb69f235dcf104307bde907c9817/content/public/test/test_storage_partition.h
[modify] https://crrev.com/a7a6fec858c2eb69f235dcf104307bde907c9817/content/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/020014791f31622c9d659c9091745eeb86c53422

commit 020014791f31622c9d659c9091745eeb86c53422
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Aug 03 03:31:00 2017

Initialize ChromeAutocompleteProviderClient::storage_partition_

Followup to r490994.

Bug: 751412,  748068 
Change-Id: Ia3c25f86e45fa67e1a6e01d9edfe79bd515ec3f4
Reviewed-on: https://chromium-review.googlesource.com/598660
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491630}
[modify] https://crrev.com/020014791f31622c9d659c9091745eeb86c53422/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc