New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747990 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Disable switch to manual auth flow.

Project Member Reported by khmel@chromium.org, Jul 24 2017

Issue description

Manual authorization flow is now been deprecated. 56+ builds does not support this anymore. We have to disable possibility to switch to manual flow using chrome://flags.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f45942679e284aa9fcfeb3afa9e6d2ca4e6103b8

commit f45942679e284aa9fcfeb3afa9e6d2ca4e6103b8
Author: khmel <khmel@google.com>
Date: Mon Jul 24 16:16:14 2017

arc: Manual auth flow deprecation. Disable switch.

This disables possibility to activate old auth flow that requires user's
interaction. This flow was invalidated by GAYA team and no longer
supported for M56+.

Test: Manually
Bug:  747990 
Bug: b/63800376
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4826c022e52e1fe6f532049e3a3b4b762874d8e2
Reviewed-on: https://chromium-review.googlesource.com/581667
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488990}
[modify] https://crrev.com/f45942679e284aa9fcfeb3afa9e6d2ca4e6103b8/chrome/browser/about_flags.cc
[modify] https://crrev.com/f45942679e284aa9fcfeb3afa9e6d2ca4e6103b8/chrome/browser/chromeos/arc/auth/arc_auth_service.cc
[modify] https://crrev.com/f45942679e284aa9fcfeb3afa9e6d2ca4e6103b8/chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
[modify] https://crrev.com/f45942679e284aa9fcfeb3afa9e6d2ca4e6103b8/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/f45942679e284aa9fcfeb3afa9e6d2ca4e6103b8/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/f45942679e284aa9fcfeb3afa9e6d2ca4e6103b8/components/arc/arc_features.cc
[modify] https://crrev.com/f45942679e284aa9fcfeb3afa9e6d2ca4e6103b8/components/arc/arc_features.h

Comment 2 by khmel@chromium.org, Jul 26 2017

Labels: Merge-Request-61

Comment 3 by ketakid@google.com, Jul 26 2017

Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 31 2017

Cc: ketakid@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 2 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c34c954d7c23922c40e0576de02ff79c1ed95f77

commit c34c954d7c23922c40e0576de02ff79c1ed95f77
Author: khmel <khmel@google.com>
Date: Wed Aug 02 07:11:02 2017

[Merge M61] arc: Manual auth flow deprecation. Disable switch.

This disables possibility to activate old auth flow that requires user's
interaction. This flow was invalidated by GAYA team and no longer
supported for M56+.

Test: Manually
Bug:  747990 
Bug: b/63800376
TBR=hidehiko@chromium.org, khmel@google.com
NOTRY=true
NOPRESUBMIT=true

(cherry picked from commit f45942679e284aa9fcfeb3afa9e6d2ca4e6103b8)

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4826c022e52e1fe6f532049e3a3b4b762874d8e2
Reviewed-on: https://chromium-review.googlesource.com/581667
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488990}
Reviewed-on: https://chromium-review.googlesource.com/597503
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#234}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/c34c954d7c23922c40e0576de02ff79c1ed95f77/chrome/browser/about_flags.cc
[modify] https://crrev.com/c34c954d7c23922c40e0576de02ff79c1ed95f77/chrome/browser/chromeos/arc/auth/arc_auth_service.cc
[modify] https://crrev.com/c34c954d7c23922c40e0576de02ff79c1ed95f77/chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
[modify] https://crrev.com/c34c954d7c23922c40e0576de02ff79c1ed95f77/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/c34c954d7c23922c40e0576de02ff79c1ed95f77/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/c34c954d7c23922c40e0576de02ff79c1ed95f77/components/arc/arc_features.cc
[modify] https://crrev.com/c34c954d7c23922c40e0576de02ff79c1ed95f77/components/arc/arc_features.h

Comment 6 by khmel@chromium.org, Aug 2 2017

Status: Fixed (was: Started)
Cc: nataraj....@intel.com
Hi, after this issue, external contributors cannot log in play store using their own local build image. I usually work on reef with disable arc-use-auth-endpoint in chrome://flags. Partner test image works well tho.

Here's log from my reef image. Is there workaround, which allows external contributor log in play store?

localhost log # tail -f chrome/chrome ui/ui.LATEST messages

==> chrome/chrome <==
[1418:1418:0802/141736.370110:VERBOSE1:login_performer.cc(288)] Online login completion started.
[1418:1418:0802/141736.370453:VERBOSE1:cryptohome_authenticator.cc(774)] Resolved state to: 0
[1418:1418:0802/141736.440598:ERROR:user_session_manager.cc(1940)] OAuth2 token handle fetch failed.
[1418:1418:0802/141736.493253:ERROR:device_event_log_impl.cc(156)] [14:17:36.493] Login: homedir_methods.cc:332 HomedirMethods MountEx error (CryptohomeErrorCode): 1
[1418:1418:0802/141736.493395:ERROR:device_event_log_impl.cc(156)] [14:17:36.493] Login: cryptohome_authenticator.cc:931 Cryptohome failure: state(AuthState)=1, code(cryptohome::MountError)=32
[1418:1418:0802/141736.493472:VERBOSE1:cryptohome_authenticator.cc(774)] Resolved state to: 6
[1418:1418:0802/141738.091853:VERBOSE1:cryptohome_authenticator.cc(774)] Resolved state to: 13
[1418:1418:0802/141738.092266:VERBOSE1:cryptohome_authenticator.cc(663)] Login success
[1418:1418:0802/141738.092744:VERBOSE1:login_performer.cc(87)] LoginSuccess hash: 206c15532e0f107eb3155ad76c8d1c5eea64d6b2
[1418:1418:0802/141738.092849:VERBOSE1:user_session_manager.cc(510)] Starting user session.

==> ui/ui.LATEST <==
[1418:1418:0802/141829.975730:ERROR:session_manager_client.cc(891)] Failed to call StartArcInstance: message_type: MESSAGE_ERROR
destination: :1.10
error_name: org.chromium.SessionManagerInterface.ContainerStartupFail
sender: :1.4
signature: s
serial: 52
reply_serial: 429

string "Failed to get arc-bridge gid"

[1418:1418:0802/141829.975921:ERROR:arc_session.cc(389)] Failed to start ARC instance

==> messages <==
2017-08-02T21:18:29.975241+00:00 ERR session_manager[1390]: [ERROR:dbus_util.cc(14)] CreateError(...): Domain=dbus, Code=org.chromium.SessionManagerInterface.ContainerStartupFail, Message=Failed to get arc-bridge gid

Comment 8 by khmel@chromium.org, Aug 2 2017

hi,

Last error it seems not related to this change.
I see 
[1418:1418:0802/141736.440598:ERROR:user_session_manager.cc(1940)] OAuth2 token handle fetch failed.
that may describe your problem.

In general there is no restriction to use current auth endpoint mechanism. If you unable to login could you create separate bug and attach log files and steps to reproduce?

I'm having the same problem as in Comment 7. I can no longer use my local build image to log in to the Play Store.

Was a separate bug ever created? I can't seem to find one.

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment