testCleartextTrafficBlocked seems to fail |
||||
Issue description
1. Run GN for Cronet for x86:
gn gen out/Release --args='use_errorprone_java_compiler=true arm_use_neon=false target_os="android" enable_websockets=false disable_file_support=true disable_ftp_support=true disable_brotli_filter=false use_platform_icu_alternatives=true enable_reporting=false is_component_build=false ignore_elf32_limitations=true use_partition_alloc=false target_cpu="x86"'
2. See https://paste.googleplex.com/4815557513707520 or attach x86 Android Nougat device
3. ./components/cronet/tools/cr_cronet.py -r build-test
C 507.729s Main [FAIL] org.chromium.net.CronetUrlRequestTest#testCleartextTrafficBlocked:
C 507.729s Main java.lang.Throwable: CronetTestBase#runTest failed.
C 507.729s Main at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:200)
C 507.730s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:198)
C 507.730s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:183)
C 507.730s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:560)
C 507.730s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1932)
C 507.730s Main Caused by: junit.framework.AssertionFailedError: Expected: <null> but was: UrlResponseInfo@[11e80f4][http://example.com/simple.txt]: urlChain = [http://example.com/simple.txt], httpStatus = 404 Not Found, headers = [Content-Encoding=gzip, Cache-Control=max-age=604800, Content-Type=text/html, Date=Mon, 24 Jul 2017 14:28:35 GMT, Expires=Mon, 31 Jul 2017 14:28:35 GMT, Last-Modified=Fri, 21 Jul 2017 14:36:40 GMT, Server=ECS (oxr/83D0), Vary=Accept-Encoding, X-Cache=404-HIT, Content-Length=606], wasCached = false, negotiatedProtocol = unknown, proxyServer= :0, receivedByteCount = 921
C 507.730s Main at org.chromium.net.CronetUrlRequestTest.testCleartextTrafficBlocked(CronetUrlRequestTest.java:2117)
C 507.730s Main at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:186)
C 507.730s Main ... 9 more
,
Jul 24 2017
I should have mentioned it's much faster if you add "-f CronetUrlRequestTest#testCleartextTrafficBlocked" to my third step command.
,
Jul 24 2017
Ughhh. This worked on N when I wrote it, but we don't have bots so it's not too surprising that it broke. The network security config isn't getting into the APK correctly. git bisect pointed me to https://codereview.chromium.org/2561803002 as the place where the test first broke. (That's a week and a half after it first landed, several months ago.) That CL added a new resource dir to the same APK that has a different network security config in it, and it appears the second one is being used. Fix on the way.
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eafa6e088fe263ed0cc1aa9f6a083d3b0fbc958c commit eafa6e088fe263ed0cc1aa9f6a083d3b0fbc958c Author: Miriam Gershenson <mgersh@chromium.org> Date: Tue Jul 25 14:55:42 2017 Delete duplicate network security config Resources in this directory go into the same apk as resources in components/cronet/android/test/res/. Both have a network security config, but this one isn't necessary for anything and the build system is choosing it over the other one, which is needed for CronetUrlRequestTest.testCleartextTrafficBlocked. BUG= 747981 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: If408527f22dc3c46f4d4a2b7605f36b6e445bfd2 Reviewed-on: https://chromium-review.googlesource.com/583887 Reviewed-by: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#489296} [delete] https://crrev.com/463dc50e730013d2c12f913bebf8e417d9312789/components/cronet/android/test/smoketests/res/native/xml/network_security_config.xml
,
Jul 25 2017
,
Nov 1 2017
,
Nov 1 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mge...@chromium.org
, Jul 24 2017