New issue
Advanced search Search tips

Issue 747976 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Tests fail due to change in Skia's GrSurface

Project Member Reported by robertphillips@chromium.org, Jul 24 2017

Issue description

The Skia CL https://skia-review.googlesource.com/c/25802/ (Second small fragment from "Reduce dependence on GrSurface's origin field") caused some small image differences in the layout tests.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/592b375bff8b21911a61e2a92b1244075f9015d4

commit 592b375bff8b21911a61e2a92b1244075f9015d4
Author: Robert Phillips <robertphillips@google.com>
Date: Mon Jul 24 19:31:01 2017

Add layout test suppressions for upcoming Skia roll

Bug:  747976 
Change-Id: Ia8466c55dacfae91c20b0384fde56d14550778f6
Reviewed-on: https://chromium-review.googlesource.com/582931
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489046}
[modify] https://crrev.com/592b375bff8b21911a61e2a92b1244075f9015d4/third_party/WebKit/LayoutTests/TestExpectations

Cc: robertphillips@chromium.org
Components: Blink>Paint
Labels: BugSource-Chromium PaintTeamTriaged-20170802
Owner: schenney@chromium.org
Summary: Tests fail due to change in Skia's GrSurface (was: Add suppressions for upcoming Skia roll)
I'll do the rebaseline.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0934148e0114e13d9c289df866053bfda9e1298b

commit 0934148e0114e13d9c289df866053bfda9e1298b
Author: Stephen Chenney <schenney@chromium.org>
Date: Fri Aug 04 21:11:33 2017

Rebaseline changes due to Skia's GrSurface changes

TBR=fmalita@chromium.org
BUG= 747976 

Change-Id: I531460d7c8fa05ffbbc97b663cdd44b926f0291c
Reviewed-on: https://chromium-review.googlesource.com/598544
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492122}
[modify] https://crrev.com/0934148e0114e13d9c289df866053bfda9e1298b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/0934148e0114e13d9c289df866053bfda9e1298b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-composite-video-expected.png
[modify] https://crrev.com/0934148e0114e13d9c289df866053bfda9e1298b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-composite-video-shadow-expected.png
[modify] https://crrev.com/0934148e0114e13d9c289df866053bfda9e1298b/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png
[modify] https://crrev.com/0934148e0114e13d9c289df866053bfda9e1298b/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu/fast/canvas/canvas-composite-video-expected.png
[modify] https://crrev.com/0934148e0114e13d9c289df866053bfda9e1298b/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu/fast/canvas/canvas-composite-video-shadow-expected.png
[modify] https://crrev.com/0934148e0114e13d9c289df866053bfda9e1298b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-composite-video-expected.png
[modify] https://crrev.com/0934148e0114e13d9c289df866053bfda9e1298b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-composite-video-shadow-expected.png
[modify] https://crrev.com/0934148e0114e13d9c289df866053bfda9e1298b/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png
[modify] https://crrev.com/0934148e0114e13d9c289df866053bfda9e1298b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-composite-video-expected.png
[modify] https://crrev.com/0934148e0114e13d9c289df866053bfda9e1298b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-composite-video-shadow-expected.png
[modify] https://crrev.com/0934148e0114e13d9c289df866053bfda9e1298b/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png

Status: Fixed (was: Assigned)

Sign in to add a comment