New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747973 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit 16 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Have section string title cased

Project Member Reported by gambard@chromium.org, Jul 24 2017

Issue description

Android uses Sentence case for the ContentSuggestions sections title ("Articles for you"). On iOS, title cases should be used ("Articles for You").
 
Cc: treib@chromium.org
+treib@ for advice.
I am using the string given by the ContentSuggestionsService. Any idea of how I can do this?
Cc: -treib@chromium.org gambard@chromium.org
Owner: treib@chromium.org
Feel free to reassign to someone else.

Comment 3 by treib@chromium.org, Jul 31 2017

Cc: treib@chromium.org
Owner: markusheintz@chromium.org
There are two types of sections to consider:

1) Local sections (bookmarks, downloads etc): The strings are defined in a .grd file. You can add "if OS=ios" (don't remember the exact syntax) to have different strings for iOS.

2) Remote sections (articles and others): The strings are provided by the server, so we'd have to update the server to hand out different strings to iOS clients. This requires either a new field in the protocol ("want_title_case"), or maybe we can do it based on the user agent.

Assigning to Markus to estimate how much work the server-side changes would be.
Labels: zine-triaged
markusheintz@: ping :)
Labels: -Pri-3 Pri-1
Labels: M-62
Could we simply change the String and use title case on all Platforms?

Why do we want/need different Platform behaviors?
I think Chrome on Android uses sentence case in the app (toolbar menu for example). On iOS title case is used.
So I guess we need different behaviors to stay consistent with the rest of the app.
Cc: amyroberts@chromium.org nepper@chromium.org rachelis@chromium.org tschumann@chromium.org srahim@chromium.org
+ UX folks, tschumann, nepper

I spoke with Markus. This will take some time (~1-2 days) as it involves changes as outlined in #3. 
Markus will try to get this done before Feature Freeze but I wouldn't want to hold off on the UI implementation review until this bug is resolved. I think it's fine to send for a UI implementation review and say this is a known issue that we'll fix before branch date. Does that sounds good ?

Owner: imansourov@chromium.org
Routing this to Igor.

He also reminded me that we may not even need a protocol change since we can use the UserAgent string.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9169af5e8a1a2b3530ccc1f2dd8a4047f85601d2

commit 9169af5e8a1a2b3530ccc1f2dd8a4047f85601d2
Author: gambard <gambard@chromium.org>
Date: Tue Aug 08 09:07:14 2017

Let ContentSuggestions title be title cased

Android uses sentence case for the title, iOS uses title case. This CL
changes the local suggestions only.

Bug:  747973 
Change-Id: I06839d73f44f39cf058c9e2f609b6db7a6bb9c2f
Reviewed-on: https://chromium-review.googlesource.com/603714
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492574}
[modify] https://crrev.com/9169af5e8a1a2b3530ccc1f2dd8a4047f85601d2/components/ntp_snippets_strings.grdp

Server change landed
Owner: markusheintz@chromium.org
The server change is working on iOS Canary.
Cool, can this be marked fixed now?
Friendly ping.
Status: Fixed (was: Assigned)
For me it is fixed.
Markus: re-open it if you think something else should be done.
Status: Verified (was: Fixed)
Verified in 62.0.3202.38 Beta, iPhone 6 plus iOS 10.3.3, iPhone 7 iOS11, iPad Pro iOS11
ContentSuggestions title is title cased on iOS. 
This is the string that is shown 'Articles for You'

Sign in to add a comment