Have section string title cased |
|||||||||||
Issue description
Android uses Sentence case for the ContentSuggestions sections title ("Articles for you"). On iOS, title cases should be used ("Articles for You").
,
Jul 26 2017
Feel free to reassign to someone else.
,
Jul 31 2017
There are two types of sections to consider:
1) Local sections (bookmarks, downloads etc): The strings are defined in a .grd file. You can add "if OS=ios" (don't remember the exact syntax) to have different strings for iOS.
2) Remote sections (articles and others): The strings are provided by the server, so we'd have to update the server to hand out different strings to iOS clients. This requires either a new field in the protocol ("want_title_case"), or maybe we can do it based on the user agent.
Assigning to Markus to estimate how much work the server-side changes would be.
,
Aug 2 2017
,
Aug 3 2017
markusheintz@: ping :)
,
Aug 3 2017
,
Aug 7 2017
,
Aug 7 2017
Could we simply change the String and use title case on all Platforms? Why do we want/need different Platform behaviors?
,
Aug 7 2017
I think Chrome on Android uses sentence case in the app (toolbar menu for example). On iOS title case is used. So I guess we need different behaviors to stay consistent with the rest of the app.
,
Aug 7 2017
+ UX folks, tschumann, nepper I spoke with Markus. This will take some time (~1-2 days) as it involves changes as outlined in #3. Markus will try to get this done before Feature Freeze but I wouldn't want to hold off on the UI implementation review until this bug is resolved. I think it's fine to send for a UI implementation review and say this is a known issue that we'll fix before branch date. Does that sounds good ?
,
Aug 7 2017
Routing this to Igor. He also reminded me that we may not even need a protocol change since we can use the UserAgent string.
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9169af5e8a1a2b3530ccc1f2dd8a4047f85601d2 commit 9169af5e8a1a2b3530ccc1f2dd8a4047f85601d2 Author: gambard <gambard@chromium.org> Date: Tue Aug 08 09:07:14 2017 Let ContentSuggestions title be title cased Android uses sentence case for the title, iOS uses title case. This CL changes the local suggestions only. Bug: 747973 Change-Id: I06839d73f44f39cf058c9e2f609b6db7a6bb9c2f Reviewed-on: https://chromium-review.googlesource.com/603714 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#492574} [modify] https://crrev.com/9169af5e8a1a2b3530ccc1f2dd8a4047f85601d2/components/ntp_snippets_strings.grdp
,
Aug 9 2017
Server change landed
,
Aug 9 2017
,
Aug 10 2017
The server change is working on iOS Canary.
,
Aug 14 2017
Cool, can this be marked fixed now?
,
Aug 16 2017
Friendly ping.
,
Aug 16 2017
For me it is fixed. Markus: re-open it if you think something else should be done.
,
Sep 27 2017
Verified in 62.0.3202.38 Beta, iPhone 6 plus iOS 10.3.3, iPhone 7 iOS11, iPad Pro iOS11 ContentSuggestions title is title cased on iOS. This is the string that is shown 'Articles for You' |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by gambard@chromium.org
, Jul 25 2017